Expose Physical Web data on multiple platforms |
|||||
Issue descriptionWe need to create a common resource for exposing Physical Web data on multiple platforms (i.e. Android, iOS, etc).
,
Aug 24 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1098aecd3818cf9eef26cfa77aed4ae51f6621c6 commit 1098aecd3818cf9eef26cfa77aed4ae51f6621c6 Author: hayesjordan <hayesjordan@google.com> Date: Wed Aug 24 02:33:10 2016 Expose Physical Web data The goal is to create an API for pushing changes of Physical Web data, such as new URLs found, so that other parties can react to the change without constantly pulling the data. To do this we are providing an API that allows others to register a listener for push updates when data changes. BUG= 636490 Review-Url: https://codereview.chromium.org/2231983002 Cr-Commit-Position: refs/heads/master@{#413948} [modify] https://crrev.com/1098aecd3818cf9eef26cfa77aed4ae51f6621c6/components/omnibox/browser/physical_web_provider_unittest.cc [modify] https://crrev.com/1098aecd3818cf9eef26cfa77aed4ae51f6621c6/components/physical_web/data_source/BUILD.gn [modify] https://crrev.com/1098aecd3818cf9eef26cfa77aed4ae51f6621c6/components/physical_web/data_source/physical_web_data_source.h [add] https://crrev.com/1098aecd3818cf9eef26cfa77aed4ae51f6621c6/components/physical_web/data_source/physical_web_listener.h [modify] https://crrev.com/1098aecd3818cf9eef26cfa77aed4ae51f6621c6/ios/chrome/common/physical_web/ios_chrome_physical_web_data_source.h [modify] https://crrev.com/1098aecd3818cf9eef26cfa77aed4ae51f6621c6/ios/chrome/common/physical_web/ios_chrome_physical_web_data_source.mm
,
Aug 26 2016
,
Sep 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aaed874c386983f2d60e235ec6b3314e77474f66 commit aaed874c386983f2d60e235ec6b3314e77474f66 Author: hayesjordan <hayesjordan@google.com> Date: Mon Sep 12 19:45:24 2016 Cache Physical Web Service results To reduce lantency when other parties request Physical Web data, Physical Web Service (PWS) results need to be cached. Otherwise the Physical Web would have to make another request to the PWS server to get the data again. BUG= 636490 Review-Url: https://codereview.chromium.org/2322073003 Cr-Commit-Position: refs/heads/master@{#418008} [modify] https://crrev.com/aaed874c386983f2d60e235ec6b3314e77474f66/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java [modify] https://crrev.com/aaed874c386983f2d60e235ec6b3314e77474f66/chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/UrlManagerTest.java
,
Sep 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/576c1dde62f1bc26e4366d50b32f76a636a1dbbd commit 576c1dde62f1bc26e4366d50b32f76a636a1dbbd Author: hayesjordan <hayesjordan@google.com> Date: Mon Sep 19 19:32:18 2016 Add access to Physical Web Service results To allow access to Physical Web data, the URL info and Physical Web Service data needs to be paired together. The pairing gives all relevant information for a scanned URL. BUG= 636490 Review-Url: https://codereview.chromium.org/2330253002 Cr-Commit-Position: refs/heads/master@{#419531} [add] https://crrev.com/576c1dde62f1bc26e4366d50b32f76a636a1dbbd/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PwCollection.java [modify] https://crrev.com/576c1dde62f1bc26e4366d50b32f76a636a1dbbd/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java [modify] https://crrev.com/576c1dde62f1bc26e4366d50b32f76a636a1dbbd/chrome/android/java_sources.gni [modify] https://crrev.com/576c1dde62f1bc26e4366d50b32f76a636a1dbbd/chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/UrlManagerTest.java
,
Sep 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a48869ce359e14888a540f47accd6dfff0fac029 commit a48869ce359e14888a540f47accd6dfff0fac029 Author: dimich <dimich@chromium.org> Date: Mon Sep 19 21:25:38 2016 Revert of Add access to Physical Web Service results (patchset #5 id:80001 of https://codereview.chromium.org/2330253002/ ) Reason for revert: Broke build (compile): https://build.chromium.org/p/chromium.linux/builders/Android%20Clang%20Builder%20%28dbg%29/builds/87504/steps/compile/logs/stdio ******************************************************************************** FindBugs run via: java -classpath /mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/third_party/findbugs/lib/findbugs.jar: -Xmx768m -Dfindbugs.home="/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/third_party/findbugs" -jar /mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/third_party/findbugs/lib/findbugs.jar -textui -sortByClass -pluginList /mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/tools/android/findbugs_plugin/lib/chromiumPlugin.jar -xml:withMessages -auxclasspath /mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/third_party/android_tools/sdk/platforms/android-23/android.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/base/base_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/chrome/android/webapk/libs/client/client_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/chrome/android/webapk/libs/common/common_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/chrome/android/webapk/libs/runtime_library/webapk_service_aidl_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/components/safe_json/android/safe_json_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/components/spellcheck/browser/android/java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/components/variations/android/variations_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/components/web_contents_delegate_android/web_contents_delegate_android_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/components/web_restrictions/web_restrictions_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/content/public/android/content_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/device/geolocation/geolocation_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/media/base/android/media_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/media/capture/content/android/screen_capture_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/media/capture/video/android/capture_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/media/midi/midi_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/mojo/public/java/bindings.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/mojo/public/java/system.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/net/android/net_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/printing/printing_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/WebKit/public/android_mojo_bindings_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/WebKit/public/blink_headers_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/android_data_chart/android_data_chart_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/android_media/android_media_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/android_protobuf/protobuf_nano_javalib.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/android_swipe_refresh/android_swipe_refresh_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/android_tools/android_gcm_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/android_tools/android_support_annotations_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/android_tools/android_support_design_java__classes.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/android_tools/android_support_v13_java__classes.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/android_tools/android_support_v13_java__subjar_internal_impl_24.1.1.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/android_tools/android_support_v4_java__classes.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/android_tools/android_support_v4_java__subjar_internal_impl_24.1.1.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/android_tools/android_support_v7_appcompat_java_internal__classes.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/android_tools/android_support_vector_drawable_java__classes.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/android_tools/android_support_v7_mediarouter_java__classes.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/android_tools/android_support_v7_mediarouter_java__subjar_internal_impl_24.1.1.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/android_tools/android_support_v7_recyclerview_java__classes.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/cacheinvalidation/cacheinvalidation_javalib.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/cacheinvalidation/cacheinvalidation_proto_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/custom_tabs_client/custom_tabs_support_lib.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/gif_player/gif_player_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/jsr-305/jsr_305_javalib.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/leakcanary/leakcanary_noop_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/ui/android/ui_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/url/mojo/url_mojom_gurl_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/android_tools/google_play_services_default_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/chrome/android/document_tab_model_info_proto_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/blimp/client/public/public_headers_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/blimp/client/core/dummy_core_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/components/bookmarks/common/android/bookmarks_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/components/dom_distiller/content/browser/android/dom_distiller_content_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/components/dom_distiller/core/android/dom_distiller_core_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/components/gcm_driver/android/gcm_driver_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/components/gcm_driver/instance_id/android/instance_id_driver_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/components/invalidation/impl/java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/components/location/android/location_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/components/navigation_interception/android/navigation_interception_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/components/ntp_tiles/android/ntp_tiles_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/components/policy/android/policy_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/components/precache/android/precache_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/components/safe_json/android/safe_json_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/components/signin/core/browser/android/java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/components/sync/android/sync_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/components/url_formatter/android/url_formatter_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/components/web_contents_delegate_android/web_contents_delegate_android_java.jar -exclude /mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/build/android/findbugs_filter/findbugs_exclude.xml -output gen/chrome/android/chrome_java__findbugs/result.xml /mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/chrome/android/chrome_java.jar FindBugs reported the following issues: EI_EXPOSE_REP2: May expose internal representation by incorporating reference to mutable object In class org.chromium.chrome.browser.physicalweb.PwCollection In method new org.chromium.chrome.browser.physicalweb.PwCollection(UrlInfo[], PwsResult[]) Field org.chromium.chrome.browser.physicalweb.PwCollection.urlInfos At PwCollection.java:[line 20] EI_EXPOSE_REP2: May expose internal representation by incorporating reference to mutable object In class org.chromium.chrome.browser.physicalweb.PwCollection In method new org.chromium.chrome.browser.physicalweb.PwCollection(UrlInfo[], PwsResult[]) Field org.chromium.chrome.browser.physicalweb.PwCollection.pwsResults At PwCollection.java:[line 21] ******************************************************************************** Original issue's description: > Add access to Physical Web Service results > > To allow access to Physical Web data, the URL info and Physical Web > Service data needs to be paired together. The pairing gives all relevant > information for a scanned URL. > > BUG= 636490 > > Committed: https://crrev.com/576c1dde62f1bc26e4366d50b32f76a636a1dbbd > Cr-Commit-Position: refs/heads/master@{#419531} TBR=cco3@chromium.org,dfalcantara@chromium.org,hayesjordan@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 636490 Review-Url: https://codereview.chromium.org/2356553002 Cr-Commit-Position: refs/heads/master@{#419554} [delete] https://crrev.com/d989e6a0815a6f77d3a6fbab24afe9ff6abbf25e/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PwCollection.java [modify] https://crrev.com/a48869ce359e14888a540f47accd6dfff0fac029/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java [modify] https://crrev.com/a48869ce359e14888a540f47accd6dfff0fac029/chrome/android/java_sources.gni [modify] https://crrev.com/a48869ce359e14888a540f47accd6dfff0fac029/chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/UrlManagerTest.java
,
Sep 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/394cd0ae7e135631c6fdb2b41ad651edd65d57b5 commit 394cd0ae7e135631c6fdb2b41ad651edd65d57b5 Author: hayesjordan <hayesjordan@google.com> Date: Mon Sep 19 23:42:39 2016 Add access to Physical Web Service results To allow access to Physical Web data, the URL info and Physical Web Service data needs to be paired together. The pairing gives all relevant information for a scanned URL. BUG= 636490 Committed: https://crrev.com/576c1dde62f1bc26e4366d50b32f76a636a1dbbd Review-Url: https://codereview.chromium.org/2330253002 Cr-Original-Commit-Position: refs/heads/master@{#419531} Cr-Commit-Position: refs/heads/master@{#419603} [add] https://crrev.com/394cd0ae7e135631c6fdb2b41ad651edd65d57b5/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PwCollection.java [modify] https://crrev.com/394cd0ae7e135631c6fdb2b41ad651edd65d57b5/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java [modify] https://crrev.com/394cd0ae7e135631c6fdb2b41ad651edd65d57b5/chrome/android/java_sources.gni [modify] https://crrev.com/394cd0ae7e135631c6fdb2b41ad651edd65d57b5/chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/UrlManagerTest.java
,
Sep 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7b30c99f5ea9b24f352c720280ee78edebca37cf commit 7b30c99f5ea9b24f352c720280ee78edebca37cf Author: hayesjordan <hayesjordan@google.com> Date: Fri Sep 23 18:58:37 2016 Implement Physical Web listener registration Implement the RegisterListener, UnregisterListener, and notify methods in an abstract class so that all Physical Web data sources can have an the ability to push data to subscribers. BUG= 636490 Review-Url: https://codereview.chromium.org/2349483002 Cr-Commit-Position: refs/heads/master@{#420682} [modify] https://crrev.com/7b30c99f5ea9b24f352c720280ee78edebca37cf/components/BUILD.gn [modify] https://crrev.com/7b30c99f5ea9b24f352c720280ee78edebca37cf/components/physical_web/data_source/BUILD.gn [add] https://crrev.com/7b30c99f5ea9b24f352c720280ee78edebca37cf/components/physical_web/data_source/physical_web_data_source_impl.cc [add] https://crrev.com/7b30c99f5ea9b24f352c720280ee78edebca37cf/components/physical_web/data_source/physical_web_data_source_impl.h [add] https://crrev.com/7b30c99f5ea9b24f352c720280ee78edebca37cf/components/physical_web/data_source/physical_web_data_source_impl_unittest.cc [modify] https://crrev.com/7b30c99f5ea9b24f352c720280ee78edebca37cf/ios/chrome/common/physical_web/ios_chrome_physical_web_data_source.h [modify] https://crrev.com/7b30c99f5ea9b24f352c720280ee78edebca37cf/ios/chrome/common/physical_web/ios_chrome_physical_web_data_source.mm
,
Oct 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/af547481c048ad892f64ee375a6698ff742605cd commit af547481c048ad892f64ee375a6698ff742605cd Author: hayesjordan <hayesjordan@google.com> Date: Tue Oct 04 03:09:42 2016 Use LibraryLoader to check for native library BUG= 636490 Review-Url: https://codereview.chromium.org/2370943003 Cr-Commit-Position: refs/heads/master@{#422686} [modify] https://crrev.com/af547481c048ad892f64ee375a6698ff742605cd/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebUma.java
,
Oct 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f1aab392e8953a9ce8aa289a62ee157b59f629a5 commit f1aab392e8953a9ce8aa289a62ee157b59f629a5 Author: mattreynolds <mattreynolds@chromium.org> Date: Fri Oct 07 00:17:07 2016 Add an empty Android implementation of the PhysicalWebDataSource The Physical Web data source collects information about nearby devices broadcasting URLs and makes the list of URLs and associated metadata available to components within Chrome. This change adds an empty implementation of the data source in Chrome for Android and makes it available from a BrowserProcess. BUG= 636490 Review-Url: https://codereview.chromium.org/2361603002 Cr-Commit-Position: refs/heads/master@{#423754} [modify] https://crrev.com/f1aab392e8953a9ce8aa289a62ee157b59f629a5/chrome/browser/BUILD.gn [add] https://crrev.com/f1aab392e8953a9ce8aa289a62ee157b59f629a5/chrome/browser/android/physical_web/physical_web_data_source_android.cc [add] https://crrev.com/f1aab392e8953a9ce8aa289a62ee157b59f629a5/chrome/browser/android/physical_web/physical_web_data_source_android.h [modify] https://crrev.com/f1aab392e8953a9ce8aa289a62ee157b59f629a5/chrome/browser/browser_process.h [modify] https://crrev.com/f1aab392e8953a9ce8aa289a62ee157b59f629a5/chrome/browser/browser_process_impl.cc [modify] https://crrev.com/f1aab392e8953a9ce8aa289a62ee157b59f629a5/chrome/browser/browser_process_impl.h [modify] https://crrev.com/f1aab392e8953a9ce8aa289a62ee157b59f629a5/chrome/test/base/testing_browser_process.cc [modify] https://crrev.com/f1aab392e8953a9ce8aa289a62ee157b59f629a5/chrome/test/base/testing_browser_process.h
,
Oct 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/144c8c4437f3ceae3dfe8d07e8a76aaf3e3e7a0f commit 144c8c4437f3ceae3dfe8d07e8a76aaf3e3e7a0f Author: mattreynolds <mattreynolds@chromium.org> Date: Wed Oct 12 20:46:47 2016 Add a Physical Web JNI bridge to support native Physical Web clients On Android, the Physical Web scanner is implemented in the Java layer. To support native Physical Web clients, the metadata about nearby URLs is made available via a JNI bridge. If the native client has also registered as a Physical Web listener, it will also be notified whenever a nearby URL is found or lost, or when the estimated distance to the device broadcasting the URL is updated. This change includes the methods necessary to initialize the bridge. BUG= 636490 Review-Url: https://codereview.chromium.org/2377513002 Cr-Commit-Position: refs/heads/master@{#424843} [modify] https://crrev.com/144c8c4437f3ceae3dfe8d07e8a76aaf3e3e7a0f/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java [modify] https://crrev.com/144c8c4437f3ceae3dfe8d07e8a76aaf3e3e7a0f/chrome/browser/BUILD.gn [modify] https://crrev.com/144c8c4437f3ceae3dfe8d07e8a76aaf3e3e7a0f/chrome/browser/android/chrome_jni_registrar.cc [modify] https://crrev.com/144c8c4437f3ceae3dfe8d07e8a76aaf3e3e7a0f/chrome/browser/android/physical_web/physical_web_data_source_android.cc [modify] https://crrev.com/144c8c4437f3ceae3dfe8d07e8a76aaf3e3e7a0f/chrome/browser/android/physical_web/physical_web_data_source_android.h
,
Oct 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8897fde5a48caa529e4b2e82a7da3d518f232e19 commit 8897fde5a48caa529e4b2e82a7da3d518f232e19 Author: mattreynolds <mattreynolds@chromium.org> Date: Tue Oct 25 18:28:25 2016 Expose Physical Web metadata to native clients over JNI BUG= 636490 Review-Url: https://codereview.chromium.org/2403423005 Cr-Commit-Position: refs/heads/master@{#427418} [modify] https://crrev.com/8897fde5a48caa529e4b2e82a7da3d518f232e19/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java [modify] https://crrev.com/8897fde5a48caa529e4b2e82a7da3d518f232e19/chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/UrlManagerTest.java [modify] https://crrev.com/8897fde5a48caa529e4b2e82a7da3d518f232e19/chrome/browser/android/physical_web/physical_web_data_source_android.cc [modify] https://crrev.com/8897fde5a48caa529e4b2e82a7da3d518f232e19/chrome/browser/android/physical_web/physical_web_data_source_android.h [modify] https://crrev.com/8897fde5a48caa529e4b2e82a7da3d518f232e19/components/omnibox/browser/physical_web_provider.cc [modify] https://crrev.com/8897fde5a48caa529e4b2e82a7da3d518f232e19/components/omnibox/browser/physical_web_provider_unittest.cc [modify] https://crrev.com/8897fde5a48caa529e4b2e82a7da3d518f232e19/components/physical_web/data_source/BUILD.gn [add] https://crrev.com/8897fde5a48caa529e4b2e82a7da3d518f232e19/components/physical_web/data_source/physical_web_data_source.cc [modify] https://crrev.com/8897fde5a48caa529e4b2e82a7da3d518f232e19/components/physical_web/data_source/physical_web_data_source.h [modify] https://crrev.com/8897fde5a48caa529e4b2e82a7da3d518f232e19/ios/chrome/common/physical_web/physical_web_scanner.mm
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5838df0e86f29312233ca3dc587bbcadab6b4b4b commit 5838df0e86f29312233ca3dc587bbcadab6b4b4b Author: mattreynolds <mattreynolds@chromium.org> Date: Thu Oct 27 23:11:01 2016 Notify native clients when Physical Web URL metadata is updated Native-layer clients can register for notifications when a Physical Web URL is found or lost, or when the distance estimate is updated. Notifications are only sent if the Physical Web feature is explicitly enabled. Native clients will only receive notifications for URLs that have been resolved through the Physical Web service. BUG= 636490 Review-Url: https://codereview.chromium.org/2449963005 Cr-Commit-Position: refs/heads/master@{#428192} [modify] https://crrev.com/5838df0e86f29312233ca3dc587bbcadab6b4b4b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java [modify] https://crrev.com/5838df0e86f29312233ca3dc587bbcadab6b4b4b/chrome/browser/android/physical_web/physical_web_data_source_android.cc [modify] https://crrev.com/5838df0e86f29312233ca3dc587bbcadab6b4b4b/chrome/browser/android/physical_web/physical_web_data_source_android.h
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f1aab392e8953a9ce8aa289a62ee157b59f629a5 commit f1aab392e8953a9ce8aa289a62ee157b59f629a5 Author: mattreynolds <mattreynolds@chromium.org> Date: Fri Oct 07 00:17:07 2016 Add an empty Android implementation of the PhysicalWebDataSource The Physical Web data source collects information about nearby devices broadcasting URLs and makes the list of URLs and associated metadata available to components within Chrome. This change adds an empty implementation of the data source in Chrome for Android and makes it available from a BrowserProcess. BUG= 636490 Review-Url: https://codereview.chromium.org/2361603002 Cr-Commit-Position: refs/heads/master@{#423754} [modify] https://crrev.com/f1aab392e8953a9ce8aa289a62ee157b59f629a5/chrome/browser/BUILD.gn [add] https://crrev.com/f1aab392e8953a9ce8aa289a62ee157b59f629a5/chrome/browser/android/physical_web/physical_web_data_source_android.cc [add] https://crrev.com/f1aab392e8953a9ce8aa289a62ee157b59f629a5/chrome/browser/android/physical_web/physical_web_data_source_android.h [modify] https://crrev.com/f1aab392e8953a9ce8aa289a62ee157b59f629a5/chrome/browser/browser_process.h [modify] https://crrev.com/f1aab392e8953a9ce8aa289a62ee157b59f629a5/chrome/browser/browser_process_impl.cc [modify] https://crrev.com/f1aab392e8953a9ce8aa289a62ee157b59f629a5/chrome/browser/browser_process_impl.h [modify] https://crrev.com/f1aab392e8953a9ce8aa289a62ee157b59f629a5/chrome/test/base/testing_browser_process.cc [modify] https://crrev.com/f1aab392e8953a9ce8aa289a62ee157b59f629a5/chrome/test/base/testing_browser_process.h
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840
,
Feb 14 2017
,
Mar 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d028bb17b6b7fd22c69e1a788a0e8c0dbc57ca30 commit d028bb17b6b7fd22c69e1a788a0e8c0dbc57ca30 Author: cco3 <cco3@chromium.org> Date: Tue Mar 14 22:23:47 2017 Remove unused PwCollection This class was created to help send results to UrlManager listeners, but the structure that is currently used lives in native. BUG= 636490 Review-Url: https://codereview.chromium.org/2738813002 Cr-Commit-Position: refs/heads/master@{#456864} [delete] https://crrev.com/bdf4447c2b53c291b12eed74bad3bc0aa3c63eff/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PwCollection.java [modify] https://crrev.com/d028bb17b6b7fd22c69e1a788a0e8c0dbc57ca30/chrome/android/java_sources.gni |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by vitaliii@chromium.org
, Aug 18 2016