change status bubble layout |
||||||
Issue descriptionOS: Windows 10 I recently removed the client edge on Windows 10, and now the status bubble border is overlapping the window frame at 1x dsf (see attached screenshot). We should clip out the left/bottom borders, but also need to make sure we don't mess up the descending status bubble when the mouse is too close to it. Also this revealed that the status bubble was not laying out properly at hidpi. At 1.5x the status bubble is now hanging out of the window frame to the left, which means it was probably overlapping the window frame before already.
,
Aug 30 2016
It's still possible that the status bubble hangs out of the window, but that's because it's screen-coordinate positioned like the omnibox popup which is covered by bug 620218. I addressed the other issues in this bug so I'm considering this fixed.
,
Aug 30 2016
,
Aug 31 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Aug 31 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8a691201c820fb62c5b9aef708cc263712559875 commit 8a691201c820fb62c5b9aef708cc263712559875 Author: Bret Sepulveda <bsep@chromium.org> Date: Wed Aug 31 21:38:25 2016 Change status bubble rendering at hidpi and when there is no client edge The recently removed client edge on Windows 10 made the status bubble overlap the window edge. This patch clips out the bubble border when the bubble is docked, and leaves it unchanged when it's floating. Also made the border always 1 pixel even at hidpi to make it look more consistent with the material UI. BUG= 636479 Review-Url: https://codereview.chromium.org/2247563002 Cr-Commit-Position: refs/heads/master@{#415216} (cherry picked from commit e5a8ba6722632879cfa09ef0e7f8d7f4a99c5d4e) Review URL: https://codereview.chromium.org/2302593003 . Cr-Commit-Position: refs/branch-heads/2840@{#81} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/8a691201c820fb62c5b9aef708cc263712559875/chrome/browser/ui/views/frame/browser_view.cc [modify] https://crrev.com/8a691201c820fb62c5b9aef708cc263712559875/chrome/browser/ui/views/frame/browser_view.h [modify] https://crrev.com/8a691201c820fb62c5b9aef708cc263712559875/chrome/browser/ui/views/frame/glass_browser_frame_view.cc [modify] https://crrev.com/8a691201c820fb62c5b9aef708cc263712559875/chrome/browser/ui/views/status_bubble_views.cc [modify] https://crrev.com/8a691201c820fb62c5b9aef708cc263712559875/chrome/browser/ui/views/status_bubble_views.h
,
Aug 31 2016
,
Sep 1 2016
bsep@ : Could you please let us know if it can be verified by TE if so please help with the steps to verify it.
,
Sep 1 2016
#7: Make sure the status bubble draws correctly on all platforms, especially at hidpi. On Windows 10 it's still drawing outside the window a little bit at hidpi, that's ok (see comment #2). I attached screenshots of what it should look like now at 1x and 2x on Windows 10.
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8a691201c820fb62c5b9aef708cc263712559875 commit 8a691201c820fb62c5b9aef708cc263712559875 Author: Bret Sepulveda <bsep@chromium.org> Date: Wed Aug 31 21:38:25 2016 Change status bubble rendering at hidpi and when there is no client edge The recently removed client edge on Windows 10 made the status bubble overlap the window edge. This patch clips out the bubble border when the bubble is docked, and leaves it unchanged when it's floating. Also made the border always 1 pixel even at hidpi to make it look more consistent with the material UI. BUG= 636479 Review-Url: https://codereview.chromium.org/2247563002 Cr-Commit-Position: refs/heads/master@{#415216} (cherry picked from commit e5a8ba6722632879cfa09ef0e7f8d7f4a99c5d4e) Review URL: https://codereview.chromium.org/2302593003 . Cr-Commit-Position: refs/branch-heads/2840@{#81} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/8a691201c820fb62c5b9aef708cc263712559875/chrome/browser/ui/views/frame/browser_view.cc [modify] https://crrev.com/8a691201c820fb62c5b9aef708cc263712559875/chrome/browser/ui/views/frame/browser_view.h [modify] https://crrev.com/8a691201c820fb62c5b9aef708cc263712559875/chrome/browser/ui/views/frame/glass_browser_frame_view.cc [modify] https://crrev.com/8a691201c820fb62c5b9aef708cc263712559875/chrome/browser/ui/views/status_bubble_views.cc [modify] https://crrev.com/8a691201c820fb62c5b9aef708cc263712559875/chrome/browser/ui/views/status_bubble_views.h |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Aug 30 2016