Issue 636478 link

Starred by 2 users

Issue metadata

Status:	Verified
Owner:	puthik@chromium.org
Closed:	Sep 2016
Cc:	r...@chromium.org kathrelk...@chromium.org
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	1
Type:	Bug
bluetooth M-53 Hotlist-Merge-Approved merge-merged-2785 VerifyIn-57 VerifyIn-58 VerifyIn-59

Android Bluetooth package does not support UUID 128 bit

Project Member Reported by puthik@chromium.org, Aug 10 2016

Issue description

In current ARC++ Bluetooth LE Advertise data implementation, Chrome send UUID 128 bits to Android because 
1) It has more information than 16 / 32 bits UUID 
2) Android framework support it[1].

However Android bluetooth package currently only support UUID 16 bits[2].

If left as is, Android will just ignore this data from Chrome.

[1] https://android.googlesource.com/platform/frameworks/base/+/android-n-preview-5/core/java/android/bluetooth/le/ScanRecord.java#216
[2] https://android.googlesource.com/platform/packages/apps/Bluetooth/+/android-n-preview-5/src/com/android/bluetooth/gatt/GattService.java#2221

Project Member

Comment 1 by bugdroid1@chromium.org, Aug 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/31fcf11302a5dc9670458fe666f86c086191089d

commit 31fcf11302a5dc9670458fe666f86c086191089d
Author: puthik <puthik@chromium.org>
Date: Wed Aug 17 01:44:22 2016

arc: bluetooth: Use UUID 16 bits in advertising data

For device advertising data received from low energy scan,
Android framework supports UUID 128 bits in services data
field. But, Android Bluetooth package supports only UUID
16 bits.

This patch makes Chrome send UUID 16 bits to Android
instead of UUID 128 bits.

BUG= 636478 
TEST=Build

Review-Url: https://codereview.chromium.org/2204263003
Cr-Commit-Position: refs/heads/master@{#412417}

[modify] https://crrev.com/31fcf11302a5dc9670458fe666f86c086191089d/components/arc/bluetooth/arc_bluetooth_bridge.cc
[modify] https://crrev.com/31fcf11302a5dc9670458fe666f86c086191089d/components/arc/bluetooth/arc_bluetooth_bridge_unittest.cc
[modify] https://crrev.com/31fcf11302a5dc9670458fe666f86c086191089d/components/arc/common/bluetooth.mojom

Comment 2 by puthik@chromium.org, Aug 22 2016

Labels: -Pri-2 -M-54 Merge-Request-53 M-53 Pri-1

I think we should merge this to M53 because this is bug fix for M53 feature.

Comment 3 by dimu@chromium.org, Aug 22 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved

Your change meets the bar and is auto-approved for M53 (branch: 2785)

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 23 2016

Labels: -merge-approved-53 merge-merged-2785

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ebc9fc73841ca084f348f79b5a41e263d712fab1

commit ebc9fc73841ca084f348f79b5a41e263d712fab1
Author: Rahul Chaturvedi <rkc@google.com>
Date: Tue Aug 23 02:05:25 2016

arc: bluetooth: Use UUID 16 bits in advertising data

For device advertising data received from low energy scan,
Android framework supports UUID 128 bits in services data
field. But, Android Bluetooth package supports only UUID
16 bits.

This patch makes Chrome send UUID 16 bits to Android
instead of UUID 128 bits.

BUG= 636478 
TEST=Build

Review-Url: https://codereview.chromium.org/2204263003
Cr-Commit-Position: refs/heads/master@{#412417}
(cherry picked from commit 31fcf11302a5dc9670458fe666f86c086191089d)

Review URL: https://codereview.chromium.org/2268113002 .

Cr-Commit-Position: refs/branch-heads/2785@{#722}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/ebc9fc73841ca084f348f79b5a41e263d712fab1/components/arc/bluetooth/arc_bluetooth_bridge.cc
[modify] https://crrev.com/ebc9fc73841ca084f348f79b5a41e263d712fab1/components/arc/common/bluetooth.mojom