New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 636475 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Better track paint related layout tests

Project Member Reported by schenney@chromium.org, Aug 10 2016

Issue description

Consolidate and update bugs for layout tests owned by the paint team. That includes the following LayoutTest directories:

* compositing subdirectories but not compositing itself or compositing/animations
* fast/images, css3/images,
* fast/repaint
* paint
* svg, fast/svg


 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e01bd4dbaa7ea4468e69dfa2447234cf0cecb223

commit e01bd4dbaa7ea4468e69dfa2447234cf0cecb223
Author: schenney <schenney@chromium.org>
Date: Wed Aug 10 19:54:48 2016

Reorganize test expectations to consolidate paint team tests

The aim is to consolidate tests owned by the paint team to make future change tracking easier. It is a goal of the team to track layout team regressions, additions and fixes.

This patch should have no net effect on test expectations. It is a line permutation only.

R=chrishtr@chromium.org
BUG= 636475 

Review-Url: https://codereview.chromium.org/2233053002
Cr-Commit-Position: refs/heads/master@{#411123}

[modify] https://crrev.com/e01bd4dbaa7ea4468e69dfa2447234cf0cecb223/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b90be20b69c308a9204656194dc31670fe2b80e7

commit b90be20b69c308a9204656194dc31670fe2b80e7
Author: schenney <schenney@chromium.org>
Date: Thu Aug 11 20:34:09 2016

Rebaseline some opacity tests because they are only off-by-one color

These were ref-tests, so deleting them, and marking for rebaseline
to get new results. The results look like the references but they are
off by one in the actual pixel values. Efforts to change the reference
failed because the opacity blending cannot be replaced because it
affects the text color and aliasing, yet we can't choose other colors
to get the right blended result.

R=danajk@chromium.org
BUG= 240374 , 636475 

Review-Url: https://codereview.chromium.org/2239043002
Cr-Commit-Position: refs/heads/master@{#411416}

[modify] https://crrev.com/b90be20b69c308a9204656194dc31670fe2b80e7/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/15f6656f1aaab53201af68f3b0f9e9699f8b4471/third_party/WebKit/LayoutTests/compositing/overlap-blending/children-opacity-huge-expected.html
[delete] https://crrev.com/15f6656f1aaab53201af68f3b0f9e9699f8b4471/third_party/WebKit/LayoutTests/compositing/overlap-blending/children-opacity-no-overlap-expected.html
[delete] https://crrev.com/15f6656f1aaab53201af68f3b0f9e9699f8b4471/third_party/WebKit/LayoutTests/compositing/overlap-blending/reflection-opacity-huge-expected.html

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e012026419587c9facab8b74a000592b81f82928

commit e012026419587c9facab8b74a000592b81f82928
Author: schenney <schenney@chromium.org>
Date: Thu Aug 11 21:57:28 2016

New bug ID for fast/repaint/block-layout-inline-children-replaced.html failure

TBR=wangxianzhu@chromium.org
BUG= 637069 , 636475 

Review-Url: https://codereview.chromium.org/2243633002
Cr-Commit-Position: refs/heads/master@{#411426}

[modify] https://crrev.com/e012026419587c9facab8b74a000592b81f82928/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af0799c558d7baf6de53392287ee3af78b90e2d4

commit af0799c558d7baf6de53392287ee3af78b90e2d4
Author: schenney <schenney@chromium.org>
Date: Tue Aug 16 20:02:01 2016

Fix multiple test result printing and rebaseline compositing/video/video-reflection.html

This test seems to be working fine, except for the fact
that it prints out the test result for every frame (it seems) and
the image is slightly different now. This patch modifies the test
to only act on the first seek callback, and set the image for
rebaselining.

R=ajuma@chromium.org,pdr@chromium.org
BUG= 324370 , 636475 

Review-Url: https://codereview.chromium.org/2238043002
Cr-Commit-Position: refs/heads/master@{#412313}

[modify] https://crrev.com/af0799c558d7baf6de53392287ee3af78b90e2d4/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/af0799c558d7baf6de53392287ee3af78b90e2d4/third_party/WebKit/LayoutTests/compositing/video/video-reflection.html

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ebd57ab640c504fac9139041188e61b3d92df20

commit 3ebd57ab640c504fac9139041188e61b3d92df20
Author: schenney <schenney@chromium.org>
Date: Wed Aug 17 16:26:45 2016

Fix reference result for compositing/transitions/transform-on-large-layer

Apply the same resizing method to the reference result as is used on the test.

R=ajuma@chromium.org
BUG= 245556 , 636475 

Review-Url: https://codereview.chromium.org/2232373003
Cr-Commit-Position: refs/heads/master@{#412553}

[modify] https://crrev.com/3ebd57ab640c504fac9139041188e61b3d92df20/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/3ebd57ab640c504fac9139041188e61b3d92df20/third_party/WebKit/LayoutTests/compositing/transitions/transform-on-large-layer-expected.html

Project Member

Comment 6 by bugdroid1@chromium.org, Aug 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f071ea2e4c896f7ff1dc1c81d70b7ec2f0e2d31

commit 3f071ea2e4c896f7ff1dc1c81d70b7ec2f0e2d31
Author: schenney <schenney@chromium.org>
Date: Wed Aug 17 16:46:53 2016

Remove expectations for compositing/overflow/reflected-overlay-scrollbars-should-appear-without-compositing.html

The test seems to be passing consistently.

TBR=vollick@chromium.org
BUG= 396775 , 636475 

Review-Url: https://codereview.chromium.org/2253893002
Cr-Commit-Position: refs/heads/master@{#412561}

[modify] https://crrev.com/3f071ea2e4c896f7ff1dc1c81d70b7ec2f0e2d31/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 7 by bugdroid1@chromium.org, Aug 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/69de2a35ac6db47eb5994b21dbbab8eecf8f3990

commit 69de2a35ac6db47eb5994b21dbbab8eecf8f3990
Author: schenney <schenney@chromium.org>
Date: Wed Aug 17 18:04:14 2016

Rebaseline svg/custom/foreign-object-skew.svg on Mac

The test result looks worse than it used to, but not bad
enough to fix. It's a super marginally situation, so not
too important.

There may still be failures on Mac Debug after this. The
test previously showed Release/Debug differences. The
expectation may need to be re-added with narrowed conditions.

R=fmalita@chromium.org
BUG= 390488 , 636475 

Review-Url: https://codereview.chromium.org/2254833002
Cr-Commit-Position: refs/heads/master@{#412583}

[modify] https://crrev.com/69de2a35ac6db47eb5994b21dbbab8eecf8f3990/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 8 by bugdroid1@chromium.org, Aug 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4cb58f53aa03848df49b6b311ed2122a56a9218

commit c4cb58f53aa03848df49b6b311ed2122a56a9218
Author: schenney <schenney@chromium.org>
Date: Wed Aug 17 20:58:36 2016

Rebaseline svg/custom/repaint-on-constant-size-change.svg

This test is an old one, which for some reason has been sitting
in test expectations in need of a rebaseline. The associated bug
is about avoiding invalidation, but that's a feature request, not
a test failure as such.

TBR=fs@opera.com
BUG=466200, 636475 

Review-Url: https://codereview.chromium.org/2259533002
Cr-Commit-Position: refs/heads/master@{#412633}

[modify] https://crrev.com/c4cb58f53aa03848df49b6b311ed2122a56a9218/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 9 by bugdroid1@chromium.org, Aug 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2cf52b9593f636bb706a9c90ccbab3236189e829

commit 2cf52b9593f636bb706a9c90ccbab3236189e829
Author: schenney <schenney@chromium.org>
Date: Wed Aug 17 21:13:29 2016

Rebaseline compositing/layer-creation/fixed-position-under-transform.html

The test doesn't seem to be failing, and even if it is, there's an
active bug tracking the FIXME related to the test.

TBR=trchen@chromium.org
BUG= 482229 , 636475 

Review-Url: https://codereview.chromium.org/2257493003
Cr-Commit-Position: refs/heads/master@{#412637}

[modify] https://crrev.com/2cf52b9593f636bb706a9c90ccbab3236189e829/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 10 by bugdroid1@chromium.org, Aug 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e7c705f5137839b87318d633aa7f66afb811ef42

commit e7c705f5137839b87318d633aa7f66afb811ef42
Author: schenney <schenney@chromium.org>
Date: Thu Aug 18 15:39:00 2016

Fix reference for svg/clip-path/clip-path-multiple-children.svg

The path data for the reference result was slightly different to that of the test, resulting in anti-aliasing differences. Matching up the paths exactly makes the reference match the test.

R=fs@opera.com
BUG= 425113 , 636475 

Review-Url: https://codereview.chromium.org/2246863006
Cr-Commit-Position: refs/heads/master@{#412839}

[modify] https://crrev.com/e7c705f5137839b87318d633aa7f66afb811ef42/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/e7c705f5137839b87318d633aa7f66afb811ef42/third_party/WebKit/LayoutTests/svg/clip-path/clip-path-multiple-children-expected.svg
[modify] https://crrev.com/e7c705f5137839b87318d633aa7f66afb811ef42/third_party/WebKit/LayoutTests/svg/clip-path/clip-path-multiple-children.svg

Project Member

Comment 11 by bugdroid1@chromium.org, Aug 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d77b7ed373f94503a9a0429687ecf48a3ebbb88

commit 1d77b7ed373f94503a9a0429687ecf48a3ebbb88
Author: schenney <schenney@chromium.org>
Date: Thu Aug 18 17:32:53 2016

Add more specificity to expectation for compositing/video/video-controls-layer-creation.html

This test only fails on Win7 Debug, and it will be moved shortly to
the WontFix test expectations.

TBR=wkorman@chromium.org
BUG=487344, 636475 

Review-Url: https://codereview.chromium.org/2256833002
Cr-Commit-Position: refs/heads/master@{#412874}

[modify] https://crrev.com/1d77b7ed373f94503a9a0429687ecf48a3ebbb88/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 12 by bugdroid1@chromium.org, Aug 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/246cf98c2d65b307d0219893f80b0f47e3146d30

commit 246cf98c2d65b307d0219893f80b0f47e3146d30
Author: schenney <schenney@chromium.org>
Date: Thu Aug 18 17:42:06 2016

Attempt to rebaseline remaining  crbug.com/463358  tests

There are 2 tests remaining marked for  crbug.com/463358 . They
both look like they need rebaselines, and maybe they are now fixed
and stable. There is still some chance that the Linux Debug
result for fast/transforms/transformed-caret.html is broken or
flakey, and will need to be re-added after the rebaseline.

No test should really be marked under this bug. It relates to
a clang roll that was itself reverted, so the cause of the failures
no longer exists.

TBR=fmalita@chromium.org
BUG= 463358 , 636475 

Review-Url: https://codereview.chromium.org/2252163002
Cr-Commit-Position: refs/heads/master@{#412881}

[modify] https://crrev.com/246cf98c2d65b307d0219893f80b0f47e3146d30/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 13 by bugdroid1@chromium.org, Aug 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4938a49b09d88101f63bba6da25a069a55b0a7a

commit e4938a49b09d88101f63bba6da25a069a55b0a7a
Author: schenney <schenney@chromium.org>
Date: Thu Aug 18 19:14:16 2016

Rebaseline svg/wicd/test-rightsizing-b.xhtml

It's probably still flakey, but we should get new baselines that
are right at least some of the time. Right now they are always
failing.

TBR=szager@chromium.org
BUG= 495523 , 636475 

Review-Url: https://codereview.chromium.org/2259913002
Cr-Commit-Position: refs/heads/master@{#412906}

[modify] https://crrev.com/e4938a49b09d88101f63bba6da25a069a55b0a7a/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 14 by bugdroid1@chromium.org, Aug 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa3ce0cd1ae8063be1ec2f6f2444bedce3534aa5

commit aa3ce0cd1ae8063be1ec2f6f2444bedce3534aa5
Author: schenney <schenney@chromium.org>
Date: Thu Aug 18 19:41:26 2016

Rebaseline some CSS align and justify repaint tests

The test pixel results are wrong, but that's no reason to keep
expectations. We rebaseline for the current result and use the bug
to track the fact that we get it wrong. The bug exists in this case
and has been updated with the info about these tests.

TBR=wangxianzhu@chromium.org
BUG= 477798 , 636475 

Review-Url: https://codereview.chromium.org/2254953002
Cr-Commit-Position: refs/heads/master@{#412915}

[modify] https://crrev.com/aa3ce0cd1ae8063be1ec2f6f2444bedce3534aa5/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 15 by bugdroid1@chromium.org, Aug 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1cfa4f01c043a0da4dfff5594bb80b6a63d6e9fb

commit 1cfa4f01c043a0da4dfff5594bb80b6a63d6e9fb
Author: schenney <schenney@chromium.org>
Date: Thu Aug 18 21:58:31 2016

Rebaseline virtual/prefer_compositing_to_lcd_text/compositing/overflow/theme-affects-visual-overflow.html

It seems like the failure is just a sub-pixel size difference,
probably due to forms or text. So try rebaselining.

TBR=wangxianzhu@chromium.org
BUG= 509025 , 636475 

Review-Url: https://codereview.chromium.org/2250793005
Cr-Commit-Position: refs/heads/master@{#412947}

[modify] https://crrev.com/1cfa4f01c043a0da4dfff5594bb80b6a63d6e9fb/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 16 by bugdroid1@chromium.org, Aug 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bafc7776c5ea52ce35aa665e5621f0767c2dfdae

commit bafc7776c5ea52ce35aa665e5621f0767c2dfdae
Author: schenney <schenney@chromium.org>
Date: Fri Aug 19 20:38:14 2016

Remove expectation for fast/images/style-access-during-imageChanged-crash.html

There is no evidence of problems in the flakiness dashboard.

TBR=fmalita@chromium.org
BUG= 520177 , 636475 

Review-Url: https://codereview.chromium.org/2260203002
Cr-Commit-Position: refs/heads/master@{#413230}

[modify] https://crrev.com/bafc7776c5ea52ce35aa665e5621f0767c2dfdae/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 17 by bugdroid1@chromium.org, Aug 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48f9e6460df089ac65e7b51760dcda060a7a53c5

commit 48f9e6460df089ac65e7b51760dcda060a7a53c5
Author: schenney <schenney@chromium.org>
Date: Fri Aug 19 21:35:57 2016

Rebaseline compositing/overflow/do-not-repaint-if-scrolling-composited-layers.html

The test is always failing, not flakey, which means we can't tell
if it is still flakey, or failing always, or right always. So
get new baselines to see what happens from here. At least we'll
be green sometimes and know what the most likely result is.

There is a high probability that this test expectations will be
re-added once the rebaseline happens.

TBR=flackr@chromium.org,vollick@chromium.org
BUG= 520166 , 636475 

Review-Url: https://codereview.chromium.org/2258643003
Cr-Commit-Position: refs/heads/master@{#413246}

[modify] https://crrev.com/48f9e6460df089ac65e7b51760dcda060a7a53c5/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/48f9e6460df089ac65e7b51760dcda060a7a53c5/third_party/WebKit/LayoutTests/compositing/overflow/do-not-repaint-if-scrolling-composited-layers-expected.txt
[add] https://crrev.com/48f9e6460df089ac65e7b51760dcda060a7a53c5/third_party/WebKit/LayoutTests/platform/android/compositing/overflow/do-not-repaint-if-scrolling-composited-layers-expected.txt
[add] https://crrev.com/48f9e6460df089ac65e7b51760dcda060a7a53c5/third_party/WebKit/LayoutTests/platform/linux-precise/compositing/overflow/do-not-repaint-if-scrolling-composited-layers-expected.txt
[add] https://crrev.com/48f9e6460df089ac65e7b51760dcda060a7a53c5/third_party/WebKit/LayoutTests/platform/linux/compositing/overflow/do-not-repaint-if-scrolling-composited-layers-expected.txt
[add] https://crrev.com/48f9e6460df089ac65e7b51760dcda060a7a53c5/third_party/WebKit/LayoutTests/platform/mac-mac10.10/compositing/overflow/do-not-repaint-if-scrolling-composited-layers-expected.txt
[add] https://crrev.com/48f9e6460df089ac65e7b51760dcda060a7a53c5/third_party/WebKit/LayoutTests/platform/mac-mac10.9/compositing/overflow/do-not-repaint-if-scrolling-composited-layers-expected.txt
[add] https://crrev.com/48f9e6460df089ac65e7b51760dcda060a7a53c5/third_party/WebKit/LayoutTests/platform/mac-retina/compositing/overflow/do-not-repaint-if-scrolling-composited-layers-expected.txt
[add] https://crrev.com/48f9e6460df089ac65e7b51760dcda060a7a53c5/third_party/WebKit/LayoutTests/platform/mac/compositing/overflow/do-not-repaint-if-scrolling-composited-layers-expected.txt
[add] https://crrev.com/48f9e6460df089ac65e7b51760dcda060a7a53c5/third_party/WebKit/LayoutTests/platform/win/compositing/overflow/do-not-repaint-if-scrolling-composited-layers-expected.txt
[add] https://crrev.com/48f9e6460df089ac65e7b51760dcda060a7a53c5/third_party/WebKit/LayoutTests/platform/win7/compositing/overflow/do-not-repaint-if-scrolling-composited-layers-expected.txt

Project Member

Comment 18 by bugdroid1@chromium.org, Aug 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/72dd6d0104aa49707f549ff8e60973443b45f5dc

commit 72dd6d0104aa49707f549ff8e60973443b45f5dc
Author: schenney <schenney@chromium.org>
Date: Mon Aug 22 15:58:12 2016

Triage of new Layout Test failures for Paint Team

This patch just moves some expectations around to enable
efficient triage.

TBR=chrishtr@chromium.org
BUG= 636475 

Review-Url: https://codereview.chromium.org/2263223002
Cr-Commit-Position: refs/heads/master@{#413448}

[modify] https://crrev.com/72dd6d0104aa49707f549ff8e60973443b45f5dc/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 19 by bugdroid1@chromium.org, Aug 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6db8bbbef377fad31022f1e09b44f3566683d957

commit 6db8bbbef377fad31022f1e09b44f3566683d957
Author: schenney <schenney@chromium.org>
Date: Mon Aug 22 16:00:53 2016

Rebaseline fast/borders/border-antialiasing.html

The new result is wrong, more wrong than the old result, but
having it as a failure in test expectations means we do not
catch any regressions. We did not, for instance, catch the
regression that made the test result worse.

TBR=fmalita@chromium.org
BUG= 502531 , 636475 

Review-Url: https://codereview.chromium.org/2260193002
Cr-Commit-Position: refs/heads/master@{#413449}

[modify] https://crrev.com/6db8bbbef377fad31022f1e09b44f3566683d957/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/6db8bbbef377fad31022f1e09b44f3566683d957/third_party/WebKit/LayoutTests/platform/android/fast/borders/border-antialiasing-expected.png
[add] https://crrev.com/6db8bbbef377fad31022f1e09b44f3566683d957/third_party/WebKit/LayoutTests/platform/linux-precise/fast/borders/border-antialiasing-expected.png
[modify] https://crrev.com/6db8bbbef377fad31022f1e09b44f3566683d957/third_party/WebKit/LayoutTests/platform/linux/fast/borders/border-antialiasing-expected.png
[add] https://crrev.com/6db8bbbef377fad31022f1e09b44f3566683d957/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/borders/border-antialiasing-expected.png
[add] https://crrev.com/6db8bbbef377fad31022f1e09b44f3566683d957/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/borders/border-antialiasing-expected.png
[add] https://crrev.com/6db8bbbef377fad31022f1e09b44f3566683d957/third_party/WebKit/LayoutTests/platform/mac-retina/fast/borders/border-antialiasing-expected.png
[modify] https://crrev.com/6db8bbbef377fad31022f1e09b44f3566683d957/third_party/WebKit/LayoutTests/platform/mac/fast/borders/border-antialiasing-expected.png
[modify] https://crrev.com/6db8bbbef377fad31022f1e09b44f3566683d957/third_party/WebKit/LayoutTests/platform/win/fast/borders/border-antialiasing-expected.png
[add] https://crrev.com/6db8bbbef377fad31022f1e09b44f3566683d957/third_party/WebKit/LayoutTests/platform/win7/fast/borders/border-antialiasing-expected.png

Project Member

Comment 21 by bugdroid1@chromium.org, Aug 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/079b912c02a8838fbf2f246c3215d359d50df7a5

commit 079b912c02a8838fbf2f246c3215d359d50df7a5
Author: schenney <schenney@chromium.org>
Date: Tue Aug 30 21:00:16 2016

Clean up paint expectations.

No change, just re-ordering.

TBR=chrishtr@chromium.org
BUG= 636475 

Review-Url: https://codereview.chromium.org/2286393002
Cr-Commit-Position: refs/heads/master@{#415422}

[modify] https://crrev.com/079b912c02a8838fbf2f246c3215d359d50df7a5/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 22 by bugdroid1@chromium.org, Aug 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/871b7cf9462dcc5e522883a7b937156b2bd11313

commit 871b7cf9462dcc5e522883a7b937156b2bd11313
Author: yhirano <yhirano@chromium.org>
Date: Wed Aug 31 02:18:20 2016

Revert of Clean up paint expectations. (patchset #2 id:20001 of https://codereview.chromium.org/2286393002/ )

Reason for revert:
In spite of the CL description this CL changes the expectation.

Original issue's description:
> Clean up paint expectations.
>
> No change, just re-ordering.
>
> TBR=chrishtr@chromium.org
> BUG= 636475 
>
> Committed: https://crrev.com/079b912c02a8838fbf2f246c3215d359d50df7a5
> Cr-Commit-Position: refs/heads/master@{#415422}

TBR=chrishtr@chromium.org,schenney@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 636475 

Review-Url: https://codereview.chromium.org/2299503002
Cr-Commit-Position: refs/heads/master@{#415540}

[modify] https://crrev.com/871b7cf9462dcc5e522883a7b937156b2bd11313/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 23 by bugdroid1@chromium.org, Aug 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1572949bc29d9a34df2f114e24cd41db13a41026

commit 1572949bc29d9a34df2f114e24cd41db13a41026
Author: schenney <schenney@chromium.org>
Date: Wed Aug 31 16:48:00 2016

Clean up paint expectations.

No change, just re-ordering. Really this time.

TBR=chrishtr@chromium.org
BUG= 636475 

Review-Url: https://codereview.chromium.org/2295213002
Cr-Commit-Position: refs/heads/master@{#415658}

[modify] https://crrev.com/1572949bc29d9a34df2f114e24cd41db13a41026/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 24 by bugdroid1@chromium.org, Sep 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3052cfc04816a43a8b1b09d6e97642f1ed83cbfd

commit 3052cfc04816a43a8b1b09d6e97642f1ed83cbfd
Author: schenney <schenney@chromium.org>
Date: Mon Sep 12 20:49:35 2016

Clean-up of paint team TestExpectations

Add in hittesting. Update list of directories we own. Move expectations we
own into the paint team block.

TBR=chrishtr@chromium.org
BUG= 636475 

Review-Url: https://codereview.chromium.org/2334543004
Cr-Commit-Position: refs/heads/master@{#418036}

[modify] https://crrev.com/3052cfc04816a43a8b1b09d6e97642f1ed83cbfd/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 25 by bugdroid1@chromium.org, Oct 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/156818dfa17ead69e89b319b520f4c202cd72b89

commit 156818dfa17ead69e89b319b520f4c202cd72b89
Author: schenney <schenney@chromium.org>
Date: Tue Oct 11 21:48:11 2016

Move paint team test expectations into paint team block

TBR=chrishtr
BUG= 636475 

Review-Url: https://codereview.chromium.org/2405373002
Cr-Commit-Position: refs/heads/master@{#424560}

[modify] https://crrev.com/156818dfa17ead69e89b319b520f4c202cd72b89/third_party/WebKit/LayoutTests/TestExpectations

Status: Fixed (was: Assigned)
Closing as the work to get our expectations cleaned up has been completed.

Sign in to add a comment