New issue
Advanced search Search tips

Issue 636463 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 630691



Sign in to add a comment

27 tests crash with Check failed: m_isFirstEffectEver || currentEffectNode()

Project Member Reported by pdr@chromium.org, Aug 10 2016

Issue description

When running tests with --additional-drt-flag=--enable-slimming-paint-v2 --additional-drt-flag=--enable-layer-lists, 27 tests crash with the following assert:
Check failed: m_isFirstEffectEver || currentEffectNode(). Malformed effect tree. Nodes in the same property tree should have common root.
blink::(anonymous namespace)::PropertyTreeManager::switchToEffectNode()
blink::PaintArtifactCompositor::updateInLayerListMode()
blink::PaintArtifactCompositor::update()
blink::ChromeClientImpl::didPaint()
blink::FrameView::pushPaintArtifactToCompositor()
blink::FrameView::updateLifecyclePhasesInternal()

List of tests:
fast/text/whitespace/whitespace-and-margin-wrap-after-list-marker-crash.html
fast/text/international/bidi-neutral-in-mixed-direction-run-crash.html
fast/events/wheelevent-in-vertical-scrollbar-in-rtl.html
fast/events/wheelevent-in-horizontal-scrollbar-in-rtl.html
fast/pagination/viewport-x-vertical-rl-rtl.html
fast/pagination/viewport-x-vertical-rl-ltr.html
fast/pagination/viewport-y-vertical-lr-rtl.html
fast/pagination/viewport-x-horizontal-tb-rtl.html
fast/pagination/viewport-y-vertical-rl-rtl.html
fast/repaint/window-resize-vertical-writing-mode.html
fast/writing-mode/Kusa-Makura-background-canvas.html
fast/dom/vertical-scrollbar-in-rtl.html
fast/dom/scroll-reveal-top-overflow.html
fast/dom/scroll-reveal-left-overflow.html
fast/dom/horizontal-scrollbar-in-rtl-doesnt-fire-onscroll.html
fast/dom/rtl-scroll-to-leftmost-and-resize.html
fast/dom/horizontal-scrollbar-in-rtl.html
fast/scroll-behavior/smooth-scroll/ongoing-smooth-scroll-vertical-rl-anchors.html
fast/block/positioning/rtl-fixed-positioning.html
fast/block/positioning/auto/vertical-rl/007.html
fast/block/positioning/vertical-rl/fixed-positioning.html
fast/block/basic/truncation-rtl.html
compositing/rtl/rtl-absolute-overflow.html
compositing/rtl/rtl-fixed-overflow-scrolled.html
compositing/rtl/rtl-absolute-overflow-scrolled.html
compositing/rtl/rtl-overflow-invalidation.html
compositing/rtl/rtl-fixed-overflow.html
 

Comment 1 by pdr@chromium.org, Sep 14 2016

Cc: chrishtr@chromium.org
The reason these crash is we are painting without setting up the property tree state first. These are almost all rtl cases because rtl causes a non-identity transform to be created in CompositedLayerMapping::doPaintTask due to an offset. When we create that transform display item, we haven't yet created a paint property scope, so we use nullptr for all the properties and then crash.

Chrishtr is getting close to solving this in https://codereview.chromium.org/2322073006/
Owner: chrishtr@chromium.org
Status: Assigned (was: Available)
Status: Fixed (was: Assigned)

Comment 4 by pdr@chromium.org, Sep 22 2016

These tests are still listed in FlagExpecatations/enable-slimming-paint-v2 as crashing. Can you remove them?
Status: Assigned (was: Fixed)
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 23 2016

Comment 7 by pdr@chromium.org, Sep 23 2016

Status: Fixed (was: Assigned)
Thanks!

Sign in to add a comment