Make all code-review labels sticky for ANGLE |
||||||
Issue descriptionCurrently ANGLE's gerrit preserves code-review -2 and code-review +2, but ideally we could preserve all code-review labels given by valid reviewers. vadimsh can you help with this? You helped us in a prior request.
,
Aug 10 2016
Any at Google who maintains Gerrit? I'm wary of leaving this bug without an owner, I have a feeling it'll sit in vacant space until the end of time.
,
Aug 10 2016
Infra>Git>Admin is a bug queue that is actively triaged (we have a weekly bug triage rotations and stuff). I have faith in the system :)
,
Aug 11 2016
Hmm well *I* have no idea. If this isn't supported at the moment it sounds like it should be a feature request in https://bugs.chromium.org/p/gerrit/issues/list?
,
Aug 11 2016
This is indeed possible. An example configuration:
[label "Code-Review"]
abbreviation = R
value = -1 Don't submit as-is
value = 0 No score
value = +1 Looks good to me
defaultValue = 0
function = MaxWithBlock
copyMinScore = true
copyMaxScore = true
copyAllScoresOnTrivialRebase = true
copyAllScoresIfNoCodeChange = true
Barring the min/max labels, this should let LGTM be “sticky”.
,
Aug 11 2016
This would mean there is no Code-Review +2 though, I think. We would like to keep +1 and +2, but make the +1s sticky.
,
Aug 11 2016
,
Aug 11 2016
You don’t have to change the range of review values. It will still remain sticky. Keep in mind there is a bug with sticky LGTMs that is being fixed: https://bugs.chromium.org/p/gerrit/issues/detail?id=4373
,
Aug 11 2016
Oh, cool. How can we get the config then that you listed above? Then after the gerrit bug is fixed we'll be good to go?
,
Aug 16 2016
Hm... It looks like the configuration is already set up that way (from https://chromium.googlesource.com/angle/+/refs/meta/config/project.config): [label "Code-Review"] function = MaxWithBlock abbreviation = R copyMinScore = true copyMaxScore = true copyAllScoresOnTrivialRebase = true copyAllScoresIfNoCodeChange = true value = -2 Do not submit value = -1 I would prefer that you didn't submit this value = 0 No score value = +1 Looks good to me, but someone else must approve value = +2 Looks good to me, approved defaultValue = 0 Is this still an issue for folks, or did the bug mentioned in #8 actually fix this?
,
Aug 16 2016
Second ping :). If there's no response for another day I'll close.
,
Aug 17 2016
Did the Gerrit change land? I'd like to test it, but unsure if it's on the deployed Gerrit site for ANGLE.
,
Aug 19 2016
Ah... I saw that it was committed. I'll check to make sure that it's deployed
,
Aug 19 2016
Yes, this is deployed for angle: https://chromium.googlesource.com/angle/angle
,
Aug 22 2016
Can angle confirm whether their code-review labels are sticky now or not?
,
Aug 24 2016
I can confirm this does not work as intended currently, Code-Review +1 labels are dropped. Smut, can you close this as WontFix if there is no possible resolution? See: https://chromium-review.googlesource.com/#/c/374338/
,
Aug 24 2016
I posted on https://bugs.chromium.org/p/gerrit/issues/detail?id=4373 that their fix doesn't seem to have worked.
,
Aug 26 2016
They tell me it's working as intended not to copy Code-Review+1. They only copy +2 because +1 means someone else must approve anyways. +1 only sticks across rebases and commit message changes.
,
Aug 27 2016
Thanks. If I wanted to file a feature request for our use case, do you know which issue tracker or labels to use?
,
Aug 29 2016
I think you could use https://bugs.chromium.org/p/gerrit/issues/entry?template=Feature%20Request. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by vadimsh@chromium.org
, Aug 10 2016Components: -Infra>Git Infra>Git>Admin
Owner: ----