Issue metadata
Sign in to add a comment
|
Don't use the input event hang monitor timer for beforeunload and close |
||||||||||||||||||||||||
Issue descriptionWe currently use RenderWidgetHostImpl::StartHangMonitorTimeout for several types of unresponsiveness timers: input events (30 seconds), beforeunload (1 second), and close (1 second). There's a complex set of state checks to decide how to react when the timer expires and how it's set, involving IsWaitingForUnloadACK() and is_waiting_for_beforeunload_ack(). This approach is fragile and risks showing the hung renderer dialog after only 1 second if any state is incorrect. It was also the source of several bugs when originally getting the timer code to work for cross-process beforeunload/unload handlers. We should switch to using separate timers for beforeunload and close, the way we've done for swapout_event_monitor_timeout_ on RenderFrameHostImpl.
,
Sep 2 2016
Can we also put the timeout duration in the crash report? Maybe that can even be done as an intermediate step before using different hangout monitors?
,
Sep 2 2016
Comment 2: I think you might be commenting on the wrong bug report. Did you mean to post to issue 615090? (This one isn't about crash reports for hangs.)
,
Apr 6 2017
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by mfo...@chromium.org
, Aug 31 2016