New issue
Advanced search Search tips

Issue 636437 link

Starred by 1 user
Status: Fixed
Owner:
flackr@chromium.org
Closed: Aug 2016
Cc:
chrishtr@chromium.org
vmp...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Background change does not update composited local attachment background

Project Member Reported by flackr@chromium.org, Aug 10 2016 
Changing the background on an element with a composited local attachment background does not repaint the background - see attached test case. This was broken by https://chromium.googlesource.com/chromium/src/+/9a2cdc8d96d94c736eb5547a7c8c541e58e5759f which introduced painting locally attached backgrounds onto the scrolling contents layer.

I have a fix in progress.
overflow-scroll-with-local-background-invalidation.html
830 bytes View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c01760bc132fcc6a8d96b1d567bad36a6614677f

commit c01760bc132fcc6a8d96b1d567bad36a6614677f
Author: flackr <flackr@chromium.org>
Date: Thu Aug 11 23:36:33 2016

Invalidate scrolling contents layer on background invalidations painted into it.

When we paint backgrounds into the scrolling contents layer we need to invalidate
appropriately when those backgrounds change.

BUG= 636437 
TEST=compositing/overflow/overflow-scroll-with-local-background-invalidation.html
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2235873002
Cr-Commit-Position: refs/heads/master@{#411441}

[add] https://crrev.com/c01760bc132fcc6a8d96b1d567bad36a6614677f/third_party/WebKit/LayoutTests/paint/invalidation/composited-overflow-with-local-background-expected.txt
[add] https://crrev.com/c01760bc132fcc6a8d96b1d567bad36a6614677f/third_party/WebKit/LayoutTests/paint/invalidation/composited-overflow-with-local-background.html
[modify] https://crrev.com/c01760bc132fcc6a8d96b1d567bad36a6614677f/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp
[modify] https://crrev.com/c01760bc132fcc6a8d96b1d567bad36a6614677f/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.h

Comment 2 by flackr@chromium.org, Aug 12 2016

Status: Fixed (was: Started)
►

Sign in to add a comment