Clicking on the scrollbar while there is a hyperlink underneath it also highlights the hyperlink |
||||||||
Issue description(1) Enable chrome://flags/#overlay-scrollbars (2) Go to nytimes.com and zoom in and scroll down until there is a hyperlink underneath (3) Clicking on the scrollbar while there is a hyperlink underneath it also highlights the hyperlink and should only select the scrollbar
,
Aug 25 2016
,
Sep 22 2016
,
Sep 28 2016
,
Nov 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/524f6ac4628d3d5249d291314c6100bd0a337053 commit 524f6ac4628d3d5249d291314c6100bd0a337053 Author: chaopeng <chaopeng@chromium.org> Date: Sat Nov 05 03:26:22 2016 Fix link's hover state if the link under scrollbar In this patch, we check the hitTest includes scrollbar in ChromeClientImpl::showMouseOverURL, ChromeClient::mouseDidMoveOverElement, Document::updateHoverActiveState, EventHandler::selectAutoCursor to prevent showing url, tooltip and hand cursor when mouse move on the link under scrollbar or showing active state when mouse click on the link under scrollbar. BUG= 636436 Review-Url: https://codereview.chromium.org/2389073002 Cr-Commit-Position: refs/heads/master@{#430141} [modify] https://crrev.com/524f6ac4628d3d5249d291314c6100bd0a337053/third_party/WebKit/Source/core/dom/Document.cpp [modify] https://crrev.com/524f6ac4628d3d5249d291314c6100bd0a337053/third_party/WebKit/Source/core/dom/Document.h [modify] https://crrev.com/524f6ac4628d3d5249d291314c6100bd0a337053/third_party/WebKit/Source/core/input/EventHandler.cpp [modify] https://crrev.com/524f6ac4628d3d5249d291314c6100bd0a337053/third_party/WebKit/Source/core/page/ChromeClient.cpp [modify] https://crrev.com/524f6ac4628d3d5249d291314c6100bd0a337053/third_party/WebKit/Source/web/ChromeClientImpl.cpp [modify] https://crrev.com/524f6ac4628d3d5249d291314c6100bd0a337053/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
,
Nov 7 2016
,
Nov 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/898ff2df4c04bee36bce24d6945511af39ee79e4 commit 898ff2df4c04bee36bce24d6945511af39ee79e4 Author: bokan <bokan@chromium.org> Date: Tue Nov 08 21:28:47 2016 Revert of Fix link's hover state if the link under scrollbar (patchset #10 id:180001 of https://codereview.chromium.org/2389073002/ ) Reason for revert: Due to crbug.com/662402, need to revert crrev.com/2467693002 which this depends on. I'll reland when the dust settles. Original issue's description: > Fix link's hover state if the link under scrollbar > > In this patch, we check the hitTest includes scrollbar in > ChromeClientImpl::showMouseOverURL, ChromeClient::mouseDidMoveOverElement, > Document::updateHoverActiveState, EventHandler::selectAutoCursor to prevent > showing url, tooltip and hand cursor when mouse move on the link under scrollbar > or showing active state when mouse click on the link under scrollbar. > > BUG= 636436 > > Committed: https://crrev.com/524f6ac4628d3d5249d291314c6100bd0a337053 > Cr-Commit-Position: refs/heads/master@{#430141} TBR=chaopeng@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 636436 Review-Url: https://codereview.chromium.org/2485203002 Cr-Commit-Position: refs/heads/master@{#430717} [modify] https://crrev.com/898ff2df4c04bee36bce24d6945511af39ee79e4/third_party/WebKit/Source/core/dom/Document.cpp [modify] https://crrev.com/898ff2df4c04bee36bce24d6945511af39ee79e4/third_party/WebKit/Source/core/dom/Document.h [modify] https://crrev.com/898ff2df4c04bee36bce24d6945511af39ee79e4/third_party/WebKit/Source/core/input/EventHandler.cpp [modify] https://crrev.com/898ff2df4c04bee36bce24d6945511af39ee79e4/third_party/WebKit/Source/core/page/ChromeClient.cpp [modify] https://crrev.com/898ff2df4c04bee36bce24d6945511af39ee79e4/third_party/WebKit/Source/web/ChromeClientImpl.cpp [modify] https://crrev.com/898ff2df4c04bee36bce24d6945511af39ee79e4/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
,
Nov 11 2016
Changing status back to Assigned as fix is reverted.
,
Nov 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/55444d25b3aec61cbcf053448b3bb999b4bf859b commit 55444d25b3aec61cbcf053448b3bb999b4bf859b Author: bokan <bokan@chromium.org> Date: Sat Nov 12 00:27:34 2016 Reland of Fix link's hover state if the link under scrollbar (patchset #1 id:1 of https://codereview.chromium.org/2485203002/ ) Reason for revert: Relanding now that crrev.com/2467693002 has been relanded. Original issue's description: > Revert of Fix link's hover state if the link under scrollbar (patchset #10 id:180001 of https://codereview.chromium.org/2389073002/ ) > > Reason for revert: > Due to crbug.com/662402, need to revert crrev.com/2467693002 which this depends on. I'll reland when the dust settles. > > Original issue's description: > > Fix link's hover state if the link under scrollbar > > > > In this patch, we check the hitTest includes scrollbar in > > ChromeClientImpl::showMouseOverURL, ChromeClient::mouseDidMoveOverElement, > > Document::updateHoverActiveState, EventHandler::selectAutoCursor to prevent > > showing url, tooltip and hand cursor when mouse move on the link under scrollbar > > or showing active state when mouse click on the link under scrollbar. > > > > BUG= 636436 > > > > Committed: https://crrev.com/524f6ac4628d3d5249d291314c6100bd0a337053 > > Cr-Commit-Position: refs/heads/master@{#430141} > > TBR=chaopeng@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG= 636436 > > Committed: https://crrev.com/898ff2df4c04bee36bce24d6945511af39ee79e4 > Cr-Commit-Position: refs/heads/master@{#430717} TBR=chaopeng@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 636436 Review-Url: https://codereview.chromium.org/2491953004 Cr-Commit-Position: refs/heads/master@{#431702} [modify] https://crrev.com/55444d25b3aec61cbcf053448b3bb999b4bf859b/third_party/WebKit/Source/core/dom/Document.cpp [modify] https://crrev.com/55444d25b3aec61cbcf053448b3bb999b4bf859b/third_party/WebKit/Source/core/dom/Document.h [modify] https://crrev.com/55444d25b3aec61cbcf053448b3bb999b4bf859b/third_party/WebKit/Source/core/input/EventHandler.cpp [modify] https://crrev.com/55444d25b3aec61cbcf053448b3bb999b4bf859b/third_party/WebKit/Source/core/page/ChromeClient.cpp [modify] https://crrev.com/55444d25b3aec61cbcf053448b3bb999b4bf859b/third_party/WebKit/Source/web/ChromeClientImpl.cpp [modify] https://crrev.com/55444d25b3aec61cbcf053448b3bb999b4bf859b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
,
Nov 17 2016
,
Nov 28 2016
Verified on ChromeOS 9000.8.0, 56.0.2924.7 |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by sheriffbot@chromium.org
, Aug 11 2016