New issue
Advanced search Search tips

Issue 636435 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Feature

Blocked on:
issue 636408



Sign in to add a comment

Add origin of settings reset request to feedback reports

Project Member Reported by alito@chromium.org, Aug 10 2016

Issue description

When the settings reset dialog is shown, add the source of the reset request to the feedback reports.
 

Comment 1 by alito@chromium.org, Aug 10 2016

Cc: battre@chromium.org

Comment 2 by dbeam@chromium.org, Aug 18 2016

md-settings is trying to ship soon.  it seems like most of the code you're adding would be deleted in that case.  can we just add the /settings/ code and ignore /options/ if we're hoping to ship md-settings Real Soon Now?

Comment 3 by alito@google.com, Aug 18 2016

So when md-settings ship, is the plan to also delete the old options code at the same time or is the plan to keep it around for some time? Will users be able to switch back to the old settings page during some transition period?
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6e2ff7f9e7249663424e01a3d5aa31c9a8f9ee4

commit a6e2ff7f9e7249663424e01a3d5aa31c9a8f9ee4
Author: alito <alito@chromium.org>
Date: Fri Oct 14 15:51:50 2016

md-settings: add reset request origin to reset feedback proto.

BUG= 636435 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2411383003
Cr-Commit-Position: refs/heads/master@{#425337}

[modify] https://crrev.com/a6e2ff7f9e7249663424e01a3d5aa31c9a8f9ee4/chrome/browser/resources/settings/reset_page/reset_browser_proxy.js
[modify] https://crrev.com/a6e2ff7f9e7249663424e01a3d5aa31c9a8f9ee4/chrome/browser/resources/settings/reset_page/reset_page.js
[modify] https://crrev.com/a6e2ff7f9e7249663424e01a3d5aa31c9a8f9ee4/chrome/browser/resources/settings/reset_page/reset_profile_dialog.js
[modify] https://crrev.com/a6e2ff7f9e7249663424e01a3d5aa31c9a8f9ee4/chrome/browser/ui/startup/startup_browser_creator.cc
[modify] https://crrev.com/a6e2ff7f9e7249663424e01a3d5aa31c9a8f9ee4/chrome/browser/ui/webui/settings/reset_settings_handler.cc
[modify] https://crrev.com/a6e2ff7f9e7249663424e01a3d5aa31c9a8f9ee4/chrome/browser/ui/webui/settings/reset_settings_handler.h
[modify] https://crrev.com/a6e2ff7f9e7249663424e01a3d5aa31c9a8f9ee4/chrome/browser/ui/webui/settings/reset_settings_handler_unittest.cc
[modify] https://crrev.com/a6e2ff7f9e7249663424e01a3d5aa31c9a8f9ee4/chrome/test/data/webui/settings/reset_page_test.js

Comment 7 by alito@chromium.org, Oct 17 2016

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Verified in 9000.27.0, 56.0.2924.26.

Sign in to add a comment