Issue 636430 link

Starred by 1 user

Issue metadata

Status:	Archived
Owner:	█ reve...@chromium.org Last visit > 30 days ago
Closed:	Aug 2016
Cc:	osh...@chromium.org
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	1
Type:	Bug
M-53 Hotlist-Merge-Approved merge-merged-2785 VerifyIn-57 VerifyIn-58 VerifyIn-59 VerifyIn-60 VerifyIn-61

Prevent shell surfaces in system modal container from being maximized/minimized/fullscreen.

Project Member Reported by reve...@chromium.org, Aug 10 2016

Issue description

Such state changes should not be allowed for this type of window.

Project Member

Comment 1 by bugdroid1@chromium.org, Aug 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/79294dc1c7028268f419294d029537ebbf70f267

commit 79294dc1c7028268f419294d029537ebbf70f267
Author: reveman <reveman@chromium.org>
Date: Wed Aug 10 17:50:12 2016

exo: Prevent maximize/minimize of shell surface in system modal container.

Preventing maximize will also prevent fullscreen mode from being
entered.

BUG= 636430 

Review-Url: https://codereview.chromium.org/2236583002
Cr-Commit-Position: refs/heads/master@{#411080}

[modify] https://crrev.com/79294dc1c7028268f419294d029537ebbf70f267/components/exo/shell_surface.cc

Comment 2 by reve...@chromium.org, Aug 10 2016

Labels: Merge-Request-53

components/exo specific so it only affects arc++ chromeos devices.

Comment 3 by dimu@chromium.org, Aug 11 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved

Your change meets the bar and is auto-approved for M53 (branch: 2785)

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 11 2016

Labels: -merge-approved-53 merge-merged-2785

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56cc44461027ed952eec38cb2516c2e7a7f66202

commit 56cc44461027ed952eec38cb2516c2e7a7f66202
Author: David Reveman <reveman@chromium.org>
Date: Thu Aug 11 17:27:16 2016

exo: Prevent maximize/minimize of shell surface in system modal container.

Preventing maximize will also prevent fullscreen mode from being
entered.

BUG= 636430 

Review-Url: https://codereview.chromium.org/2236583002
Cr-Commit-Position: refs/heads/master@{#411080}
(cherry picked from commit 79294dc1c7028268f419294d029537ebbf70f267)

Review URL: https://codereview.chromium.org/2237093002 .

Cr-Commit-Position: refs/branch-heads/2785@{#563}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/56cc44461027ed952eec38cb2516c2e7a7f66202/components/exo/shell_surface.cc