New issue
Advanced search Search tips

Issue 636408 link

Starred by 1 user
Status: Fixed
Owner:
alito@chromium.org
Closed: Oct 2016
Cc:
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug

Blocking:
issue 636435



Sign in to add a comment

Routing to the settings reset dialog does not work with MD settings

Project Member Reported by alito@chromium.org, Aug 10 2016 
The following will get you to some version of the settings reset dialog when MD settings is not enabled:

chrome://settings/resetProfileSettings
chrome://settings/triggeredResetProfileSettings (Windows only)

They do not work when MD settings is enabled in chrome://flags.

Comment 1 by alito@chromium.org, Aug 10 2016

Blocking: 636435
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f9795e4f49c40f5a7cc8c6a619539ca71999551

commit 4f9795e4f49c40f5a7cc8c6a619539ca71999551
Author: alito <alito@chromium.org>
Date: Wed Oct 12 18:30:06 2016

md-settings: add routing to chrome://settings/triggeredResetProfileSettings

Adds the triggered veriant of the reset settings dialog in md-settings
and adds a URL alias for it.

BUG= 636408 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2371303002
Cr-Commit-Position: refs/heads/master@{#424794}

[modify] https://crrev.com/4f9795e4f49c40f5a7cc8c6a619539ca71999551/chrome/browser/resources/settings/reset_page/reset_browser_proxy.js
[modify] https://crrev.com/4f9795e4f49c40f5a7cc8c6a619539ca71999551/chrome/browser/resources/settings/reset_page/reset_page.js
[modify] https://crrev.com/4f9795e4f49c40f5a7cc8c6a619539ca71999551/chrome/browser/resources/settings/reset_page/reset_profile_dialog.html
[modify] https://crrev.com/4f9795e4f49c40f5a7cc8c6a619539ca71999551/chrome/browser/resources/settings/reset_page/reset_profile_dialog.js
[modify] https://crrev.com/4f9795e4f49c40f5a7cc8c6a619539ca71999551/chrome/browser/resources/settings/route.js
[modify] https://crrev.com/4f9795e4f49c40f5a7cc8c6a619539ca71999551/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/4f9795e4f49c40f5a7cc8c6a619539ca71999551/chrome/browser/ui/webui/settings/reset_settings_handler.cc
[modify] https://crrev.com/4f9795e4f49c40f5a7cc8c6a619539ca71999551/chrome/browser/ui/webui/settings/reset_settings_handler.h

Comment 4 by alito@chromium.org, Oct 12 2016

Cc: -alito@chromium.org
Owner: alito@chromium.org

Comment 5 by alito@chromium.org, Oct 13 2016

Status: Fixed (was: Untriaged)
►

Sign in to add a comment