Just to explain what the problem is: To gather all SH stories, we search through all visible fields of all modules in tools/perf/page_sets/system_health (similarly to how benchmarks are discovered). If you define two stories with the same class name, only the second one will be visible in the module, so the first one will not be added to the SH story set.

Fix pending: https://codereview.chromium.org/2235803002/

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec24992b4167ab4ca119601d5ca93522711a43d8

commit ec24992b4167ab4ca119601d5ca93522711a43d8
Author: petrcermak <petrcermak@chromium.org>
Date: Wed Aug 10 17:40:01 2016

[system-health] Rename browse:media:facebook to browse:media:facebook_photos

As part of the renaming, the patch changes the name of the classes
defining the stories ("Facebook(Mobile|Desktop)Story" to
"FacebookPhotos(Mobile|Desktop)Story" to avoid the clash with
browse:social:facebook (see the bug below).

The patch also adds a corresponding loading story
(load:media:facebook_photos) and removes the initial navigation to
facebook.com/rihanna from browse:media:facebook_photos. As a result,
there will be 4 Facebook stories on each platform:

  load:social:facebook
  browse:social:facebook
  load:media:facebook_photos
  browse:media:facebook_photos

Finally, the patch fixes the SystemHealthStory metaclass logic.

BUG= 636401 

Review-Url: https://codereview.chromium.org/2235803002
Cr-Commit-Position: refs/heads/master@{#411072}

[modify] https://crrev.com/ec24992b4167ab4ca119601d5ca93522711a43d8/tools/perf/page_sets/data/system_health_mobile.json
[delete] https://crrev.com/2f06e61927d77b49240266b75710908c8bf3710b/tools/perf/page_sets/data/system_health_mobile_007.wpr.sha1
[modify] https://crrev.com/ec24992b4167ab4ca119601d5ca93522711a43d8/tools/perf/page_sets/system_health/browsing_stories.py
[modify] https://crrev.com/ec24992b4167ab4ca119601d5ca93522711a43d8/tools/perf/page_sets/system_health/loading_stories.py
[modify] https://crrev.com/ec24992b4167ab4ca119601d5ca93522711a43d8/tools/perf/page_sets/system_health/system_health_story.py

This should now be fixed.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ecdac635b48b800d43798468decf5ac5b02279dd

commit ecdac635b48b800d43798468decf5ac5b02279dd
Author: nednguyen <nednguyen@google.com>
Date: Thu Aug 11 13:37:11 2016

[tools/perf] Enable many more lint checks for perf directory.

Among those that get enabled is "function-redefined" check that would prevent
people from redefining methods/classes.

BUG= 475714 ,  636401 

Review-Url: https://codereview.chromium.org/2228413003
Cr-Commit-Position: refs/heads/master@{#411313}

[modify] https://crrev.com/ecdac635b48b800d43798468decf5ac5b02279dd/tools/perf/benchmarks/benchmark_smoke_unittest.py
[modify] https://crrev.com/ecdac635b48b800d43798468decf5ac5b02279dd/tools/perf/core/benchmark_finders_unittest.py
[modify] https://crrev.com/ecdac635b48b800d43798468decf5ac5b02279dd/tools/perf/measurements/clock_domain_test.py
[modify] https://crrev.com/ecdac635b48b800d43798468decf5ac5b02279dd/tools/perf/page_sets/__init__.py
[modify] https://crrev.com/ecdac635b48b800d43798468decf5ac5b02279dd/tools/perf/page_sets/dual_browser_story.py
[modify] https://crrev.com/ecdac635b48b800d43798468decf5ac5b02279dd/tools/perf/page_sets/memory_top_10_mobile.py
[modify] https://crrev.com/ecdac635b48b800d43798468decf5ac5b02279dd/tools/perf/page_sets/typical_25.py
[modify] https://crrev.com/ecdac635b48b800d43798468decf5ac5b02279dd/tools/perf/pylintrc