New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 636397 link

Starred by 7 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Bookmarks bar: cannot move a bookmark which is inside a folder to another folder by drag and drop

Reported by bsdman...@gmail.com, Aug 10 2016

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2824.2 Safari/537.36

Steps to reproduce the problem:
1. Prerequisite: you must have at least two folders on the bookmarks bar (with bookmarks inside them).
2. Try to drag one bookmark from one folder, move it on the icon of another folder in order to drop it inside it. 

What is the expected behavior?
You should be able to drop the bookmark inside the folder (the bookmarks is moved)

What went wrong?
The dragged bookmark dissapears as soon as it reaches on the icon of the destination folder. You cannot move the bookmarks from a folder to another with drag and drop.

Did this work before? Yes 

Chrome version: 54.0.2824.2  Channel: dev
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version: Shockwave Flash 22.0 r0
 
Components: UI>Browser>Bookmarks
Labels: Needs-Feedback
Unable to reproduce the issue on Windows 7, Mac 10.11.5, Ubuntu 14.04 using 54.0.2824.2, latest canary 54.0.2826.0.Able to move a bookmark which is inside a folder to another folder by drag and drop.

Please find attached screencast.

bsdmanual@Could you please check the issue on latest canary 54.0.2826.0 and update the thread with screencast if issue still persists.
636397.mp4
460 KB View Download

Comment 2 by bsdman...@gmail.com, Aug 11 2016

Well i checked the canary build and the bug is reproducable there too.

I think that you cannot reproduce the problem because you drag n drop too quickly. Try to left click on the bookmark and keep the left click pressed until the bookmark disappears! As i noticed (check the video attached) the same behaviour is observd if you drag the bookmark to the bar. After a while the bookmark dissapears. 

Recording #1.mp4
309 KB View Download
 Issue 637542  has been merged into this issue.
Project Member

Comment 4 by sheriffbot@chromium.org, Aug 23 2016

Labels: -Needs-Feedback Needs-Review
Owner: ssamanoori@chromium.org
Thank you for providing more feedback. Adding requester "ssamanoori@chromium.org" for another review and adding "Needs-Review" label for tracking.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Issue still/also persists under 54.0.2840.34 beta-m (64-bit) on Windows 10 (#1607).

Current workaround is dragging the bookmark outside of its origin folder, releasing it, then dragging it onto the target folder.
Labels: -Needs-Review Needs-Bisect
Owner: ----
Status: Untriaged (was: Unconfirmed)
Able to reproduce the issue on win10 chrome version 55.0.2879.0 and beta 54.0.2840.41 - cannot move a bookmark which is inside a folder to another folder by drag and drop
Cc: kkaluri@chromium.org
Labels: -Type-Bug -Needs-Bisect hasbisect-per-revision M-55 OS-Linux Type-Bug-Regression
Owner: jonr...@chromium.org
Status: Assigned (was: Untriaged)
Able to reproduce this issue on Windows 10 and Ubuntu 14.04 on latest chrome Beta version 54.0.2840.41. Issue is broken in M54. Below are the bisect details for the same:

Bisect Info:
===========
Good Build : 54.0.2816.0 , Revision Range (409090)                                           
Bad Build  : 54.0.2817.0 , Revision Range (409416)

Change Log:
-----------
https://chromium.googlesource.com/chromium/src/+log/cc9f54f373f83303e2e74eb4748593a3876a59ae..3b7f52e862d774f939ecbf7cdce4dfae047dbb12

From the above CL suspecting the below change
Review URL:https://codereview.chromium.org/2155243007

jonross @- Could please look into this issue, if it's released to your change?  if not could you please help us to reassign this issue to the right owner.

P.S:This issue is not reproducible in MAC 10.12. with latest stable 53.0.2785.143, beta 54.0.2840.41, canary 55.0.2881.0 versions.

Thanks.!
Yeah this would be me.

The patch is fine for Chromium OS.
The patch does not affect Mac.
I'll look into why linux/windows are behaving oddly
Status: Started (was: Assigned)
jonross@ can we know what's the status of the fix since we are about to promote M55 to Beta and we need to get the fix into branch soon which should be by 4Pm on 19th-oct.



Status: Fixed (was: Started)
Strange, this issue wasn't updated by the code review that landed: https://codereview.chromium.org/2422283002/
pbommana@ does this require a merge-request label?
Labels: Merge-Request-55
Adding merge-request label in case we need to merge this into m55
 Issue 656909  has been merged into this issue.

Comment 15 by dimu@chromium.org, Oct 20 2016

Labels: -Merge-Request-55 Merge-Approved-55 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M55 (branch: 2883)
Project Member

Comment 16 by bugdroid1@chromium.org, Oct 20 2016

Labels: -merge-approved-55 merge-merged-2883
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b338046afd0398c969d96e2fd087ad95d3fbdaf

commit 2b338046afd0398c969d96e2fd087ad95d3fbdaf
Author: jonross <jonross@chromium.org>
Date: Thu Oct 20 20:03:06 2016

Merge Fix Bookmarks Bar Drag-and-Drop between folders
Fix Bookmarks Bar Drag-and-Drop between folders

Currently you cannot drag between two bookmarks folders on Linux and Windows.
Widget destruction on those platforms tears down their platform specific
drag-and-drop implementations.

This change updates MenuController to not tear down when Cancel is called if
a drag is currently occurring. The menu will still have all windows hidden, and
will be destroyed when drag-and-drop completes.

There are interactive_ui_tests covering the integration tests of this feature
in BookmarkBarViewTest. However they are disabled on Windows and Linux, missing
the bug at submission time. I've filed crbug.com/656712 to track the issues
with X11 preventing getting these tests running.

TBR=sky@chromium.org
NOTRY=true
NOPRESUBMIT=true
TEST=MenuControllerTest.CancelAllDuringDrag, manual testing on Linux and Windows
BUG= 636397 

Review-Url: https://codereview.chromium.org/2422283002
Cr-Commit-Position: refs/heads/master@{#425790}
(cherry picked from commit 24470df35ac9d98824f447d9a0112c0bdbdf1cb5)

Review-Url: https://chromiumcodereview.appspot.com/2440733003
Cr-Commit-Position: refs/branch-heads/2883@{#218}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/2b338046afd0398c969d96e2fd087ad95d3fbdaf/ui/views/controls/menu/menu_controller.cc
[modify] https://crrev.com/2b338046afd0398c969d96e2fd087ad95d3fbdaf/ui/views/controls/menu/menu_controller_unittest.cc

Cc: jonr...@chromium.org thomasanderson@chromium.org sky@chromium.org
 Issue 658010  has been merged into this issue.
Labels: -Pri-2 Merge-Request-54 Pri-1
If we can't do a clean revert on M54, can we at least merge the change from #16 to M54?
Cc: dpranke@chromium.org
Cc: jsc...@chromium.org
+justin@ and rpop@
This is currently broken on Windows stable
Cc: rpop@chromium.org
M54 is already shipped to Stable today(10/20), we can take the merge in case of|any refresh in future.
We'd also need to pull in the fix for  issue 656948 

I'll at the 54 merge request there too.

Comment 24 by dimu@chromium.org, Oct 24 2016

Labels: -Merge-Request-54 Merge-Review-54 Hotlist-Merge-Review
[Automated comment] Request affecting a post-stable build (M54), manual review required.
Labels: TE-Verified-M55 TE-Verified-55.0.2883.28
Tested the issue on Windows 10 , Ubuntu 14.04 using chrome beta version #55.0.2883.28.

Observed that fix is working as expected. Attached screencast for reference.

Adding the TE-Verified labels.

Issue 636397.mp4
1.1 MB View Download
Project Member

Comment 26 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b338046afd0398c969d96e2fd087ad95d3fbdaf

commit 2b338046afd0398c969d96e2fd087ad95d3fbdaf
Author: jonross <jonross@chromium.org>
Date: Thu Oct 20 20:03:06 2016

Merge Fix Bookmarks Bar Drag-and-Drop between folders
Fix Bookmarks Bar Drag-and-Drop between folders

Currently you cannot drag between two bookmarks folders on Linux and Windows.
Widget destruction on those platforms tears down their platform specific
drag-and-drop implementations.

This change updates MenuController to not tear down when Cancel is called if
a drag is currently occurring. The menu will still have all windows hidden, and
will be destroyed when drag-and-drop completes.

There are interactive_ui_tests covering the integration tests of this feature
in BookmarkBarViewTest. However they are disabled on Windows and Linux, missing
the bug at submission time. I've filed crbug.com/656712 to track the issues
with X11 preventing getting these tests running.

TBR=sky@chromium.org
NOTRY=true
NOPRESUBMIT=true
TEST=MenuControllerTest.CancelAllDuringDrag, manual testing on Linux and Windows
BUG= 636397 

Review-Url: https://codereview.chromium.org/2422283002
Cr-Commit-Position: refs/heads/master@{#425790}
(cherry picked from commit 24470df35ac9d98824f447d9a0112c0bdbdf1cb5)

Review-Url: https://chromiumcodereview.appspot.com/2440733003
Cr-Commit-Position: refs/branch-heads/2883@{#218}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/2b338046afd0398c969d96e2fd087ad95d3fbdaf/ui/views/controls/menu/menu_controller.cc
[modify] https://crrev.com/2b338046afd0398c969d96e2fd087ad95d3fbdaf/ui/views/controls/menu/menu_controller_unittest.cc

Labels: -merge-merged-2840
As per #26, bugdroid updated with incorrect label.

Sign in to add a comment