Issue metadata
Sign in to add a comment
|
Bookmarks bar: cannot move a bookmark which is inside a folder to another folder by drag and drop
Reported by
bsdman...@gmail.com,
Aug 10 2016
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 6.1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2824.2 Safari/537.36 Steps to reproduce the problem: 1. Prerequisite: you must have at least two folders on the bookmarks bar (with bookmarks inside them). 2. Try to drag one bookmark from one folder, move it on the icon of another folder in order to drop it inside it. What is the expected behavior? You should be able to drop the bookmark inside the folder (the bookmarks is moved) What went wrong? The dragged bookmark dissapears as soon as it reaches on the icon of the destination folder. You cannot move the bookmarks from a folder to another with drag and drop. Did this work before? Yes Chrome version: 54.0.2824.2 Channel: dev OS Version: 6.1 (Windows 7, Windows Server 2008 R2) Flash Version: Shockwave Flash 22.0 r0
,
Aug 11 2016
Well i checked the canary build and the bug is reproducable there too. I think that you cannot reproduce the problem because you drag n drop too quickly. Try to left click on the bookmark and keep the left click pressed until the bookmark disappears! As i noticed (check the video attached) the same behaviour is observd if you drag the bookmark to the bar. After a while the bookmark dissapears.
,
Aug 16 2016
Issue 637542 has been merged into this issue.
,
Aug 23 2016
Thank you for providing more feedback. Adding requester "ssamanoori@chromium.org" for another review and adding "Needs-Review" label for tracking. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 27 2016
Issue still/also persists under 54.0.2840.34 beta-m (64-bit) on Windows 10 (#1607). Current workaround is dragging the bookmark outside of its origin folder, releasing it, then dragging it onto the target folder.
,
Oct 3 2016
Able to reproduce the issue on win10 chrome version 55.0.2879.0 and beta 54.0.2840.41 - cannot move a bookmark which is inside a folder to another folder by drag and drop
,
Oct 5 2016
Able to reproduce this issue on Windows 10 and Ubuntu 14.04 on latest chrome Beta version 54.0.2840.41. Issue is broken in M54. Below are the bisect details for the same: Bisect Info: =========== Good Build : 54.0.2816.0 , Revision Range (409090) Bad Build : 54.0.2817.0 , Revision Range (409416) Change Log: ----------- https://chromium.googlesource.com/chromium/src/+log/cc9f54f373f83303e2e74eb4748593a3876a59ae..3b7f52e862d774f939ecbf7cdce4dfae047dbb12 From the above CL suspecting the below change Review URL:https://codereview.chromium.org/2155243007 jonross @- Could please look into this issue, if it's released to your change? if not could you please help us to reassign this issue to the right owner. P.S:This issue is not reproducible in MAC 10.12. with latest stable 53.0.2785.143, beta 54.0.2840.41, canary 55.0.2881.0 versions. Thanks.!
,
Oct 5 2016
Yeah this would be me. The patch is fine for Chromium OS. The patch does not affect Mac. I'll look into why linux/windows are behaving oddly
,
Oct 6 2016
,
Oct 18 2016
jonross@ can we know what's the status of the fix since we are about to promote M55 to Beta and we need to get the fix into branch soon which should be by 4Pm on 19th-oct.
,
Oct 18 2016
Strange, this issue wasn't updated by the code review that landed: https://codereview.chromium.org/2422283002/
,
Oct 18 2016
pbommana@ does this require a merge-request label?
,
Oct 19 2016
Adding merge-request label in case we need to merge this into m55
,
Oct 20 2016
Issue 656909 has been merged into this issue.
,
Oct 20 2016
Your change meets the bar and is auto-approved for M55 (branch: 2883)
,
Oct 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2b338046afd0398c969d96e2fd087ad95d3fbdaf commit 2b338046afd0398c969d96e2fd087ad95d3fbdaf Author: jonross <jonross@chromium.org> Date: Thu Oct 20 20:03:06 2016 Merge Fix Bookmarks Bar Drag-and-Drop between folders Fix Bookmarks Bar Drag-and-Drop between folders Currently you cannot drag between two bookmarks folders on Linux and Windows. Widget destruction on those platforms tears down their platform specific drag-and-drop implementations. This change updates MenuController to not tear down when Cancel is called if a drag is currently occurring. The menu will still have all windows hidden, and will be destroyed when drag-and-drop completes. There are interactive_ui_tests covering the integration tests of this feature in BookmarkBarViewTest. However they are disabled on Windows and Linux, missing the bug at submission time. I've filed crbug.com/656712 to track the issues with X11 preventing getting these tests running. TBR=sky@chromium.org NOTRY=true NOPRESUBMIT=true TEST=MenuControllerTest.CancelAllDuringDrag, manual testing on Linux and Windows BUG= 636397 Review-Url: https://codereview.chromium.org/2422283002 Cr-Commit-Position: refs/heads/master@{#425790} (cherry picked from commit 24470df35ac9d98824f447d9a0112c0bdbdf1cb5) Review-Url: https://chromiumcodereview.appspot.com/2440733003 Cr-Commit-Position: refs/branch-heads/2883@{#218} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/2b338046afd0398c969d96e2fd087ad95d3fbdaf/ui/views/controls/menu/menu_controller.cc [modify] https://crrev.com/2b338046afd0398c969d96e2fd087ad95d3fbdaf/ui/views/controls/menu/menu_controller_unittest.cc
,
Oct 20 2016
Issue 658010 has been merged into this issue.
,
Oct 20 2016
If we can't do a clean revert on M54, can we at least merge the change from #16 to M54?
,
Oct 20 2016
,
Oct 20 2016
+justin@ and rpop@ This is currently broken on Windows stable
,
Oct 20 2016
,
Oct 20 2016
M54 is already shipped to Stable today(10/20), we can take the merge in case of|any refresh in future.
,
Oct 21 2016
We'd also need to pull in the fix for issue 656948 I'll at the 54 merge request there too.
,
Oct 24 2016
[Automated comment] Request affecting a post-stable build (M54), manual review required.
,
Oct 26 2016
Tested the issue on Windows 10 , Ubuntu 14.04 using chrome beta version #55.0.2883.28. Observed that fix is working as expected. Attached screencast for reference. Adding the TE-Verified labels.
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2b338046afd0398c969d96e2fd087ad95d3fbdaf commit 2b338046afd0398c969d96e2fd087ad95d3fbdaf Author: jonross <jonross@chromium.org> Date: Thu Oct 20 20:03:06 2016 Merge Fix Bookmarks Bar Drag-and-Drop between folders Fix Bookmarks Bar Drag-and-Drop between folders Currently you cannot drag between two bookmarks folders on Linux and Windows. Widget destruction on those platforms tears down their platform specific drag-and-drop implementations. This change updates MenuController to not tear down when Cancel is called if a drag is currently occurring. The menu will still have all windows hidden, and will be destroyed when drag-and-drop completes. There are interactive_ui_tests covering the integration tests of this feature in BookmarkBarViewTest. However they are disabled on Windows and Linux, missing the bug at submission time. I've filed crbug.com/656712 to track the issues with X11 preventing getting these tests running. TBR=sky@chromium.org NOTRY=true NOPRESUBMIT=true TEST=MenuControllerTest.CancelAllDuringDrag, manual testing on Linux and Windows BUG= 636397 Review-Url: https://codereview.chromium.org/2422283002 Cr-Commit-Position: refs/heads/master@{#425790} (cherry picked from commit 24470df35ac9d98824f447d9a0112c0bdbdf1cb5) Review-Url: https://chromiumcodereview.appspot.com/2440733003 Cr-Commit-Position: refs/branch-heads/2883@{#218} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/2b338046afd0398c969d96e2fd087ad95d3fbdaf/ui/views/controls/menu/menu_controller.cc [modify] https://crrev.com/2b338046afd0398c969d96e2fd087ad95d3fbdaf/ui/views/controls/menu/menu_controller_unittest.cc
,
Nov 1 2016
As per #26, bugdroid updated with incorrect label. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ssamanoori@chromium.org
, Aug 11 2016Labels: Needs-Feedback
460 KB
460 KB View Download