Blink-test-autoroller can not land CL's (Needs another LGTM) |
||||||
Issue description# out> Using 50% similarity for rename/copy detection. Override with --similarity. # out> Running presubmit commit checks ... # out> # out> ** Presubmit Messages ** # out> If this change has an associated bug, add BUG=[bug number]. # out> # out> ** Presubmit ERRORS ** # out> Missing LGTM from someone other than blink-w3c-test-autoroller@chromium.org # out> # out> Missing LGTM from someone other than blink-w3c-test-autoroller@chromium.org # out> # out> Presubmit checks took 1.8s to calculate. # out> # out> Was the presubmit check useful? If not, run "git cl presubmit -v" # out> to figure out which PRESUBMIT.py was run, then run git blame # out> on the file to figure out who to ask for help. step returned non-zero exit code: 1 @@@STEP_FAILURE@@@
,
Aug 10 2016
,
Aug 10 2016
,
Aug 10 2016
Discussed offline briefly: What rebaseline-o-matic does is to add a TBR line; we also want to add a TBR line whenever committing from the bot, regardless of whether there's one patch (tests modified, no failures) or two patches (tests modified, then TestExpectations or baselines modified). This is being done in https://codereview.chromium.org/2232983002.
,
Aug 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f08a90bd55aac0e2bc25fb75d7e7d9974bb79ee2 commit f08a90bd55aac0e2bc25fb75d7e7d9974bb79ee2 Author: dcampb <dcampb@google.com> Date: Wed Aug 10 20:24:05 2016 Add TBR to commit message BUG= 636379 Review-Url: https://codereview.chromium.org/2232983002 Cr-Commit-Position: refs/heads/master@{#411133} [modify] https://crrev.com/f08a90bd55aac0e2bc25fb75d7e7d9974bb79ee2/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py
,
Aug 10 2016
Removing the Infra component; please re-add if you need infra help.
,
Aug 12 2016
Adding the TBR line should fix this. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by dcampb@google.com
, Aug 10 2016