New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 636344 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Away
Closed: Aug 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug-Regression



Sign in to add a comment

testCloseFiveIncognitoTab* tests failing on Android bots

Project Member Reported by perezju@chromium.org, Aug 10 2016

Issue description

The following tests from chrome_public_test_apk:

- org.chromium.chrome.browser.TabsTest#testCloseFiveIncognitoTabLandscape
- org.chromium.chrome.browser.TabsTest#testCloseFiveIncognitoTabPortrait

started failing consistently on bots (link to first failure):

https://build.chromium.org/p/chromium.android/builders/Jelly%20Bean%20Tester/builds/5440
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/35661

Overlapping CL range:
http://test-results.appspot.com/revision_range?start=410984&end=411000
 
Logs only have a tiny description of the error, e.g.:

I 2156.920s run_tests_on_device(01cd2ea51a1ba2b6)  detected failure in org.chromium.chrome.browser.TabsTest#testCloseFiveIncognitoTabLandscape. raw output:
I 2156.920s run_tests_on_device(01cd2ea51a1ba2b6)    INSTRUMENTATION_STATUS: id=InstrumentationTestRunner
I 2156.920s run_tests_on_device(01cd2ea51a1ba2b6)    INSTRUMENTATION_STATUS: current=1
I 2156.920s run_tests_on_device(01cd2ea51a1ba2b6)    INSTRUMENTATION_STATUS: class=org.chromium.chrome.browser.TabsTest
I 2156.920s run_tests_on_device(01cd2ea51a1ba2b6)    INSTRUMENTATION_STATUS: stream=
I 2156.920s run_tests_on_device(01cd2ea51a1ba2b6)    org.chromium.chrome.browser.TabsTest:
I 2156.920s run_tests_on_device(01cd2ea51a1ba2b6)    INSTRUMENTATION_STATUS: numtests=1
I 2156.921s run_tests_on_device(01cd2ea51a1ba2b6)    INSTRUMENTATION_STATUS: test=testCloseFiveIncognitoTabLandscape
I 2156.921s run_tests_on_device(01cd2ea51a1ba2b6)    INSTRUMENTATION_STATUS_CODE: 1
I 2156.921s run_tests_on_device(01cd2ea51a1ba2b6)    INSTRUMENTATION_RESULT: shortMsg=Native crash
I 2156.921s run_tests_on_device(01cd2ea51a1ba2b6)    INSTRUMENTATION_RESULT: longMsg=Native crash: Segmentation fault
I 2156.921s run_tests_on_device(01cd2ea51a1ba2b6)    INSTRUMENTATION_CODE: 0
https://build.chromium.org/p/chromium.android/builders/Jelly%20Bean%20Tester/builds/5440/steps/chrome_public_test_apk/logs/stdio
Cc: n...@chromium.org
+Newton, maybe you can help diagnose these?
Cc: twelling...@chromium.org dfalcant...@chromium.org
Looks like newton is away, adding a few more people who recently reviewed changes to this file.
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af7dfbe1caf07ba720221ed293818a89674e71ed

commit af7dfbe1caf07ba720221ed293818a89674e71ed
Author: perezju <perezju@chromium.org>
Date: Wed Aug 10 14:47:14 2016

Disable testCloseFiveIncognitoTab* tests

Tests are failing on Android Tests (dbg), and Jelly Bean Tester.

TBR=dfalcantara@chromium.org,twellington@chromium.org
BUG= 636344 

Review-Url: https://codereview.chromium.org/2232883002
Cr-Commit-Position: refs/heads/master@{#411038}

[modify] https://crrev.com/af7dfbe1caf07ba720221ed293818a89674e71ed/chrome/android/javatests/src/org/chromium/chrome/browser/TabsTest.java

Cc: -n...@chromium.org
Labels: -Pri-3 Pri-1
Owner: ian...@chromium.org
Status: Assigned (was: Untriaged)
-newt@ Newton moved teams earlier this year.


+ianwen@ - the only change Java change in the regression range is the change to show infobars on native pages. This crash is on a native page but otherwise I'm not sure why it's crashing. Will you please take a look?

https://chromium.googlesource.com/chromium/src/+/6943a9a92a909bb927080ef6c7658ddbce3a3ae7



From the Android Test bot:
I  188.135s run_tests_on_device(0cbc7389032fddae)  detected failure in org.chromium.chrome.browser.TabsTest#testCloseFiveIncognitoTabPortrait. raw output:
I  188.135s run_tests_on_device(0cbc7389032fddae)    INSTRUMENTATION_STATUS: numtests=1
I  188.135s run_tests_on_device(0cbc7389032fddae)    INSTRUMENTATION_STATUS: stream=
I  188.135s run_tests_on_device(0cbc7389032fddae)    org.chromium.chrome.browser.TabsTest:
I  188.135s run_tests_on_device(0cbc7389032fddae)    INSTRUMENTATION_STATUS: id=InstrumentationTestRunner
I  188.135s run_tests_on_device(0cbc7389032fddae)    INSTRUMENTATION_STATUS: test=testCloseFiveIncognitoTabPortrait
I  188.135s run_tests_on_device(0cbc7389032fddae)    INSTRUMENTATION_STATUS: class=org.chromium.chrome.browser.TabsTest
I  188.136s run_tests_on_device(0cbc7389032fddae)    INSTRUMENTATION_STATUS: current=1
I  188.136s run_tests_on_device(0cbc7389032fddae)    INSTRUMENTATION_STATUS_CODE: 1
I  188.136s run_tests_on_device(0cbc7389032fddae)    INSTRUMENTATION_RESULT: shortMsg=Native crash
I  188.136s run_tests_on_device(0cbc7389032fddae)    INSTRUMENTATION_RESULT: longMsg=Native crash: Aborted
I  188.136s run_tests_on_device(0cbc7389032fddae)    INSTRUMENTATION_CODE: 0


This native crash: aborted probably corresponds to this stack trace in the tombstones (#92 stack_tool_with_logcat_dump)


[FATAL:jni_android.cc(236)] Please include Java exception stack in crash report
signal 6 (SIGABRT) at 0x00000c1e (code=-6), thread 3102 (chromium.chrome)
pid: 3102, tid: 3102, name: chromium.chrome  >>> org.chromium.chrome <<<
signal 6 (SIGABRT), code -6 (SI_TKILL), fault addr --------
     r0 00000000  r1 00000c1e  r2 00000006  r3 00000000
     r4 00000006  r5 0000000b  r6 00000c1e  r7 0000010c
     r8 beb5df8c  r9 beb5db48  sl 00000000  fp 0000000a
     ip 40117384  sp beb5d9c8  lr 400dbfe5  pc 400eaf90

Stack Trace:
  RELADDR   FUNCTION                                                                                                                                FILE:LINE
  00021f90  tgkill+12                                                                                                                               /system/lib/libc.so
  00012fe1  pthread_kill+48                                                                                                                         /system/lib/libc.so
  000131f5  raise+10                                                                                                                                /system/lib/libc.so
  00011f2b  <unknown>                                                                                                                               /system/lib/libc.so
  00021844  abort+4                                                                                                                                 /system/lib/libc.so
  000f4f51  <unknown>                                                                                                                               /data/app-lib/org.chromium.chrome-1/libchrome.so
  00108683  <unknown>                                                                                                                               /data/app-lib/org.chromium.chrome-1/libchrome.so
  000eb135  <unknown>                                                                                                                               /data/app-lib/org.chromium.chrome-1/libchrome.so
  01de7c3b  blink::WebGLRenderingContextBase::getFramebufferAttachmentParameter(blink::ScriptState*, unsigned int, unsigned int, unsigned int)+330  /b/c/b/android/src/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp:2699
  00d25083  media::ChannelCountToSLESChannelMask(int)+30                                                                                            /b/c/b/android/src/media/audio/android/opensles_util.cc:23
  00959c81  GrSkFilterQualityToGrFilterMode(SkFilterQuality, SkMatrix const&, SkMatrix const&, bool*)+56                                            /b/c/b/android/src/third_party/skia/src/gpu/SkGr.cpp:761
  0095b8cd  SkImage::MakeTextureFromPixmap(GrContext*, SkPixmap const&, SkBudgeted)+136                                                             /b/c/b/android/src/third_party/skia/src/image/SkImage_Gpu.cpp:355
  000f788f  <unknown>                                                                                                                               /data/app-lib/org.chromium.chrome-1/libchrome.so
  0010d585  <unknown>                                                                                                                               /data/app-lib/org.chromium.chrome-1/libchrome.so
  0010dc5b  <unknown>                                                                                                                               /data/app-lib/org.chromium.chrome-1/libchrome.so
  0010dd59  <unknown>                                                                                                                               /data/app-lib/org.chromium.chrome-1/libchrome.so
  0010f743  <unknown>                                                                                                                               /data/app-lib/org.chromium.chrome-1/libchrome.so
  0001dbcc  dvmPlatformInvoke+112                                                                                                                   /system/lib/libdvm.so
  0004e123  dvmCallJNIMethod(unsigned int const*, JValue*, Method const*, Thread*)+398                                                              /system/lib/libdvm.so
  00026fe0  <unknown>                                                                                                                               /system/lib/libdvm.so
  0002dfa0  dvmMterpStd(Thread*)+76                                                                                                                 /system/lib/libdvm.so
  0002b638  dvmInterpret(Thread*, Method const*, JValue*)+184                                                                                       /system/lib/libdvm.so
  00060861  dvmInvokeMethod(Object*, Method const*, ArrayObject*, ArrayObject*, ClassObject*, bool)+392                                             /system/lib/libdvm.so
  000687c3  <unknown>                                                                                                                               /system/lib/libdvm.so
  00026fe0  <unknown>                                                                                                                               /system/lib/libdvm.so
  0002dfa0  dvmMterpStd(Thread*)+76                                                                                                                 /system/lib/libdvm.so
  0002b638  dvmInterpret(Thread*, Method const*, JValue*)+184                                                                                       /system/lib/libdvm.so
  0006057d  dvmCallMethodV(Thread*, Method const*, Object*, bool, JValue*, std::__va_list)+336                                                      /system/lib/libdvm.so
  00049d0b  <unknown>                                                                                                                               /system/lib/libdvm.so
  0004d2b3  <unknown>                                                                                                                               /system/lib/libandroid_runtime.so
  0004dfd7  android::AndroidRuntime::start(char const*, char const*)+354                                                                            /system/lib/libandroid_runtime.so
  0000105b  <unknown>                                                                                                                               /system/bin/app_process

Stack Data:
  ADDR      VALUE     FUNCTION         FILE:LINE
  beb5d988  7dff2000                   
  beb5d98c  beb5df88                   [stack]
  beb5d990  beb5df84                   [stack]
  beb5d994  7dff2008                   
  beb5d998  beb5df88                   [stack]
  beb5d99c  400da257  dlfree+50        /system/lib/libc.so
  beb5d9a0  40113000  <unknown>        /system/lib/libc.so
  beb5d9a4  beb5d9ec                   [stack]
  beb5d9a8  beb5d9ec                   [stack]
  beb5d9ac  beb5df88                   [stack]
  beb5d9b0  00000060                   
  beb5d9b4  7bc94c10  <unknown>        /data/app-lib/org.chromium.chrome-1/libchrome.so
  beb5d9b8  40117210                   
  beb5d9bc  7bc94c10  <unknown>        /data/app-lib/org.chromium.chrome-1/libchrome.so
  beb5d9c0  401131d8  <unknown>        /system/lib/libc.so
  beb5d9c4  71c5f720  <unknown>        [anon:libc_malloc]
  beb5d9c8  00000006                   
  beb5d9cc  0000000b                   
  beb5d9d0  00000c1e                   
  beb5d9d4  40117384                   
  beb5d9d8  40117384                   
  beb5d9dc  400dbfe5  pthread_kill+52  /system/lib/libc.so
  beb5d9e0  00000006                   
  beb5d9e4  00000000                   
  beb5d9e8  beb5df84                   [stack]
  beb5d9ec  400dc1f9  raise+14         /system/lib/libc.so
  beb5d9f0  beb5d9fc                   [stack]
  beb5d9f4  400daf2f  <unknown>        /system/lib/libc.so

Java stderr from crashing pid (may identify underlying Java exception):
java.lang.AssertionError: Destroy called before removed from window
  at org.chromium.chrome.browser.ntp.IncognitoNewTabPage.destroy(IncognitoNewTabPage.java:86)
  at org.chromium.chrome.browser.tab.Tab.destroyNativePageInternal(Tab.java:2353)
  at org.chromium.chrome.browser.tab.Tab.destroy(Tab.java:2029)
  at org.chromium.chrome.browser.tabmodel.TabModelImpl.finalizeTabClosure(TabModelImpl.java:589)
  at org.chromium.chrome.browser.tabmodel.TabModelImpl.closeTab(TabModelImpl.java:369)
  at org.chromium.chrome.browser.tabmodel.TabModelImpl.closeTab(TabModelImpl.java:340)
  at org.chromium.chrome.browser.tabmodel.OffTheRecordTabModel.closeTab(OffTheRecordTabModel.java:120)
  at org.chromium.chrome.browser.tabmodel.TabModelUtils.closeTabById(TabModelUtils.java:48)
  at org.chromium.chrome.browser.compositor.layouts.phone.StackLayout.uiDoneClosingTab(StackLayout.java:444)
  at org.chromium.chrome.browser.compositor.layouts.phone.stack.Stack.finishAnimation(Stack.java:585)
  at org.chromium.chrome.browser.compositor.layouts.phone.stack.Stack.finishAnimationsIfDone(Stack.java:736)
  at org.chromium.chrome.browser.compositor.layouts.phone.stack.Stack.onUpdateCompositorAnimations(Stack.java:719)
  at org.chromium.chrome.browser.compositor.layouts.phone.StackLayout.onUpdateAnimation(StackLayout.java:366)
  at org.chromium.chrome.browser.compositor.layouts.Layout.onUpdate(Layout.java:318)
  at org.chromium.chrome.browser.compositor.layouts.LayoutManager.onUpdate(LayoutManager.java:225)
  at org.chromium.chrome.browser.compositor.layouts.LayoutManager.onUpdate(LayoutManager.java:210)
  at org.chromium.chrome.browser.compositor.CompositorViewHolder.onCompositorLayout(CompositorViewHolder.java:534)
  at org.chromium.chrome.browser.compositor.CompositorView.onCompositorLayout(CompositorView.java:245)
  at org.chromium.base.SystemMessageHandler.nativeDoRunLoopOnce(Native Method)
  at org.chromium.base.SystemMessageHandler.handleMessage(SystemMessageHandler.java:39)
  at android.os.Handler.dispatchMessage(Handler.java:102)
  at android.os.Looper.loop(Looper.java:136)
  at android.app.ActivityThread.main(ActivityThread.java:5001)
  at java.lang.reflect.Method.invokeNative(Native Method)
  at java.lang.reflect.Method.invoke(Method.java:515)
  at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:785)
  at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:601)
  at dalvik.system.NativeStart.main(Native Method)
Labels: -Type-Bug Type-Bug-Regression
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab524b85b109a71c36d98146405af0db9bd02fcb

commit ab524b85b109a71c36d98146405af0db9bd02fcb
Author: twellington <twellington@chromium.org>
Date: Wed Aug 10 18:13:03 2016

Revert of Disable testCloseFiveIncognitoTab* tests (patchset #1 id:1 of https://codereview.chromium.org/2232883002/ )

Reason for revert:
The suspected CL was reverted and the current Android Tests(dbg) build #35666 with that revert is passing on the testCloseFiveIncognitoTab* tests. Reverting this CL so that we still get test coverage (these are important tests).

Original issue's description:
> Disable testCloseFiveIncognitoTab* tests
>
> Tests are failing on Android Tests (dbg), and Jelly Bean Tester.
>
> TBR=dfalcantara@chromium.org,twellington@chromium.org
> BUG= 636344 
>
> Committed: https://crrev.com/af7dfbe1caf07ba720221ed293818a89674e71ed
> Cr-Commit-Position: refs/heads/master@{#411038}

TBR=dfalcantara@chromium.org,perezju@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 636344 

Review-Url: https://codereview.chromium.org/2236653002
Cr-Commit-Position: refs/heads/master@{#411085}

[modify] https://crrev.com/ab524b85b109a71c36d98146405af0db9bd02fcb/chrome/android/javatests/src/org/chromium/chrome/browser/TabsTest.java

Status: Fixed (was: Assigned)
Thanks!

Tests are passing now. Work on the feature seems to continue on issue 508307.

Sign in to add a comment