Issue metadata
Sign in to add a comment
|
Regression: Profile name seems chopped after adding new profile.
Reported by
dmascare...@etouch.net,
Aug 10 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version: 54.0.2825.0 Revision 3d58aef05951368778eda5aa835969a8f04bf285-refs/heads/master@{#410913} OS: Windows(7,8,10) Pre-condition: 1. Enable material design user menu flag. 2. Change the browser language in 'Hindi' What steps will reproduce the problem? 1. Launch chrome and click on avatar icon,click on 'Switch person' option (switch person overlay gets open). 2. Click on 'Add person' such that new profile gets open and again click on avatar icon, observe. Actual: Profile name seems chopped. Expected: Profile name should be proper. This is regression issue, broken in 'M 54' and below is narrow bisect: https://chromium.googlesource.com/chromium/src/+log/8cc17dd5bd16119157decba981d11f1e217052dd..e6fcf92ec826c6b56672eec154e2075b1d01cf60?pretty=fuller&n=100 Suspecting: r406377 Good build:54.0.2801.0 Bad build:54.0.2802.0 Note: Issue is not seen Mac and Linux OS.
,
Aug 10 2016
This feature is still behind a flag, removing RBS. Dana: Of the commits mentioned in bisect, this is the one that most gets my attention: https://codereview.chromium.org/1634103003 Fix gfx::Canvas::DrawStringRectWithHalo What do you think?
,
Aug 10 2016
I don't see halo on that text, so I dunno why that patch would impact it. But I don't see anything else. rogerta@ are you able to try reverting and see if it fixes it locally?
,
Aug 11 2016
Hello. I run chrome with flags --material --top-chrome-md --lang=hi, but I can't reproduce. Could you add more pictures in WTR steps (or may be video?)
,
Aug 11 2016
Re #4: Material design user menu is behind a different flag: --flag-switches-begin --enable-features=MaterialDesignUserMenu --flag-switches-end
,
Aug 11 2016
I reproduced some problem (see screenshot). I checked, it was broken in https://codereview.chromium.org/2023093002 Is it the same bug?
,
Aug 11 2016
Re #6: Can this be reproduced on a newer build like 54.0.2802.0? Does the icon cut-off happen for other profile pictures too, or is it just the default grey one? And avatar names don't look chopped for you?
,
Aug 11 2016
I can reproduce it on HEAD in master (https://download-chromium.appspot.com) Icon cut-off happens for all profiles in Hindi (but English and Russian looks good). Avatar names don't look chopped in any case.
,
Aug 24 2016
,
Aug 24 2016
Reassigning to Roger for now, since this looks like it has to do with the new user menu
,
Aug 24 2016
Roger and I were able to repro the chopped-off profile name on Hindi browser. We also found that English profile name/username get chopped-off on Hindi browser too (see attached). I have a fix for these problems to be submitted soon. However, we couldn't repro the problem mentioned in comment #6.
,
Aug 24 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b409fbb2cd01a0d05a40dff2daa22685fa14d2f3 commit b409fbb2cd01a0d05a40dff2daa22685fa14d2f3 Author: janeliulwq <janeliulwq@google.com> Date: Wed Aug 24 22:08:31 2016 [MD User Menu] Un-hardcode profile card's spacing On MD user menu, vertical spacings in the profile card used to be hardcoded, hence causing some display problems on certain locales (see first bug for how Hindi names would get chopped off). This CL calculates the spacing needed given the height of the profile name label and/or username label in the profile card, hence fixing the chopped-off problem - see a new screenshot here: https://screenshot.googleplex.com/FHK5snyG0PH. BUG= 636321 BUG= 615893 Review-Url: https://codereview.chromium.org/2230963004 Cr-Commit-Position: refs/heads/master@{#414167} [modify] https://crrev.com/b409fbb2cd01a0d05a40dff2daa22685fa14d2f3/chrome/browser/ui/views/profiles/profile_chooser_view.cc
,
Aug 24 2016
The CL above fixes the problem described in the original comment. Again, we couldn't repro comment #6.
,
Aug 24 2016
,
Sep 1 2016
I checked latest master, couldn't repro comment #6. I think it was fixed. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ranjitkan@chromium.org
, Aug 10 2016