New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 636318 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: May 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Delete all traces of consumer enrollment code.

Project Member Reported by tnagel@chromium.org, Aug 10 2016

Issue description

See issue 353050 for the original implementation.

 

Comment 1 by tnagel@chromium.org, Aug 10 2016

Status: Available (was: Untriaged)
First part: https://codereview.chromium.org/2230533002/
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ae5ce60dc9addb27383cce094b98c951753d0f38

commit ae5ce60dc9addb27383cce094b98c951753d0f38
Author: tnagel <tnagel@chromium.org>
Date: Fri Aug 12 10:46:40 2016

Delete dead consumer enrollment code.

BUG= 636318 
TBR=oshima
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2230533002
Cr-Commit-Position: refs/heads/master@{#411592}

[modify] https://crrev.com/ae5ce60dc9addb27383cce094b98c951753d0f38/chrome/app/chromeos_strings.grdp
[delete] https://crrev.com/f86c8b09a35bf827144214afec1c456415c4d24c/chrome/app/theme/default_100_percent/cros/consumer_management_notification_icon.png
[delete] https://crrev.com/f86c8b09a35bf827144214afec1c456415c4d24c/chrome/app/theme/default_200_percent/cros/consumer_management_notification_icon.png
[modify] https://crrev.com/ae5ce60dc9addb27383cce094b98c951753d0f38/chrome/app/theme/theme_resources.grd
[modify] https://crrev.com/ae5ce60dc9addb27383cce094b98c951753d0f38/chrome/browser/BUILD.gn
[modify] https://crrev.com/ae5ce60dc9addb27383cce094b98c951753d0f38/chrome/browser/chromeos/login/chrome_restart_request.cc
[modify] https://crrev.com/ae5ce60dc9addb27383cce094b98c951753d0f38/chrome/browser/chromeos/login/enrollment/enterprise_enrollment_helper_impl.cc
[modify] https://crrev.com/ae5ce60dc9addb27383cce094b98c951753d0f38/chrome/browser/chromeos/net/network_portal_notification_controller.cc
[modify] https://crrev.com/ae5ce60dc9addb27383cce094b98c951753d0f38/chrome/browser/chromeos/ownership/fake_owner_settings_service.cc
[modify] https://crrev.com/ae5ce60dc9addb27383cce094b98c951753d0f38/chrome/browser/chromeos/ownership/fake_owner_settings_service.h
[modify] https://crrev.com/ae5ce60dc9addb27383cce094b98c951753d0f38/chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc
[modify] https://crrev.com/ae5ce60dc9addb27383cce094b98c951753d0f38/chrome/browser/chromeos/ownership/owner_settings_service_chromeos.h
[modify] https://crrev.com/ae5ce60dc9addb27383cce094b98c951753d0f38/chrome/browser/chromeos/ownership/owner_settings_service_chromeos_unittest.cc
[modify] https://crrev.com/ae5ce60dc9addb27383cce094b98c951753d0f38/chrome/browser/chromeos/policy/browser_policy_connector_chromeos.cc
[modify] https://crrev.com/ae5ce60dc9addb27383cce094b98c951753d0f38/chrome/browser/chromeos/policy/browser_policy_connector_chromeos.h
[delete] https://crrev.com/f86c8b09a35bf827144214afec1c456415c4d24c/chrome/browser/chromeos/policy/consumer_enrollment_handler.cc
[delete] https://crrev.com/f86c8b09a35bf827144214afec1c456415c4d24c/chrome/browser/chromeos/policy/consumer_enrollment_handler.h
[delete] https://crrev.com/f86c8b09a35bf827144214afec1c456415c4d24c/chrome/browser/chromeos/policy/consumer_enrollment_handler_factory.cc
[delete] https://crrev.com/f86c8b09a35bf827144214afec1c456415c4d24c/chrome/browser/chromeos/policy/consumer_enrollment_handler_factory.h
[delete] https://crrev.com/f86c8b09a35bf827144214afec1c456415c4d24c/chrome/browser/chromeos/policy/consumer_enrollment_handler_factory_unittest.cc
[delete] https://crrev.com/f86c8b09a35bf827144214afec1c456415c4d24c/chrome/browser/chromeos/policy/consumer_enrollment_handler_unittest.cc
[delete] https://crrev.com/f86c8b09a35bf827144214afec1c456415c4d24c/chrome/browser/chromeos/policy/consumer_management_notifier.cc
[delete] https://crrev.com/f86c8b09a35bf827144214afec1c456415c4d24c/chrome/browser/chromeos/policy/consumer_management_notifier.h
[delete] https://crrev.com/f86c8b09a35bf827144214afec1c456415c4d24c/chrome/browser/chromeos/policy/consumer_management_notifier_factory.cc
[delete] https://crrev.com/f86c8b09a35bf827144214afec1c456415c4d24c/chrome/browser/chromeos/policy/consumer_management_notifier_factory.h
[delete] https://crrev.com/f86c8b09a35bf827144214afec1c456415c4d24c/chrome/browser/chromeos/policy/consumer_management_notifier_factory_unittest.cc
[delete] https://crrev.com/f86c8b09a35bf827144214afec1c456415c4d24c/chrome/browser/chromeos/policy/consumer_management_notifier_unittest.cc
[delete] https://crrev.com/f86c8b09a35bf827144214afec1c456415c4d24c/chrome/browser/chromeos/policy/consumer_management_service.cc
[delete] https://crrev.com/f86c8b09a35bf827144214afec1c456415c4d24c/chrome/browser/chromeos/policy/consumer_management_service.h
[delete] https://crrev.com/f86c8b09a35bf827144214afec1c456415c4d24c/chrome/browser/chromeos/policy/consumer_management_service_unittest.cc
[delete] https://crrev.com/f86c8b09a35bf827144214afec1c456415c4d24c/chrome/browser/chromeos/policy/consumer_management_stage.cc
[delete] https://crrev.com/f86c8b09a35bf827144214afec1c456415c4d24c/chrome/browser/chromeos/policy/consumer_management_stage.h
[delete] https://crrev.com/f86c8b09a35bf827144214afec1c456415c4d24c/chrome/browser/chromeos/policy/consumer_unenrollment_handler.cc
[delete] https://crrev.com/f86c8b09a35bf827144214afec1c456415c4d24c/chrome/browser/chromeos/policy/consumer_unenrollment_handler.h
[delete] https://crrev.com/f86c8b09a35bf827144214afec1c456415c4d24c/chrome/browser/chromeos/policy/consumer_unenrollment_handler_factory.cc
[delete] https://crrev.com/f86c8b09a35bf827144214afec1c456415c4d24c/chrome/browser/chromeos/policy/consumer_unenrollment_handler_factory.h
[delete] https://crrev.com/f86c8b09a35bf827144214afec1c456415c4d24c/chrome/browser/chromeos/policy/consumer_unenrollment_handler_unittest.cc
[modify] https://crrev.com/ae5ce60dc9addb27383cce094b98c951753d0f38/chrome/browser/chromeos/policy/device_cloud_policy_initializer.cc
[modify] https://crrev.com/ae5ce60dc9addb27383cce094b98c951753d0f38/chrome/browser/chromeos/policy/device_cloud_policy_initializer.h
[modify] https://crrev.com/ae5ce60dc9addb27383cce094b98c951753d0f38/chrome/browser/chromeos/policy/device_cloud_policy_initializer_unittest.cc
[modify] https://crrev.com/ae5ce60dc9addb27383cce094b98c951753d0f38/chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc
[modify] https://crrev.com/ae5ce60dc9addb27383cce094b98c951753d0f38/chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.cc
[modify] https://crrev.com/ae5ce60dc9addb27383cce094b98c951753d0f38/chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos_unittest.cc
[modify] https://crrev.com/ae5ce60dc9addb27383cce094b98c951753d0f38/chrome/browser/chromeos/policy/device_local_account_policy_service.cc
[modify] https://crrev.com/ae5ce60dc9addb27383cce094b98c951753d0f38/chrome/browser/chromeos/policy/enrollment_handler_chromeos.cc
[modify] https://crrev.com/ae5ce60dc9addb27383cce094b98c951753d0f38/chrome/browser/chromeos/policy/enrollment_handler_chromeos.h
[delete] https://crrev.com/f86c8b09a35bf827144214afec1c456415c4d24c/chrome/browser/chromeos/policy/fake_consumer_management_service.cc
[delete] https://crrev.com/f86c8b09a35bf827144214afec1c456415c4d24c/chrome/browser/chromeos/policy/fake_consumer_management_service.h
[modify] https://crrev.com/ae5ce60dc9addb27383cce094b98c951753d0f38/chrome/browser/chromeos/policy/fake_device_cloud_policy_initializer.cc
[modify] https://crrev.com/ae5ce60dc9addb27383cce094b98c951753d0f38/chrome/browser/chromeos/policy/fake_device_cloud_policy_initializer.h
[modify] https://crrev.com/ae5ce60dc9addb27383cce094b98c951753d0f38/chrome/browser/chromeos/settings/device_settings_provider.cc
[modify] https://crrev.com/ae5ce60dc9addb27383cce094b98c951753d0f38/chrome/browser/chromeos/settings/device_settings_provider_unittest.cc
[modify] https://crrev.com/ae5ce60dc9addb27383cce094b98c951753d0f38/chrome/browser/prefs/browser_prefs.cc
[modify] https://crrev.com/ae5ce60dc9addb27383cce094b98c951753d0f38/chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc
[modify] https://crrev.com/ae5ce60dc9addb27383cce094b98c951753d0f38/chrome/browser/resources/options/browser_options.html
[modify] https://crrev.com/ae5ce60dc9addb27383cce094b98c951753d0f38/chrome/browser/resources/options/browser_options.js
[delete] https://crrev.com/f86c8b09a35bf827144214afec1c456415c4d24c/chrome/browser/resources/options/chromeos/consumer_management_overlay.css
[delete] https://crrev.com/f86c8b09a35bf827144214afec1c456415c4d24c/chrome/browser/resources/options/chromeos/consumer_management_overlay.html
[delete] https://crrev.com/f86c8b09a35bf827144214afec1c456415c4d24c/chrome/browser/resources/options/chromeos/consumer_management_overlay.js
[modify] https://crrev.com/ae5ce60dc9addb27383cce094b98c951753d0f38/chrome/browser/resources/options/options.html
[modify] https://crrev.com/ae5ce60dc9addb27383cce094b98c951753d0f38/chrome/browser/resources/options/options.js
[modify] https://crrev.com/ae5ce60dc9addb27383cce094b98c951753d0f38/chrome/browser/resources/options/options_bundle.js
[modify] https://crrev.com/ae5ce60dc9addb27383cce094b98c951753d0f38/chrome/browser/ui/webui/options/browser_options_handler.cc
[modify] https://crrev.com/ae5ce60dc9addb27383cce094b98c951753d0f38/chrome/browser/ui/webui/options/browser_options_handler.h
[delete] https://crrev.com/f86c8b09a35bf827144214afec1c456415c4d24c/chrome/browser/ui/webui/options/chromeos/consumer_management_handler.cc
[delete] https://crrev.com/f86c8b09a35bf827144214afec1c456415c4d24c/chrome/browser/ui/webui/options/chromeos/consumer_management_handler.h
[modify] https://crrev.com/ae5ce60dc9addb27383cce094b98c951753d0f38/chrome/browser/ui/webui/options/options_ui.cc
[modify] https://crrev.com/ae5ce60dc9addb27383cce094b98c951753d0f38/chrome/chrome_browser_chromeos.gypi
[modify] https://crrev.com/ae5ce60dc9addb27383cce094b98c951753d0f38/chrome/chrome_browser_ui.gypi
[modify] https://crrev.com/ae5ce60dc9addb27383cce094b98c951753d0f38/chrome/chrome_tests_unit.gypi
[modify] https://crrev.com/ae5ce60dc9addb27383cce094b98c951753d0f38/chrome/common/pref_names.cc
[modify] https://crrev.com/ae5ce60dc9addb27383cce094b98c951753d0f38/chromeos/chromeos_switches.cc
[modify] https://crrev.com/ae5ce60dc9addb27383cce094b98c951753d0f38/chromeos/chromeos_switches.h
[modify] https://crrev.com/ae5ce60dc9addb27383cce094b98c951753d0f38/components/components_tests.gyp
[modify] https://crrev.com/ae5ce60dc9addb27383cce094b98c951753d0f38/components/policy/core/common/BUILD.gn
[modify] https://crrev.com/ae5ce60dc9addb27383cce094b98c951753d0f38/components/policy/core/common/cloud/cloud_policy_constants.cc
[modify] https://crrev.com/ae5ce60dc9addb27383cce094b98c951753d0f38/components/policy/core/common/cloud/cloud_policy_constants.h
[delete] https://crrev.com/f86c8b09a35bf827144214afec1c456415c4d24c/components/policy/core/common/cloud/cloud_policy_constants_unittest.cc

Cc: bartfab@chromium.org dzhioev@chromium.org
 Issue 564947  has been merged into this issue.

Comment 4 by tnagel@chromium.org, May 18 2017

Cc: -tnagel@chromium.org
Owner: tnagel@chromium.org
Status: Fixed (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, May 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e26133f5e217f0425b7032df60358b9feeb81980

commit e26133f5e217f0425b7032df60358b9feeb81980
Author: tnagel <tnagel@chromium.org>
Date: Thu May 18 15:01:00 2017

PolicyData proto: Obsolete "consumer" ManagementMode

Removing another remainder of consumer enrollment.

BUG= 636318 

Review-Url: https://codereview.chromium.org/2886403004
Cr-Commit-Position: refs/heads/master@{#472808}

[modify] https://crrev.com/e26133f5e217f0425b7032df60358b9feeb81980/chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc
[modify] https://crrev.com/e26133f5e217f0425b7032df60358b9feeb81980/components/policy/proto/device_management_backend.proto

Comment 6 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 7 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment