New issue
Advanced search Search tips

Issue 636311 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

LayoutTests/platform/win/svg/custom/use-clipped-hit-expected.png expectation is "Unknown", failing on Win10

Project Member Reported by foolip@chromium.org, Aug 10 2016

Issue description

Something appears to have gone wrong with a recent CL and/or rebaseline:
https://chromium.googlesource.com/chromium/src/+/6ffa8394ec09cac47f842e47f843ad13dc25feb2
https://chromium.googlesource.com/chromium/src/+/436d32972b32ef4cf3191d84df9be971a12bfa08

Before, all 3 platforms had expected PNGs saying "Passed", but afterwards there's two for windows, with one of them saying "Unknown". Win10 is failing on that:
https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Win10/13433/layout-test-results/results.html

I'll mark the test as [ Skip ] for now, probably it just needs the expectations to be sorted out somehow, a new rebaseline probably won't fix it.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01de84e72cec58c06733b9ecbbc4cbe4b7f6c590

commit 01de84e72cec58c06733b9ecbbc4cbe4b7f6c590
Author: Philip Jägenstedt <foolip@chromium.org>
Date: Wed Aug 10 10:46:33 2016

Allow svg/custom/use-clipped-hit.svg to fail on Win10

It's not known to be flaky, but I'm not 100% sure about which platform
expectations will be used and which bots will be affected, and requiring
failure might cause more things to fail.

BUG= 636311 
TBR=yosin@chromium.org

Review URL: https://codereview.chromium.org/2231783002 .

Cr-Commit-Position: refs/heads/master@{#411021}

[modify] https://crrev.com/01de84e72cec58c06733b9ecbbc4cbe4b7f6c590/third_party/WebKit/LayoutTests/TestExpectations

Components: -Blink>TextSelection Blink>SVG
Owner: schenney@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d06111131dd62259122d071bd019ac52ffc74ce8

commit d06111131dd62259122d071bd019ac52ffc74ce8
Author: schenney <schenney@chromium.org>
Date: Thu Aug 25 17:13:29 2016

Rebaseline two failing tests on Win10

svg/W3C-SVG-1.1/filters-composite-02-b.svg and svg/custom/use-clipped-hit.svg
are failing on Win10, and the latter may be flaky. But the flaky one is
mostly failing and only occasionally passing, which would be better reversed.
The former test seems to be always failing, so rebase to see if it's really flaky.

TBR=pdr@chromium.org
BUG= 636311 , 632217 

Review-Url: https://codereview.chromium.org/2278683002
Cr-Commit-Position: refs/heads/master@{#414460}

[modify] https://crrev.com/d06111131dd62259122d071bd019ac52ffc74ce8/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/d06111131dd62259122d071bd019ac52ffc74ce8/third_party/WebKit/LayoutTests/platform/win/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt
[modify] https://crrev.com/d06111131dd62259122d071bd019ac52ffc74ce8/third_party/WebKit/LayoutTests/platform/win/svg/custom/use-clipped-hit-expected.png
[modify] https://crrev.com/d06111131dd62259122d071bd019ac52ffc74ce8/third_party/WebKit/LayoutTests/platform/win/svg/custom/use-clipped-hit-expected.txt
[delete] https://crrev.com/c2fb7d7326813eca1ef5d185f4da5f92c93af025/third_party/WebKit/LayoutTests/platform/win7/svg/custom/use-clipped-hit-expected.png
[delete] https://crrev.com/c2fb7d7326813eca1ef5d185f4da5f92c93af025/third_party/WebKit/LayoutTests/platform/win7/svg/custom/use-clipped-hit-expected.txt

Status: Fixed (was: Assigned)

Sign in to add a comment