Change WebURLLoaderClient::willFollowRedirect() to return a bool |
||
Issue descriptionWriting a patch for this. https://codereview.chromium.org/2230173002/
,
Oct 5 2016
,
Oct 5 2016
Created a new bug 653047 for stopFetching() removal.
,
Oct 24 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fbff05cfbc1af00ed8391f87ad49d23f632eddd6 commit fbff05cfbc1af00ed8391f87ad49d23f632eddd6 Author: tyoshino <tyoshino@chromium.org> Date: Mon Oct 24 11:50:01 2016 Remove unnecessary setAllowStoredCredentials() call in PingLoader::willFollowRedirect() This doesn't have any effect on sendBeacon's credentials handling. This code was introduced in https://codereview.chromium.org/1016373002, but even since at this point, AllowStoredCredentials is passed to the BeaconLoader constructor. Replacing with DCHECK. R=mkwst@chromium.org BUG= 636297 Review-Url: https://codereview.chromium.org/2336273003 Cr-Commit-Position: refs/heads/master@{#427048} [add] https://crrev.com/fbff05cfbc1af00ed8391f87ad49d23f632eddd6/third_party/WebKit/LayoutTests/http/tests/navigation/beacon-cross-origin-redirect-credentials.html [modify] https://crrev.com/fbff05cfbc1af00ed8391f87ad49d23f632eddd6/third_party/WebKit/LayoutTests/http/tests/navigation/resources/save-beacon.php [modify] https://crrev.com/fbff05cfbc1af00ed8391f87ad49d23f632eddd6/third_party/WebKit/Source/core/loader/PingLoader.cpp |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Oct 5 2016