New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 636289 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocked on:
issue 700825

Blocking:
issue 585553



Sign in to add a comment

Files app: Remove circular dependencies from *.js files to migrate to closure compiler v2 syntax.

Project Member Reported by fukino@chromium.org, Aug 10 2016

Issue description

File manager concatenates almost all scripts and then compiles it using closure compiler for type checking.
It is tough to maintain the script list.
The relationships between files and restrictions about script order are not clear.
The list needs to be updated when some depended modules (outside file manager) are updated.

In v2 syntax, maintaining script list will be much easier.
However, we need to remove circular dependencies between files to migrate to v2, since we need to declare dependencies explicitly for each files in v2 syntax.
 

Comment 1 by fukino@chromium.org, Aug 18 2016

As a first step, I added v2 gyp files, but most of the targets are commented out for now.
https://codereview.chromium.org/2229333002
(for some reason, this bug is not updated by the commit)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d54cfea10b58af54234c0c29ce2df19ea2e860d0

commit d54cfea10b58af54234c0c29ce2df19ea2e860d0
Author: fukino <fukino@chromium.org>
Date: Mon Aug 22 09:30:22 2016

Files: Extract VolumeInfo interface from volume_manager.js.

Extracted VolumeInfo interface so that our modules which depend on only the VolumeInfo's interface
don't need to have dependencies on the VolumeInfo's implementation.

BUG= 636289 
TEST=third_party/closure_compiler/run_compiler

Review-Url: https://codereview.chromium.org/2260133002
Cr-Commit-Position: refs/heads/master@{#413423}

[modify] https://crrev.com/d54cfea10b58af54234c0c29ce2df19ea2e860d0/third_party/closure_compiler/compiled_resources2.gyp
[modify] https://crrev.com/d54cfea10b58af54234c0c29ce2df19ea2e860d0/ui/file_manager/audio_player/js/compiled_resources.gyp
[modify] https://crrev.com/d54cfea10b58af54234c0c29ce2df19ea2e860d0/ui/file_manager/audio_player/js/compiled_resources2.gyp
[modify] https://crrev.com/d54cfea10b58af54234c0c29ce2df19ea2e860d0/ui/file_manager/externs/compiled_resources2.gyp
[add] https://crrev.com/d54cfea10b58af54234c0c29ce2df19ea2e860d0/ui/file_manager/externs/volume_info.js
[modify] https://crrev.com/d54cfea10b58af54234c0c29ce2df19ea2e860d0/ui/file_manager/file_manager/background/js/compiled_resources.gyp
[modify] https://crrev.com/d54cfea10b58af54234c0c29ce2df19ea2e860d0/ui/file_manager/file_manager/background/js/mock_volume_manager.js
[modify] https://crrev.com/d54cfea10b58af54234c0c29ce2df19ea2e860d0/ui/file_manager/file_manager/background/js/test_util_base.js
[modify] https://crrev.com/d54cfea10b58af54234c0c29ce2df19ea2e860d0/ui/file_manager/file_manager/background/js/volume_manager.js
[modify] https://crrev.com/d54cfea10b58af54234c0c29ce2df19ea2e860d0/ui/file_manager/file_manager/background/js/volume_manager_unittest.js
[modify] https://crrev.com/d54cfea10b58af54234c0c29ce2df19ea2e860d0/ui/file_manager/file_manager/common/js/compiled_resources2.gyp
[modify] https://crrev.com/d54cfea10b58af54234c0c29ce2df19ea2e860d0/ui/file_manager/file_manager/foreground/js/compiled_resources.gyp
[modify] https://crrev.com/d54cfea10b58af54234c0c29ce2df19ea2e860d0/ui/file_manager/file_manager/foreground/js/compiled_resources2.gyp
[modify] https://crrev.com/d54cfea10b58af54234c0c29ce2df19ea2e860d0/ui/file_manager/file_manager/foreground/js/navigation_list_model_unittest.js
[modify] https://crrev.com/d54cfea10b58af54234c0c29ce2df19ea2e860d0/ui/file_manager/file_manager/foreground/js/providers_model_unittest.js
[modify] https://crrev.com/d54cfea10b58af54234c0c29ce2df19ea2e860d0/ui/file_manager/gallery/js/compiled_resources.gyp
[modify] https://crrev.com/d54cfea10b58af54234c0c29ce2df19ea2e860d0/ui/file_manager/video_player/js/compiled_resources.gyp

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d19f48706428300449ca4aed64b764bd23c69da7

commit d19f48706428300449ca4aed64b764bd23c69da7
Author: fukino <fukino@chromium.org>
Date: Tue Aug 23 06:08:46 2016

Files app: Concatenate background scripts.

Concatenate scripts to:
- Reduce HTTP requests in background script.
- Save resource IDs.
- Make it easier to divide JS files into smaller ones.

The size of file_manager_resources.pak increases by 24 KB (4,187 KB => 4,211 KB),
but I think it worth doing.

BUG= 639225 , 636289 
TEST=run browser_tests

Review-Url: https://codereview.chromium.org/2261043003
Cr-Commit-Position: refs/heads/master@{#413677}

[add] https://crrev.com/d19f48706428300449ca4aed64b764bd23c69da7/ui/file_manager/audio_player/js/background_scripts.js
[modify] https://crrev.com/d19f48706428300449ca4aed64b764bd23c69da7/ui/file_manager/audio_player/manifest.json
[add] https://crrev.com/d19f48706428300449ca4aed64b764bd23c69da7/ui/file_manager/file_manager/background/js/background_common_scripts.js
[add] https://crrev.com/d19f48706428300449ca4aed64b764bd23c69da7/ui/file_manager/file_manager/background/js/background_scripts.js
[modify] https://crrev.com/d19f48706428300449ca4aed64b764bd23c69da7/ui/file_manager/file_manager/manifest.json
[modify] https://crrev.com/d19f48706428300449ca4aed64b764bd23c69da7/ui/file_manager/file_manager_resources.grd
[add] https://crrev.com/d19f48706428300449ca4aed64b764bd23c69da7/ui/file_manager/gallery/js/background_scripts.js
[modify] https://crrev.com/d19f48706428300449ca4aed64b764bd23c69da7/ui/file_manager/gallery/manifest.json
[add] https://crrev.com/d19f48706428300449ca4aed64b764bd23c69da7/ui/file_manager/image_loader/background_scripts.js
[modify] https://crrev.com/d19f48706428300449ca4aed64b764bd23c69da7/ui/file_manager/image_loader/manifest.json
[add] https://crrev.com/d19f48706428300449ca4aed64b764bd23c69da7/ui/file_manager/video_player/js/background_scripts.js
[modify] https://crrev.com/d19f48706428300449ca4aed64b764bd23c69da7/ui/file_manager/video_player/manifest.json

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a5abef97afdb57b24e5bce63fb10054ca0266b91

commit a5abef97afdb57b24e5bce63fb10054ca0266b91
Author: fukino <fukino@chromium.org>
Date: Fri Sep 02 06:59:51 2016

Divide volume_manager.js into files for each classes and extract interfaces from them.

This CL divides classes in volume_manager.js into separate files.
In addition, it extracts interfaces from each classes so that foreground scripts can refer to the interface definitions without depending on their implementation classes.

BUG= 636289 
TEST=run browser_tests

Review-Url: https://codereview.chromium.org/2292873003
Cr-Commit-Position: refs/heads/master@{#416205}

[modify] https://crrev.com/a5abef97afdb57b24e5bce63fb10054ca0266b91/ui/file_manager/audio_player/js/compiled_resources.gyp
[add] https://crrev.com/a5abef97afdb57b24e5bce63fb10054ca0266b91/ui/file_manager/externs/background_window_common.js
[add] https://crrev.com/a5abef97afdb57b24e5bce63fb10054ca0266b91/ui/file_manager/externs/entry_location.js
[add] https://crrev.com/a5abef97afdb57b24e5bce63fb10054ca0266b91/ui/file_manager/externs/volume_info_list.js
[add] https://crrev.com/a5abef97afdb57b24e5bce63fb10054ca0266b91/ui/file_manager/externs/volume_manager.js
[modify] https://crrev.com/a5abef97afdb57b24e5bce63fb10054ca0266b91/ui/file_manager/file_manager/background/js/background.js
[modify] https://crrev.com/a5abef97afdb57b24e5bce63fb10054ca0266b91/ui/file_manager/file_manager/background/js/background_base.js
[modify] https://crrev.com/a5abef97afdb57b24e5bce63fb10054ca0266b91/ui/file_manager/file_manager/background/js/background_common_scripts.js
[modify] https://crrev.com/a5abef97afdb57b24e5bce63fb10054ca0266b91/ui/file_manager/file_manager/background/js/compiled_resources.gyp
[modify] https://crrev.com/a5abef97afdb57b24e5bce63fb10054ca0266b91/ui/file_manager/file_manager/background/js/device_handler.js
[modify] https://crrev.com/a5abef97afdb57b24e5bce63fb10054ca0266b91/ui/file_manager/file_manager/background/js/device_handler_unittest.html
[modify] https://crrev.com/a5abef97afdb57b24e5bce63fb10054ca0266b91/ui/file_manager/file_manager/background/js/duplicate_finder.js
[modify] https://crrev.com/a5abef97afdb57b24e5bce63fb10054ca0266b91/ui/file_manager/file_manager/background/js/duplicate_finder_unittest.html
[add] https://crrev.com/a5abef97afdb57b24e5bce63fb10054ca0266b91/ui/file_manager/file_manager/background/js/entry_location_impl.js
[modify] https://crrev.com/a5abef97afdb57b24e5bce63fb10054ca0266b91/ui/file_manager/file_manager/background/js/file_operation_manager.js
[modify] https://crrev.com/a5abef97afdb57b24e5bce63fb10054ca0266b91/ui/file_manager/file_manager/background/js/file_operation_manager_unittest.js
[modify] https://crrev.com/a5abef97afdb57b24e5bce63fb10054ca0266b91/ui/file_manager/file_manager/background/js/launcher_search.js
[modify] https://crrev.com/a5abef97afdb57b24e5bce63fb10054ca0266b91/ui/file_manager/file_manager/background/js/media_import_handler_unittest.html
[modify] https://crrev.com/a5abef97afdb57b24e5bce63fb10054ca0266b91/ui/file_manager/file_manager/background/js/mock_volume_manager.js
[modify] https://crrev.com/a5abef97afdb57b24e5bce63fb10054ca0266b91/ui/file_manager/file_manager/background/js/test_util_base.js
[add] https://crrev.com/a5abef97afdb57b24e5bce63fb10054ca0266b91/ui/file_manager/file_manager/background/js/volume_info_impl.js
[add] https://crrev.com/a5abef97afdb57b24e5bce63fb10054ca0266b91/ui/file_manager/file_manager/background/js/volume_info_list_impl.js
[delete] https://crrev.com/2f9c93110386ac6742a7bb55d7057aff368113e5/ui/file_manager/file_manager/background/js/volume_manager.js
[add] https://crrev.com/a5abef97afdb57b24e5bce63fb10054ca0266b91/ui/file_manager/file_manager/background/js/volume_manager_factory.js
[add] https://crrev.com/a5abef97afdb57b24e5bce63fb10054ca0266b91/ui/file_manager/file_manager/background/js/volume_manager_impl.js
[modify] https://crrev.com/a5abef97afdb57b24e5bce63fb10054ca0266b91/ui/file_manager/file_manager/background/js/volume_manager_unittest.html
[modify] https://crrev.com/a5abef97afdb57b24e5bce63fb10054ca0266b91/ui/file_manager/file_manager/background/js/volume_manager_unittest.js
[add] https://crrev.com/a5abef97afdb57b24e5bce63fb10054ca0266b91/ui/file_manager/file_manager/background/js/volume_manager_util.js
[modify] https://crrev.com/a5abef97afdb57b24e5bce63fb10054ca0266b91/ui/file_manager/file_manager/common/js/importer_common_unittest.html
[modify] https://crrev.com/a5abef97afdb57b24e5bce63fb10054ca0266b91/ui/file_manager/file_manager/common/js/volume_manager_common.js
[modify] https://crrev.com/a5abef97afdb57b24e5bce63fb10054ca0266b91/ui/file_manager/file_manager/foreground/js/actions_model_unittest.html
[modify] https://crrev.com/a5abef97afdb57b24e5bce63fb10054ca0266b91/ui/file_manager/file_manager/foreground/js/compiled_resources.gyp
[modify] https://crrev.com/a5abef97afdb57b24e5bce63fb10054ca0266b91/ui/file_manager/file_manager/foreground/js/import_controller_unittest.html
[modify] https://crrev.com/a5abef97afdb57b24e5bce63fb10054ca0266b91/ui/file_manager/file_manager/foreground/js/navigation_list_model_unittest.html
[modify] https://crrev.com/a5abef97afdb57b24e5bce63fb10054ca0266b91/ui/file_manager/file_manager/foreground/js/providers_model_unittest.html
[modify] https://crrev.com/a5abef97afdb57b24e5bce63fb10054ca0266b91/ui/file_manager/file_manager/foreground/js/ui/directory_tree_unittest.html
[modify] https://crrev.com/a5abef97afdb57b24e5bce63fb10054ca0266b91/ui/file_manager/file_manager/foreground/js/volume_manager_wrapper.js
[modify] https://crrev.com/a5abef97afdb57b24e5bce63fb10054ca0266b91/ui/file_manager/gallery/js/compiled_resources.gyp
[modify] https://crrev.com/a5abef97afdb57b24e5bce63fb10054ca0266b91/ui/file_manager/video_player/js/compiled_resources.gyp

Is this fixed?
Labels: M-56
It is not fixed yet.
Let me set the target to M56.
Labels: -M-56 M-57
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5b094e5fcc2c975659de1fc24b7b5190abd9bf0

commit c5b094e5fcc2c975659de1fc24b7b5190abd9bf0
Author: fukino <fukino@chromium.org>
Date: Mon Dec 26 08:54:28 2016

Files app: Move common/js/externs.js to externs/*.

BUG= 636289 
TEST=run third_party/closure_compiler/run_compiler
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2606653002
Cr-Commit-Position: refs/heads/master@{#440700}

[modify] https://crrev.com/c5b094e5fcc2c975659de1fc24b7b5190abd9bf0/ui/file_manager/compiled_resources2.gyp
[add] https://crrev.com/c5b094e5fcc2c975659de1fc24b7b5190abd9bf0/ui/file_manager/externs/background_window.js
[modify] https://crrev.com/c5b094e5fcc2c975659de1fc24b7b5190abd9bf0/ui/file_manager/externs/compiled_resources2.gyp
[add] https://crrev.com/c5b094e5fcc2c975659de1fc24b7b5190abd9bf0/ui/file_manager/externs/directory_change_event.js
[add] https://crrev.com/c5b094e5fcc2c975659de1fc24b7b5190abd9bf0/ui/file_manager/externs/entries_changed_event.js
[add] https://crrev.com/c5b094e5fcc2c975659de1fc24b7b5190abd9bf0/ui/file_manager/externs/file_operation_progress_event.js
[modify] https://crrev.com/c5b094e5fcc2c975659de1fc24b7b5190abd9bf0/ui/file_manager/file_manager/background/js/compiled_resources.gyp
[modify] https://crrev.com/c5b094e5fcc2c975659de1fc24b7b5190abd9bf0/ui/file_manager/file_manager/common/js/compiled_resources2.gyp
[delete] https://crrev.com/abf28be153791a45d2611227d177156ab851943b/ui/file_manager/file_manager/common/js/externs.js
[modify] https://crrev.com/c5b094e5fcc2c975659de1fc24b7b5190abd9bf0/ui/file_manager/file_manager/common/js/lru_cache_unittest.js
[modify] https://crrev.com/c5b094e5fcc2c975659de1fc24b7b5190abd9bf0/ui/file_manager/file_manager/foreground/js/compiled_resources.gyp

Project Member

Comment 9 by bugdroid1@chromium.org, Dec 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/831b595d306205c2647dfd18fb00cb635625b797

commit 831b595d306205c2647dfd18fb00cb635625b797
Author: fukino <fukino@chromium.org>
Date: Mon Dec 26 09:25:38 2016

Files app: Remove closure compiler targets which are used only in tests.

BUG= 636289 
TEST=run third_party/closure_compiler/run_compiler
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2603683002
Cr-Commit-Position: refs/heads/master@{#440704}

[modify] https://crrev.com/831b595d306205c2647dfd18fb00cb635625b797/ui/file_manager/audio_player/js/compiled_resources2.gyp
[modify] https://crrev.com/831b595d306205c2647dfd18fb00cb635625b797/ui/file_manager/file_manager/background/js/compiled_resources2.gyp
[modify] https://crrev.com/831b595d306205c2647dfd18fb00cb635625b797/ui/file_manager/file_manager/common/js/compiled_resources2.gyp
[modify] https://crrev.com/831b595d306205c2647dfd18fb00cb635625b797/ui/file_manager/file_manager/foreground/js/compiled_resources2.gyp
[modify] https://crrev.com/831b595d306205c2647dfd18fb00cb635625b797/ui/file_manager/file_manager/foreground/js/metadata/compiled_resources2.gyp
[modify] https://crrev.com/831b595d306205c2647dfd18fb00cb635625b797/ui/file_manager/file_manager/foreground/js/ui/compiled_resources2.gyp
[modify] https://crrev.com/831b595d306205c2647dfd18fb00cb635625b797/ui/file_manager/gallery/js/compiled_resources2.gyp
[modify] https://crrev.com/831b595d306205c2647dfd18fb00cb635625b797/ui/file_manager/gallery/js/image_editor/compiled_resources2.gyp
[modify] https://crrev.com/831b595d306205c2647dfd18fb00cb635625b797/ui/file_manager/image_loader/compiled_resources2.gyp
[modify] https://crrev.com/831b595d306205c2647dfd18fb00cb635625b797/ui/file_manager/video_player/js/compiled_resources2.gyp

Project Member

Comment 10 by bugdroid1@chromium.org, Dec 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/564d27aacd3d09a7cb97f2463abab1dec36b4bb2

commit 564d27aacd3d09a7cb97f2463abab1dec36b4bb2
Author: fukino <fukino@chromium.org>
Date: Mon Dec 26 10:02:31 2016

Files app: Compile common/js/util.js

BUG= 636289 
TEST=run third_party/closure_compiler/run_compiler
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2606663002
Cr-Commit-Position: refs/heads/master@{#440707}

[modify] https://crrev.com/564d27aacd3d09a7cb97f2463abab1dec36b4bb2/ui/file_manager/audio_player/js/compiled_resources.gyp
[rename] https://crrev.com/564d27aacd3d09a7cb97f2463abab1dec36b4bb2/ui/file_manager/externs/app_window_common.js
[modify] https://crrev.com/564d27aacd3d09a7cb97f2463abab1dec36b4bb2/ui/file_manager/externs/audio_player_foreground.js
[modify] https://crrev.com/564d27aacd3d09a7cb97f2463abab1dec36b4bb2/ui/file_manager/externs/compiled_resources2.gyp
[modify] https://crrev.com/564d27aacd3d09a7cb97f2463abab1dec36b4bb2/ui/file_manager/externs/gallery_background.js
[modify] https://crrev.com/564d27aacd3d09a7cb97f2463abab1dec36b4bb2/ui/file_manager/externs/gallery_foreground.js
[modify] https://crrev.com/564d27aacd3d09a7cb97f2463abab1dec36b4bb2/ui/file_manager/file_manager/common/js/compiled_resources2.gyp
[modify] https://crrev.com/564d27aacd3d09a7cb97f2463abab1dec36b4bb2/ui/file_manager/gallery/js/compiled_resources.gyp
[modify] https://crrev.com/564d27aacd3d09a7cb97f2463abab1dec36b4bb2/ui/file_manager/video_player/js/compiled_resources.gyp

Project Member

Comment 13 by bugdroid1@chromium.org, Jan 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1a7078994c97ac791bdd45abec4fdce33900901

commit c1a7078994c97ac791bdd45abec4fdce33900901
Author: fukino <fukino@chromium.org>
Date: Tue Jan 10 12:53:38 2017

Files.app: Compile file_manager/foreground/js/metadata in v2 syntax.

BUG= 636289 
TEST=run third_party/closure_compiler/run_compiler
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2607453002
Cr-Commit-Position: refs/heads/master@{#442563}

[modify] https://crrev.com/c1a7078994c97ac791bdd45abec4fdce33900901/third_party/closure_compiler/compile2.py
[modify] https://crrev.com/c1a7078994c97ac791bdd45abec4fdce33900901/ui/file_manager/audio_player/js/audio_player_scripts.js
[modify] https://crrev.com/c1a7078994c97ac791bdd45abec4fdce33900901/ui/file_manager/audio_player/js/compiled_resources.gyp
[modify] https://crrev.com/c1a7078994c97ac791bdd45abec4fdce33900901/ui/file_manager/compiled_resources2.gyp
[modify] https://crrev.com/c1a7078994c97ac791bdd45abec4fdce33900901/ui/file_manager/externs/compiled_resources2.gyp
[add] https://crrev.com/c1a7078994c97ac791bdd45abec4fdce33900901/ui/file_manager/externs/metadata_worker_window.js
[modify] https://crrev.com/c1a7078994c97ac791bdd45abec4fdce33900901/ui/file_manager/file_manager/foreground/js/compiled_resources.gyp
[modify] https://crrev.com/c1a7078994c97ac791bdd45abec4fdce33900901/ui/file_manager/file_manager/foreground/js/main_scripts.js
[modify] https://crrev.com/c1a7078994c97ac791bdd45abec4fdce33900901/ui/file_manager/file_manager/foreground/js/metadata/compiled_resources2.gyp
[modify] https://crrev.com/c1a7078994c97ac791bdd45abec4fdce33900901/ui/file_manager/file_manager/foreground/js/metadata/content_metadata_provider.js
[modify] https://crrev.com/c1a7078994c97ac791bdd45abec4fdce33900901/ui/file_manager/file_manager/foreground/js/metadata/content_metadata_provider_unittest.html
[modify] https://crrev.com/c1a7078994c97ac791bdd45abec4fdce33900901/ui/file_manager/file_manager/foreground/js/metadata/exif_parser.js
[modify] https://crrev.com/c1a7078994c97ac791bdd45abec4fdce33900901/ui/file_manager/file_manager/foreground/js/metadata/external_metadata_provider.js
[modify] https://crrev.com/c1a7078994c97ac791bdd45abec4fdce33900901/ui/file_manager/file_manager/foreground/js/metadata/external_metadata_provider_unittest.html
[modify] https://crrev.com/c1a7078994c97ac791bdd45abec4fdce33900901/ui/file_manager/file_manager/foreground/js/metadata/file_system_metadata_provider_unittest.html
[modify] https://crrev.com/c1a7078994c97ac791bdd45abec4fdce33900901/ui/file_manager/file_manager/foreground/js/metadata/function_parallel.js
[modify] https://crrev.com/c1a7078994c97ac791bdd45abec4fdce33900901/ui/file_manager/file_manager/foreground/js/metadata/function_sequence.js
[modify] https://crrev.com/c1a7078994c97ac791bdd45abec4fdce33900901/ui/file_manager/file_manager/foreground/js/metadata/id3_parser.js
[modify] https://crrev.com/c1a7078994c97ac791bdd45abec4fdce33900901/ui/file_manager/file_manager/foreground/js/metadata/image_parsers.js
[modify] https://crrev.com/c1a7078994c97ac791bdd45abec4fdce33900901/ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_item_unittest.html
[modify] https://crrev.com/c1a7078994c97ac791bdd45abec4fdce33900901/ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_set.js
[modify] https://crrev.com/c1a7078994c97ac791bdd45abec4fdce33900901/ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_set_unittest.html
[modify] https://crrev.com/c1a7078994c97ac791bdd45abec4fdce33900901/ui/file_manager/file_manager/foreground/js/metadata/metadata_dispatcher.js
[modify] https://crrev.com/c1a7078994c97ac791bdd45abec4fdce33900901/ui/file_manager/file_manager/foreground/js/metadata/metadata_model_unittest.html
[modify] https://crrev.com/c1a7078994c97ac791bdd45abec4fdce33900901/ui/file_manager/file_manager/foreground/js/metadata/metadata_parser.js
[add] https://crrev.com/c1a7078994c97ac791bdd45abec4fdce33900901/ui/file_manager/file_manager/foreground/js/metadata/metadata_request.js
[modify] https://crrev.com/c1a7078994c97ac791bdd45abec4fdce33900901/ui/file_manager/file_manager/foreground/js/metadata/mpeg_parser.js
[modify] https://crrev.com/c1a7078994c97ac791bdd45abec4fdce33900901/ui/file_manager/file_manager/foreground/js/metadata/multi_metadata_provider_unittest.html
[modify] https://crrev.com/c1a7078994c97ac791bdd45abec4fdce33900901/ui/file_manager/gallery/js/compiled_resources.gyp
[modify] https://crrev.com/c1a7078994c97ac791bdd45abec4fdce33900901/ui/file_manager/gallery/js/gallery_scripts.js

Project Member

Comment 14 by bugdroid1@chromium.org, Jan 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f37b6ac09bf51be851835295765e1bb18095abb6

commit f37b6ac09bf51be851835295765e1bb18095abb6
Author: oka <oka@chromium.org>
Date: Tue Jan 17 11:42:00 2017

Compile quick_view_model with closure compiler v2.

BUG= 636289 
TEST=run_compiler.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2631413002
Cr-Commit-Position: refs/heads/master@{#444029}

[modify] https://crrev.com/f37b6ac09bf51be851835295765e1bb18095abb6/ui/file_manager/file_manager/foreground/js/compiled_resources2.gyp

Project Member

Comment 15 by bugdroid1@chromium.org, Jan 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f128c6d887c28cdf75d90413cddf7791c516493c

commit f128c6d887c28cdf75d90413cddf7791c516493c
Author: fukino <fukino@chromium.org>
Date: Wed Jan 18 05:55:30 2017

Files app: Use relative paths to specify compile dependencies in the package.

BUG= 636289 
TEST=run third_party/closure_compiler/run_compiler
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2640643002
Cr-Commit-Position: refs/heads/master@{#444290}

[modify] https://crrev.com/f128c6d887c28cdf75d90413cddf7791c516493c/ui/file_manager/file_manager/common/js/compiled_resources2.gyp
[modify] https://crrev.com/f128c6d887c28cdf75d90413cddf7791c516493c/ui/file_manager/file_manager/foreground/js/metadata/compiled_resources2.gyp

Project Member

Comment 16 by bugdroid1@chromium.org, Jan 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e4d406d50527043c11982d27cb1186a72c0f849

commit 1e4d406d50527043c11982d27cb1186a72c0f849
Author: fukino <fukino@chromium.org>
Date: Wed Jan 18 05:56:43 2017

Compile image loader in v2 syntax.

BUG= 636289 
TEST=run third_party/closure_compiler/run_compiler
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2634213003
Cr-Commit-Position: refs/heads/master@{#444291}

[modify] https://crrev.com/1e4d406d50527043c11982d27cb1186a72c0f849/third_party/closure_compiler/compiled_resources.gyp
[modify] https://crrev.com/1e4d406d50527043c11982d27cb1186a72c0f849/ui/file_manager/compiled_resources2.gyp
[delete] https://crrev.com/f128c6d887c28cdf75d90413cddf7791c516493c/ui/file_manager/image_loader/compiled_resources.gyp
[modify] https://crrev.com/1e4d406d50527043c11982d27cb1186a72c0f849/ui/file_manager/image_loader/compiled_resources2.gyp
[modify] https://crrev.com/1e4d406d50527043c11982d27cb1186a72c0f849/ui/file_manager/image_loader/image_loader.js
[modify] https://crrev.com/1e4d406d50527043c11982d27cb1186a72c0f849/ui/file_manager/image_loader/image_loader_unittest.html
[modify] https://crrev.com/1e4d406d50527043c11982d27cb1186a72c0f849/ui/file_manager/image_loader/image_loader_unittest.js
[add] https://crrev.com/1e4d406d50527043c11982d27cb1186a72c0f849/ui/file_manager/image_loader/image_loader_util.js
[modify] https://crrev.com/1e4d406d50527043c11982d27cb1186a72c0f849/ui/file_manager/image_loader/request.js

Project Member

Comment 17 by bugdroid1@chromium.org, Jan 18 2017

Project Member

Comment 18 by bugdroid1@chromium.org, Jan 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9762587b94da23ce580995d1c7fa6ff7bf456f5

commit e9762587b94da23ce580995d1c7fa6ff7bf456f5
Author: fukino <fukino@chromium.org>
Date: Thu Jan 19 00:51:24 2017

Files app: Fix error of image loader which is caused by missing script.

This change should have been included in https://codereview.chromium.org/2634213003/.
Missing this diff causes the error.

BUG= 682139 , 636289 
TEST=manually tested
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2645533002
Cr-Commit-Position: refs/heads/master@{#444575}

[modify] https://crrev.com/e9762587b94da23ce580995d1c7fa6ff7bf456f5/ui/file_manager/image_loader/background_scripts.js

Project Member

Comment 19 by bugdroid1@chromium.org, Jan 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/adc103db18b8e88402f60b6c0979a55c7f6bc0d5

commit adc103db18b8e88402f60b6c0979a55c7f6bc0d5
Author: oka <oka@chromium.org>
Date: Thu Jan 19 03:48:21 2017

Compile file_manager/common and volume_manager_wrapper in v2 syntax.

Also fixed indent and sort order of random gyp files.

BUG= 636289 
TEST=run_compiler.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2642743006
Cr-Commit-Position: refs/heads/master@{#444630}

[modify] https://crrev.com/adc103db18b8e88402f60b6c0979a55c7f6bc0d5/ui/file_manager/externs/background_window.js
[modify] https://crrev.com/adc103db18b8e88402f60b6c0979a55c7f6bc0d5/ui/file_manager/externs/compiled_resources2.gyp
[add] https://crrev.com/adc103db18b8e88402f60b6c0979a55c7f6bc0d5/ui/file_manager/externs/file_browser_background.js
[modify] https://crrev.com/adc103db18b8e88402f60b6c0979a55c7f6bc0d5/ui/file_manager/file_manager/background/js/compiled_resources.gyp
[modify] https://crrev.com/adc103db18b8e88402f60b6c0979a55c7f6bc0d5/ui/file_manager/file_manager/background/js/media_scanner.js
[modify] https://crrev.com/adc103db18b8e88402f60b6c0979a55c7f6bc0d5/ui/file_manager/file_manager/common/js/compiled_resources2.gyp
[modify] https://crrev.com/adc103db18b8e88402f60b6c0979a55c7f6bc0d5/ui/file_manager/file_manager/common/js/importer_common.js
[modify] https://crrev.com/adc103db18b8e88402f60b6c0979a55c7f6bc0d5/ui/file_manager/file_manager/foreground/js/compiled_resources.gyp
[modify] https://crrev.com/adc103db18b8e88402f60b6c0979a55c7f6bc0d5/ui/file_manager/file_manager/foreground/js/compiled_resources2.gyp

Comment 21 by oka@chromium.org, Feb 1 2017

Owner: oka@chromium.org

Comment 22 by oka@chromium.org, Feb 1 2017

Cc: fukino@chromium.org
Project Member

Comment 24 by bugdroid1@chromium.org, Feb 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f9e4d69ac5649f7c5b842fbf271b9c2650aef44

commit 9f9e4d69ac5649f7c5b842fbf271b9c2650aef44
Author: oka <oka@chromium.org>
Date: Thu Feb 23 08:08:46 2017

Compile several targets in Gallery in gyp v2.

Renamed ImageUtil.metrics to metrics so that metrics users don't necessarily
depend on ImageUtil.
Split ImageLoader from image_util.js into a separated file.
Added externs/gallery_event.js to compile ribbon.js.

BUG= 636289 
TEST=run_compiler, git cl try
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2678723002
Cr-Commit-Position: refs/heads/master@{#452430}

[modify] https://crrev.com/9f9e4d69ac5649f7c5b842fbf271b9c2650aef44/ui/file_manager/compiled_resources2.gyp
[modify] https://crrev.com/9f9e4d69ac5649f7c5b842fbf271b9c2650aef44/ui/file_manager/externs/compiled_resources2.gyp
[add] https://crrev.com/9f9e4d69ac5649f7c5b842fbf271b9c2650aef44/ui/file_manager/externs/gallery_event.js
[modify] https://crrev.com/9f9e4d69ac5649f7c5b842fbf271b9c2650aef44/ui/file_manager/file_manager/foreground/js/compiled_resources2.gyp
[modify] https://crrev.com/9f9e4d69ac5649f7c5b842fbf271b9c2650aef44/ui/file_manager/gallery/js/compiled_resources.gyp
[modify] https://crrev.com/9f9e4d69ac5649f7c5b842fbf271b9c2650aef44/ui/file_manager/gallery/js/compiled_resources2.gyp
[modify] https://crrev.com/9f9e4d69ac5649f7c5b842fbf271b9c2650aef44/ui/file_manager/gallery/js/gallery.js
[modify] https://crrev.com/9f9e4d69ac5649f7c5b842fbf271b9c2650aef44/ui/file_manager/gallery/js/gallery_data_model.js
[modify] https://crrev.com/9f9e4d69ac5649f7c5b842fbf271b9c2650aef44/ui/file_manager/gallery/js/gallery_item.js
[modify] https://crrev.com/9f9e4d69ac5649f7c5b842fbf271b9c2650aef44/ui/file_manager/gallery/js/gallery_item_unittest.js
[modify] https://crrev.com/9f9e4d69ac5649f7c5b842fbf271b9c2650aef44/ui/file_manager/gallery/js/gallery_scripts.js
[modify] https://crrev.com/9f9e4d69ac5649f7c5b842fbf271b9c2650aef44/ui/file_manager/gallery/js/image_editor/compiled_resources2.gyp
[modify] https://crrev.com/9f9e4d69ac5649f7c5b842fbf271b9c2650aef44/ui/file_manager/gallery/js/image_editor/image_editor.js
[add] https://crrev.com/9f9e4d69ac5649f7c5b842fbf271b9c2650aef44/ui/file_manager/gallery/js/image_editor/image_loader.js
[modify] https://crrev.com/9f9e4d69ac5649f7c5b842fbf271b9c2650aef44/ui/file_manager/gallery/js/image_editor/image_util.js
[modify] https://crrev.com/9f9e4d69ac5649f7c5b842fbf271b9c2650aef44/ui/file_manager/gallery/js/image_editor/image_view.js
[modify] https://crrev.com/9f9e4d69ac5649f7c5b842fbf271b9c2650aef44/ui/file_manager/gallery/js/slide_mode.js
[modify] https://crrev.com/9f9e4d69ac5649f7c5b842fbf271b9c2650aef44/ui/webui/resources/js/cr/ui/compiled_resources2.gyp

Project Member

Comment 25 by bugdroid1@chromium.org, Feb 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9c3dc95e104c9b8284652b05e649cc17a14cd1c

commit f9c3dc95e104c9b8284652b05e649cc17a14cd1c
Author: oka <oka@chromium.org>
Date: Fri Feb 24 06:06:05 2017

Compile more Gallery targets in gyp v2.

BUG= 636289 
TEST=run_compiler. Manually confirmed Gallery show images as before.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2702403008
Cr-Commit-Position: refs/heads/master@{#452769}

[modify] https://crrev.com/f9c3dc95e104c9b8284652b05e649cc17a14cd1c/ui/file_manager/gallery/js/compiled_resources.gyp
[modify] https://crrev.com/f9c3dc95e104c9b8284652b05e649cc17a14cd1c/ui/file_manager/gallery/js/compiled_resources2.gyp
[modify] https://crrev.com/f9c3dc95e104c9b8284652b05e649cc17a14cd1c/ui/file_manager/gallery/js/dimmable_ui_controller.js
[modify] https://crrev.com/f9c3dc95e104c9b8284652b05e649cc17a14cd1c/ui/file_manager/gallery/js/dimmable_ui_controller_unittest.html
[modify] https://crrev.com/f9c3dc95e104c9b8284652b05e649cc17a14cd1c/ui/file_manager/gallery/js/dimmable_ui_controller_unittest.js
[modify] https://crrev.com/f9c3dc95e104c9b8284652b05e649cc17a14cd1c/ui/file_manager/gallery/js/gallery.js
[add] https://crrev.com/f9c3dc95e104c9b8284652b05e649cc17a14cd1c/ui/file_manager/gallery/js/gallery_constants.js
[modify] https://crrev.com/f9c3dc95e104c9b8284652b05e649cc17a14cd1c/ui/file_manager/gallery/js/gallery_scripts.js
[modify] https://crrev.com/f9c3dc95e104c9b8284652b05e649cc17a14cd1c/ui/file_manager/gallery/js/image_editor/compiled_resources2.gyp
[modify] https://crrev.com/f9c3dc95e104c9b8284652b05e649cc17a14cd1c/ui/file_manager/gallery/js/image_editor/test_util.js
[modify] https://crrev.com/f9c3dc95e104c9b8284652b05e649cc17a14cd1c/ui/file_manager/gallery/js/slide_mode.js
[modify] https://crrev.com/f9c3dc95e104c9b8284652b05e649cc17a14cd1c/ui/file_manager/gallery/js/thumbnail_mode.js

Project Member

Comment 26 by bugdroid1@chromium.org, Mar 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/734113c8b134ef9738d2e2f2287b01fd9e2243bd

commit 734113c8b134ef9738d2e2f2287b01fd9e2243bd
Author: oka <oka@chromium.org>
Date: Thu Mar 02 04:35:33 2017

Compile more Gallery targets in gyp v2.

BUG= 636289 
TEST=run_compiler.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2717653002
Cr-Commit-Position: refs/heads/master@{#454179}

[modify] https://crrev.com/734113c8b134ef9738d2e2f2287b01fd9e2243bd/ui/file_manager/externs/platform.js
[modify] https://crrev.com/734113c8b134ef9738d2e2f2287b01fd9e2243bd/ui/file_manager/file_manager/foreground/js/compiled_resources.gyp
[modify] https://crrev.com/734113c8b134ef9738d2e2f2287b01fd9e2243bd/ui/file_manager/gallery/js/compiled_resources.gyp
[modify] https://crrev.com/734113c8b134ef9738d2e2f2287b01fd9e2243bd/ui/file_manager/gallery/js/compiled_resources2.gyp
[modify] https://crrev.com/734113c8b134ef9738d2e2f2287b01fd9e2243bd/ui/file_manager/gallery/js/gallery.js
[modify] https://crrev.com/734113c8b134ef9738d2e2f2287b01fd9e2243bd/ui/file_manager/gallery/js/gallery_scripts.js
[modify] https://crrev.com/734113c8b134ef9738d2e2f2287b01fd9e2243bd/ui/file_manager/gallery/js/image_editor/commands.js
[modify] https://crrev.com/734113c8b134ef9738d2e2f2287b01fd9e2243bd/ui/file_manager/gallery/js/image_editor/compiled_resources2.gyp
[modify] https://crrev.com/734113c8b134ef9738d2e2f2287b01fd9e2243bd/ui/file_manager/gallery/js/image_editor/image_editor.js
[add] https://crrev.com/734113c8b134ef9738d2e2f2287b01fd9e2243bd/ui/file_manager/gallery/js/image_editor/image_editor_prompt.js
[modify] https://crrev.com/734113c8b134ef9738d2e2f2287b01fd9e2243bd/ui/file_manager/gallery/js/slide_mode.js

Project Member

Comment 27 by bugdroid1@chromium.org, Mar 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a5347c7133cb9b84a9c9801ca307343ed3ed4947

commit a5347c7133cb9b84a9c9801ca307343ed3ed4947
Author: oka <oka@chromium.org>
Date: Tue Mar 07 09:54:54 2017

Compile Image Editor in gyp v2

Renamed ImageEditor.Mode to ImageEditorMode and extracted the file for this.
Renamed ImageEditor.Toolbar to ImageEditorToolbar and extracted the file for this.
Removed dependency from ImageEditorMode to ImageEditor:
- registerAction_ and modeToolbar_.reset are called by ImageEditor instead of ImageEditor.Mode.
- arguments for ImageEditorMode.prototype.bind is changed not to take ImageEditor.
Formatted the edited code with `git cl format --js`.

BUG= 636289 
TEST=run_compiler.
- manually tested image edits can be done without errors.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2727353004
Cr-Commit-Position: refs/heads/master@{#455053}

[modify] https://crrev.com/a5347c7133cb9b84a9c9801ca307343ed3ed4947/ui/file_manager/file_manager/foreground/js/ui/compiled_resources2.gyp
[modify] https://crrev.com/a5347c7133cb9b84a9c9801ca307343ed3ed4947/ui/file_manager/gallery/js/compiled_resources.gyp
[modify] https://crrev.com/a5347c7133cb9b84a9c9801ca307343ed3ed4947/ui/file_manager/gallery/js/compiled_resources2.gyp
[modify] https://crrev.com/a5347c7133cb9b84a9c9801ca307343ed3ed4947/ui/file_manager/gallery/js/gallery_scripts.js
[modify] https://crrev.com/a5347c7133cb9b84a9c9801ca307343ed3ed4947/ui/file_manager/gallery/js/image_editor/compiled_resources2.gyp
[modify] https://crrev.com/a5347c7133cb9b84a9c9801ca307343ed3ed4947/ui/file_manager/gallery/js/image_editor/image_adjust.js
[modify] https://crrev.com/a5347c7133cb9b84a9c9801ca307343ed3ed4947/ui/file_manager/gallery/js/image_editor/image_editor.js
[add] https://crrev.com/a5347c7133cb9b84a9c9801ca307343ed3ed4947/ui/file_manager/gallery/js/image_editor/image_editor_mode.js
[add] https://crrev.com/a5347c7133cb9b84a9c9801ca307343ed3ed4947/ui/file_manager/gallery/js/image_editor/image_editor_toolbar.js
[modify] https://crrev.com/a5347c7133cb9b84a9c9801ca307343ed3ed4947/ui/file_manager/gallery/js/image_editor/image_resize.js
[modify] https://crrev.com/a5347c7133cb9b84a9c9801ca307343ed3ed4947/ui/file_manager/gallery/js/image_editor/image_transform.js
[modify] https://crrev.com/a5347c7133cb9b84a9c9801ca307343ed3ed4947/ui/file_manager/gallery/js/slide_mode.js
[modify] https://crrev.com/a5347c7133cb9b84a9c9801ca307343ed3ed4947/ui/file_manager/gallery/js/slide_mode_unittest.html
[modify] https://crrev.com/a5347c7133cb9b84a9c9801ca307343ed3ed4947/ui/file_manager/gallery/js/thumbnail_mode.js
[modify] https://crrev.com/a5347c7133cb9b84a9c9801ca307343ed3ed4947/ui/webui/resources/js/cr/ui/compiled_resources2.gyp

Comment 29 by oka@chromium.org, Mar 13 2017

Blockedon: 700825
Project Member

Comment 30 by bugdroid1@chromium.org, Mar 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a50545b9d3795b3902d9e0b12f0a30b94078a3b9

commit a50545b9d3795b3902d9e0b12f0a30b94078a3b9
Author: oka <oka@chromium.org>
Date: Thu Mar 16 16:05:18 2017

Compile folder_shotcuts_data_model in gyp v2.

BUG= 636289 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2751763004
Cr-Commit-Position: refs/heads/master@{#457451}

[modify] https://crrev.com/a50545b9d3795b3902d9e0b12f0a30b94078a3b9/ui/file_manager/file_manager/foreground/js/compiled_resources2.gyp
[modify] https://crrev.com/a50545b9d3795b3902d9e0b12f0a30b94078a3b9/ui/file_manager/file_manager/foreground/js/ui/compiled_resources2.gyp

Project Member

Comment 31 by bugdroid1@chromium.org, Mar 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9eb8ddc9e622f838f41b38abad84e4a0dc146bdf

commit 9eb8ddc9e622f838f41b38abad84e4a0dc146bdf
Author: oka <oka@chromium.org>
Date: Fri Mar 24 02:59:39 2017

Compile targets in foreground/js/ui unconditionally

BUG= 636289 
Test=run_compiler
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2766313004
Cr-Commit-Position: refs/heads/master@{#459346}

[modify] https://crrev.com/9eb8ddc9e622f838f41b38abad84e4a0dc146bdf/ui/file_manager/compiled_resources2.gyp
[modify] https://crrev.com/9eb8ddc9e622f838f41b38abad84e4a0dc146bdf/ui/file_manager/file_manager/foreground/js/ui/compiled_resources2.gyp

Project Member

Comment 32 by bugdroid1@chromium.org, Mar 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b3e59c4efa72120f82d4f67d7097fab634d6157f

commit b3e59c4efa72120f82d4f67d7097fab634d6157f
Author: oka <oka@chromium.org>
Date: Fri Mar 24 05:39:43 2017

Compile more targets in foreground/js/ui in gyp v2

BUG= 636289 
TEST=run_compiler
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2776623002
Cr-Commit-Position: refs/heads/master@{#459366}

[modify] https://crrev.com/b3e59c4efa72120f82d4f67d7097fab634d6157f/ui/file_manager/file_manager/foreground/js/ui/compiled_resources2.gyp

Project Member

Comment 33 by bugdroid1@chromium.org, Mar 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/026cead1b2ff13a78bc044c62efd63b8efb0041e

commit 026cead1b2ff13a78bc044c62efd63b8efb0041e
Author: oka <oka@chromium.org>
Date: Fri Mar 24 06:24:38 2017

Compile more targets in foreground/js/ui in gyp v2 (2)

BUG= 636289 
TEST=run_compiler
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2775743002
Cr-Commit-Position: refs/heads/master@{#459371}

[modify] https://crrev.com/026cead1b2ff13a78bc044c62efd63b8efb0041e/ui/file_manager/file_manager/foreground/js/ui/compiled_resources2.gyp

Project Member

Comment 35 by bugdroid1@chromium.org, Mar 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/154c7e0df334aae1e1e78b808da5d49cfcf5ed4c

commit 154c7e0df334aae1e1e78b808da5d49cfcf5ed4c
Author: kolos <kolos@chromium.org>
Date: Mon Mar 27 09:24:08 2017

Revert of Compile more targets in foreground/js/ui in gyp v2 (3) (patchset #5 id:80001 of https://codereview.chromium.org/2773873003/ )

Reason for revert:
It probably caused closing tree.

Original issue's description:
> Compile more targets in foreground/js/ui in gyp v2 (3)
>
> BUG= 636289 
> TEST=run_compiler
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
>
> Review-Url: https://codereview.chromium.org/2773873003
> Cr-Commit-Position: refs/heads/master@{#459717}
> Committed: https://chromium.googlesource.com/chromium/src/+/00dda6dbc09aa8a14805cbba3d78b5b1569620ca

TBR=dbeam@chromium.org,fukino@chromium.org,oka@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 636289 

Review-Url: https://codereview.chromium.org/2772223002
Cr-Commit-Position: refs/heads/master@{#459729}

[modify] https://crrev.com/154c7e0df334aae1e1e78b808da5d49cfcf5ed4c/ui/file_manager/externs/compiled_resources2.gyp
[delete] https://crrev.com/a299a05414fc647524bf1da64fa2b058e5915d69/ui/file_manager/externs/drag_target.js
[modify] https://crrev.com/154c7e0df334aae1e1e78b808da5d49cfcf5ed4c/ui/file_manager/file_manager/foreground/js/compiled_resources.gyp
[modify] https://crrev.com/154c7e0df334aae1e1e78b808da5d49cfcf5ed4c/ui/file_manager/file_manager/foreground/js/ui/compiled_resources2.gyp
[modify] https://crrev.com/154c7e0df334aae1e1e78b808da5d49cfcf5ed4c/ui/file_manager/file_manager/foreground/js/ui/drag_selector.js
[modify] https://crrev.com/154c7e0df334aae1e1e78b808da5d49cfcf5ed4c/ui/webui/resources/js/cr/ui/compiled_resources2.gyp

Project Member

Comment 36 by bugdroid1@chromium.org, Mar 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3f99551f1cbc6cd881574f55d03577f5c9adc09

commit a3f99551f1cbc6cd881574f55d03577f5c9adc09
Author: oka <oka@chromium.org>
Date: Mon Mar 27 13:14:14 2017

Reland of Compile more targets in foreground/js/ui in gyp v2 (3) (patchset #1 id:1 of https://codereview.chromium.org/2772223002/ )

Reason for revert:
Revert was do to Android breakage, but I believe my CL is not to do with Android. Let me reland.

Original issue's description:
> Revert of Compile more targets in foreground/js/ui in gyp v2 (3) (patchset #5 id:80001 of https://codereview.chromium.org/2773873003/ )
>
> Reason for revert:
> It probably caused closing tree.
>
> Original issue's description:
> > Compile more targets in foreground/js/ui in gyp v2 (3)
> >
> > BUG= 636289 
> > TEST=run_compiler
> > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
> >
> > Review-Url: https://codereview.chromium.org/2773873003
> > Cr-Commit-Position: refs/heads/master@{#459717}
> > Committed: https://chromium.googlesource.com/chromium/src/+/00dda6dbc09aa8a14805cbba3d78b5b1569620ca
>
> TBR=dbeam@chromium.org,fukino@chromium.org,oka@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG= 636289 
>
> Review-Url: https://codereview.chromium.org/2772223002
> Cr-Commit-Position: refs/heads/master@{#459729}
> Committed: https://chromium.googlesource.com/chromium/src/+/154c7e0df334aae1e1e78b808da5d49cfcf5ed4c

TBR=dbeam@chromium.org,fukino@chromium.org,kolos@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 636289 

Review-Url: https://codereview.chromium.org/2775193003
Cr-Commit-Position: refs/heads/master@{#459768}

[modify] https://crrev.com/a3f99551f1cbc6cd881574f55d03577f5c9adc09/ui/file_manager/externs/compiled_resources2.gyp
[add] https://crrev.com/a3f99551f1cbc6cd881574f55d03577f5c9adc09/ui/file_manager/externs/drag_target.js
[modify] https://crrev.com/a3f99551f1cbc6cd881574f55d03577f5c9adc09/ui/file_manager/file_manager/foreground/js/compiled_resources.gyp
[modify] https://crrev.com/a3f99551f1cbc6cd881574f55d03577f5c9adc09/ui/file_manager/file_manager/foreground/js/ui/compiled_resources2.gyp
[modify] https://crrev.com/a3f99551f1cbc6cd881574f55d03577f5c9adc09/ui/file_manager/file_manager/foreground/js/ui/drag_selector.js
[modify] https://crrev.com/a3f99551f1cbc6cd881574f55d03577f5c9adc09/ui/webui/resources/js/cr/ui/compiled_resources2.gyp

Project Member

Comment 37 by bugdroid1@chromium.org, Mar 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c18543914d549e025ef4200e25e09945eac692d

commit 6c18543914d549e025ef4200e25e09945eac692d
Author: oka <oka@chromium.org>
Date: Mon Mar 27 23:04:21 2017

Compile more files app targets in gyp v2 (4)

BUG= 636289 
TEST=run_compiler
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2772843003
Cr-Commit-Position: refs/heads/master@{#459923}

[modify] https://crrev.com/6c18543914d549e025ef4200e25e09945eac692d/ui/file_manager/file_manager/foreground/js/compiled_resources2.gyp
[modify] https://crrev.com/6c18543914d549e025ef4200e25e09945eac692d/ui/file_manager/file_manager/foreground/js/ui/compiled_resources2.gyp

Project Member

Comment 38 by bugdroid1@chromium.org, Mar 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70eb969b7713def48c0a3c865ea3dd0ba8ee1169

commit 70eb969b7713def48c0a3c865ea3dd0ba8ee1169
Author: oka <oka@chromium.org>
Date: Tue Mar 28 01:25:56 2017

Compile more files app targets in gyp v2 (5)

BUG= 636289 
TEST=run_compiler
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2768373003
Cr-Commit-Position: refs/heads/master@{#459968}

[modify] https://crrev.com/70eb969b7713def48c0a3c865ea3dd0ba8ee1169/ui/file_manager/file_manager/foreground/js/compiled_resources2.gyp
[modify] https://crrev.com/70eb969b7713def48c0a3c865ea3dd0ba8ee1169/ui/file_manager/file_manager/foreground/js/ui/compiled_resources2.gyp

Comment 39 by oka@chromium.org, Apr 7 2017

I found files app depends on CWSWidgetContainer, and I need to make it compile first, but it contains circular deps...
Anyway I will work on it.
Project Member

Comment 40 by bugdroid1@chromium.org, Apr 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1fbb3695fde899fe678fbad74fbedaad1ae3242c

commit 1fbb3695fde899fe678fbad74fbedaad1ae3242c
Author: oka <oka@chromium.org>
Date: Sat Apr 08 11:35:08 2017

Compile suggest_app_dialog in gyp v2

- Extracted needed utility functions and constants into constants.js
and web_store_utils.js
- Compiled cws_widget, which is used by SuggetAppDialog, removing the circular
dependency between app_installer and cws_widget_container by extracting
a delegator definition into a separate file.

BUG= 636289 
TEST=closure_compiler, try
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2805853002
Cr-Commit-Position: refs/heads/master@{#463131}

[modify] https://crrev.com/1fbb3695fde899fe678fbad74fbedaad1ae3242c/components/chrome_apps/webstore_widget/app/main.js
[modify] https://crrev.com/1fbb3695fde899fe678fbad74fbedaad1ae3242c/components/chrome_apps/webstore_widget/cws_widget/app_installer.js
[modify] https://crrev.com/1fbb3695fde899fe678fbad74fbedaad1ae3242c/components/chrome_apps/webstore_widget/cws_widget/compiled_resources.gypi
[add] https://crrev.com/1fbb3695fde899fe678fbad74fbedaad1ae3242c/components/chrome_apps/webstore_widget/cws_widget/compiled_resources2.gyp
[modify] https://crrev.com/1fbb3695fde899fe678fbad74fbedaad1ae3242c/components/chrome_apps/webstore_widget/cws_widget/cws_webview_client.js
[modify] https://crrev.com/1fbb3695fde899fe678fbad74fbedaad1ae3242c/components/chrome_apps/webstore_widget/cws_widget/cws_widget_container.js
[add] https://crrev.com/1fbb3695fde899fe678fbad74fbedaad1ae3242c/components/chrome_apps/webstore_widget/cws_widget/cws_widget_container_platform_delegate.js
[add] https://crrev.com/1fbb3695fde899fe678fbad74fbedaad1ae3242c/components/chrome_apps/webstore_widget/externs/compiled_resources2.gyp
[modify] https://crrev.com/1fbb3695fde899fe678fbad74fbedaad1ae3242c/components/chrome_apps/webstore_widget/externs/webview_tag.js
[modify] https://crrev.com/1fbb3695fde899fe678fbad74fbedaad1ae3242c/ui/file_manager/file_manager/foreground/js/compiled_resources.gyp
[modify] https://crrev.com/1fbb3695fde899fe678fbad74fbedaad1ae3242c/ui/file_manager/file_manager/foreground/js/compiled_resources2.gyp
[add] https://crrev.com/1fbb3695fde899fe678fbad74fbedaad1ae3242c/ui/file_manager/file_manager/foreground/js/constants.js
[modify] https://crrev.com/1fbb3695fde899fe678fbad74fbedaad1ae3242c/ui/file_manager/file_manager/foreground/js/file_tasks.js
[modify] https://crrev.com/1fbb3695fde899fe678fbad74fbedaad1ae3242c/ui/file_manager/file_manager/foreground/js/file_tasks_unittest.html
[modify] https://crrev.com/1fbb3695fde899fe678fbad74fbedaad1ae3242c/ui/file_manager/file_manager/foreground/js/main_scripts.js
[modify] https://crrev.com/1fbb3695fde899fe678fbad74fbedaad1ae3242c/ui/file_manager/file_manager/foreground/js/ui/compiled_resources2.gyp
[modify] https://crrev.com/1fbb3695fde899fe678fbad74fbedaad1ae3242c/ui/file_manager/file_manager/foreground/js/ui/suggest_apps_dialog.js
[add] https://crrev.com/1fbb3695fde899fe678fbad74fbedaad1ae3242c/ui/file_manager/file_manager/foreground/js/web_store_utils.js

Project Member

Comment 41 by bugdroid1@chromium.org, Apr 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d72f2db0caadf203009ff249b8108daaa4ad8dd

commit 1d72f2db0caadf203009ff249b8108daaa4ad8dd
Author: oka <oka@chromium.org>
Date: Thu Apr 13 08:03:08 2017

Compile file_table_list in gyp v2

To remove circular deps between file_table and file_table_list,
- Moved filelist namespace from file_table to file_table_list.
- Use observer pattern instead of calling
|updateHighPriorityRange| in FileTable from FileTableList.

BUG= 636289 
TEST=run_compiler, try
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2807033002
Cr-Commit-Position: refs/heads/master@{#464336}

[modify] https://crrev.com/1d72f2db0caadf203009ff249b8108daaa4ad8dd/ui/file_manager/file_manager/foreground/js/ui/compiled_resources2.gyp
[modify] https://crrev.com/1d72f2db0caadf203009ff249b8108daaa4ad8dd/ui/file_manager/file_manager/foreground/js/ui/file_table.js
[modify] https://crrev.com/1d72f2db0caadf203009ff249b8108daaa4ad8dd/ui/file_manager/file_manager/foreground/js/ui/file_table_list.js

Project Member

Comment 42 by bugdroid1@chromium.org, Apr 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/25102b38891fb9d46c865a38c8ae04e2660bb6a8

commit 25102b38891fb9d46c865a38c8ae04e2660bb6a8
Author: oka <oka@chromium.org>
Date: Tue Apr 18 01:54:10 2017

Compile more targets in file_manager in gyp v2.

Moved constants *.METADATA_PREFETCH_PROPERTY_NAMES to constants.js
to resolve circular deps.

BUG= 636289 
TEST=run_compiler, try
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2822633004
Cr-Commit-Position: refs/heads/master@{#465095}

[modify] https://crrev.com/25102b38891fb9d46c865a38c8ae04e2660bb6a8/ui/file_manager/file_manager/foreground/js/actions_model.js
[modify] https://crrev.com/25102b38891fb9d46c865a38c8ae04e2660bb6a8/ui/file_manager/file_manager/foreground/js/compiled_resources2.gyp
[modify] https://crrev.com/25102b38891fb9d46c865a38c8ae04e2660bb6a8/ui/file_manager/file_manager/foreground/js/constants.js
[modify] https://crrev.com/25102b38891fb9d46c865a38c8ae04e2660bb6a8/ui/file_manager/file_manager/foreground/js/directory_contents.js
[modify] https://crrev.com/25102b38891fb9d46c865a38c8ae04e2660bb6a8/ui/file_manager/file_manager/foreground/js/file_selection.js
[modify] https://crrev.com/25102b38891fb9d46c865a38c8ae04e2660bb6a8/ui/file_manager/file_manager/foreground/js/file_watcher.js
[modify] https://crrev.com/25102b38891fb9d46c865a38c8ae04e2660bb6a8/ui/file_manager/file_manager/foreground/js/ui/compiled_resources2.gyp
[modify] https://crrev.com/25102b38891fb9d46c865a38c8ae04e2660bb6a8/ui/file_manager/file_manager/foreground/js/ui/list_container.js
[modify] https://crrev.com/25102b38891fb9d46c865a38c8ae04e2660bb6a8/ui/webui/resources/js/cr/ui/compiled_resources2.gyp

Project Member

Comment 44 by bugdroid1@chromium.org, Apr 18 2017

Project Member

Comment 45 by bugdroid1@chromium.org, Apr 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08e2c2a4a4630b46712e0cd1900e15980c8fe203

commit 08e2c2a4a4630b46712e0cd1900e15980c8fe203
Author: dbeam <dbeam@chromium.org>
Date: Tue Apr 18 18:56:46 2017

Fix create_include_gyp.py to support relative paths to include_js.gypi

This is to allow ui/file_manager/externs/compiled_resources2.gyp to be
generated.  This seems like a good idea, as there were a few targets
that no longer actually exist in this file.

R=oka@chromium.org
BUG= 636289 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2826693002
Cr-Commit-Position: refs/heads/master@{#465310}

[modify] https://crrev.com/08e2c2a4a4630b46712e0cd1900e15980c8fe203/third_party/closure_compiler/externs/compiled_resources2.gyp
[modify] https://crrev.com/08e2c2a4a4630b46712e0cd1900e15980c8fe203/third_party/closure_compiler/interfaces/compiled_resources2.gyp
[modify] https://crrev.com/08e2c2a4a4630b46712e0cd1900e15980c8fe203/third_party/closure_compiler/tools/create_include_gyp.py
[modify] https://crrev.com/08e2c2a4a4630b46712e0cd1900e15980c8fe203/ui/file_manager/externs/compiled_resources2.gyp

Project Member

Comment 47 by bugdroid1@chromium.org, Apr 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e5c53812891bbcafe6945f41066381644883954b

commit e5c53812891bbcafe6945f41066381644883954b
Author: oka <oka@chromium.org>
Date: Tue Apr 18 23:41:45 2017

Compile more files app targets in gyp v2

BUG= 636289 
TEST=run_compiler
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2828433002
Cr-Commit-Position: refs/heads/master@{#465424}

[modify] https://crrev.com/e5c53812891bbcafe6945f41066381644883954b/ui/file_manager/file_manager/foreground/js/compiled_resources2.gyp

Project Member

Comment 48 by bugdroid1@chromium.org, Apr 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5fdf6911aa0ae645b60fdbf58e501d550f86fbba

commit 5fdf6911aa0ae645b60fdbf58e501d550f86fbba
Author: oka <oka@chromium.org>
Date: Fri Apr 21 04:05:36 2017

Compile file_selection and some other Files app files in gyp v2

Removed dependency from file_selection to file_manager_commands via
observer pattern, and compiled file_selection.
Also compiles some other targets which depends on file_selection.

BUG= 636289 
TEST=run_compiler. Manually confirmed when selection is changed and
updateFileSelectionAsync_ is called, the commands are updated.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2828633002
Cr-Commit-Position: refs/heads/master@{#466253}

[modify] https://crrev.com/5fdf6911aa0ae645b60fdbf58e501d550f86fbba/ui/file_manager/file_manager/foreground/js/compiled_resources2.gyp
[modify] https://crrev.com/5fdf6911aa0ae645b60fdbf58e501d550f86fbba/ui/file_manager/file_manager/foreground/js/dialog_action_controller.js
[modify] https://crrev.com/5fdf6911aa0ae645b60fdbf58e501d550f86fbba/ui/file_manager/file_manager/foreground/js/file_manager.js
[modify] https://crrev.com/5fdf6911aa0ae645b60fdbf58e501d550f86fbba/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
[modify] https://crrev.com/5fdf6911aa0ae645b60fdbf58e501d550f86fbba/ui/file_manager/file_manager/foreground/js/file_selection.js

Project Member

Comment 49 by bugdroid1@chromium.org, Apr 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cdb8d85e00d3406b80e06c5540791bac335d2176

commit cdb8d85e00d3406b80e06c5540791bac335d2176
Author: oka <oka@chromium.org>
Date: Fri Apr 21 04:45:53 2017

Compile metadata_box_controller and quick_view_controller in gyp v2

BUG= 636289 
TEST=run_compiler
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2825793003
Cr-Commit-Position: refs/heads/master@{#466260}

[modify] https://crrev.com/cdb8d85e00d3406b80e06c5540791bac335d2176/ui/file_manager/file_manager/foreground/js/compiled_resources2.gyp

Project Member

Comment 50 by bugdroid1@chromium.org, Apr 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a09e380ca0d6d41a52d066da4b288dacc29f40e

commit 8a09e380ca0d6d41a52d066da4b288dacc29f40e
Author: oka <oka@chromium.org>
Date: Fri Apr 28 05:54:16 2017

Compile file_transfer_controller in gyp v2

- Removed dependency from file_transfor_controller to CommandHandler by
registering the needed function from FileManager to
FileTransferController as a constructor parameter.
- Added drop_effect_and_label to compile target.

BUG= 636289 
TEST=run_compiler
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2830223003
Cr-Commit-Position: refs/heads/master@{#467912}

[modify] https://crrev.com/8a09e380ca0d6d41a52d066da4b288dacc29f40e/ui/file_manager/file_manager/foreground/js/compiled_resources.gyp
[modify] https://crrev.com/8a09e380ca0d6d41a52d066da4b288dacc29f40e/ui/file_manager/file_manager/foreground/js/compiled_resources2.gyp
[modify] https://crrev.com/8a09e380ca0d6d41a52d066da4b288dacc29f40e/ui/file_manager/file_manager/foreground/js/file_manager.js
[modify] https://crrev.com/8a09e380ca0d6d41a52d066da4b288dacc29f40e/ui/file_manager/file_manager/foreground/js/file_transfer_controller.js
[modify] https://crrev.com/8a09e380ca0d6d41a52d066da4b288dacc29f40e/ui/file_manager/file_manager/foreground/js/main_scripts.js
[add] https://crrev.com/8a09e380ca0d6d41a52d066da4b288dacc29f40e/ui/file_manager/file_manager/foreground/js/webui_command_extender.js

Project Member

Comment 51 by bugdroid1@chromium.org, Apr 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f37aa1b929a74c74350f866e1a2658219a591b5b

commit f37aa1b929a74c74350f866e1a2658219a591b5b
Author: oka <oka@chromium.org>
Date: Fri Apr 28 06:17:39 2017

Compile file_manager_commands in gyp v2.

There were circular deps between file_manager_commands and file_manager.
This change removes dependency from file_manager_commands to
file_manager by extracting an interface from FileManager needed for
file_manager_commands to compile.
Also inlined some simple methods in FileManager, which are used
only from file_manager_commands.

BUG= 636289 
TEST=run_compiler
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2846163002
Cr-Commit-Position: refs/heads/master@{#467917}

[add] https://crrev.com/f37aa1b929a74c74350f866e1a2658219a591b5b/ui/file_manager/externs/command_handler_deps.js
[modify] https://crrev.com/f37aa1b929a74c74350f866e1a2658219a591b5b/ui/file_manager/externs/compiled_resources2.gyp
[modify] https://crrev.com/f37aa1b929a74c74350f866e1a2658219a591b5b/ui/file_manager/file_manager/foreground/js/compiled_resources.gyp
[modify] https://crrev.com/f37aa1b929a74c74350f866e1a2658219a591b5b/ui/file_manager/file_manager/foreground/js/compiled_resources2.gyp
[modify] https://crrev.com/f37aa1b929a74c74350f866e1a2658219a591b5b/ui/file_manager/file_manager/foreground/js/file_manager.js
[modify] https://crrev.com/f37aa1b929a74c74350f866e1a2658219a591b5b/ui/file_manager/file_manager/foreground/js/file_manager_commands.js

Project Member

Comment 52 by bugdroid1@chromium.org, Apr 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc40747b23fee88ab7f819ae697268edf8b6b4ab

commit bc40747b23fee88ab7f819ae697268edf8b6b4ab
Author: oka <oka@chromium.org>
Date: Fri Apr 28 07:59:03 2017

Compile scan_controller and gear_menu_controller in gyp v2

TEST=run_compiler
BUG= 636289 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2852633003
Cr-Commit-Position: refs/heads/master@{#467926}

[modify] https://crrev.com/bc40747b23fee88ab7f819ae697268edf8b6b4ab/ui/file_manager/file_manager/foreground/js/compiled_resources2.gyp

Project Member

Comment 53 by bugdroid1@chromium.org, May 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/303d2fcbe30651217015c0c7cfbfdb3fecf2a16a

commit 303d2fcbe30651217015c0c7cfbfdb3fecf2a16a
Author: oka <oka@chromium.org>
Date: Mon May 01 02:48:17 2017

Compile import_controller in gyp v2

TEST=run_compiler
BUG= 636289 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2846783006
Cr-Commit-Position: refs/heads/master@{#468269}

[modify] https://crrev.com/303d2fcbe30651217015c0c7cfbfdb3fecf2a16a/ui/file_manager/file_manager/foreground/js/compiled_resources2.gyp
[modify] https://crrev.com/303d2fcbe30651217015c0c7cfbfdb3fecf2a16a/ui/file_manager/file_manager/foreground/js/import_controller.js

Project Member

Comment 54 by bugdroid1@chromium.org, May 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/27a05b28ecc1e505a282463337a36d09011b947d

commit 27a05b28ecc1e505a282463337a36d09011b947d
Author: oka <oka@chromium.org>
Date: Wed May 17 15:18:25 2017

Stop foreground depending on background in gyp v2

BUG= 636289 
TEST=run_compiler
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2883263002
Cr-Commit-Position: refs/heads/master@{#472458}

[add] https://crrev.com/27a05b28ecc1e505a282463337a36d09011b947d/ui/file_manager/externs/background/compiled_resources2.gyp
[add] https://crrev.com/27a05b28ecc1e505a282463337a36d09011b947d/ui/file_manager/externs/background/drive_sync_handler.js
[add] https://crrev.com/27a05b28ecc1e505a282463337a36d09011b947d/ui/file_manager/externs/background/file_operation_manager.js
[add] https://crrev.com/27a05b28ecc1e505a282463337a36d09011b947d/ui/file_manager/externs/background/import_runner.js
[add] https://crrev.com/27a05b28ecc1e505a282463337a36d09011b947d/ui/file_manager/externs/background/media_import_handler.js
[add] https://crrev.com/27a05b28ecc1e505a282463337a36d09011b947d/ui/file_manager/externs/background/media_scanner.js
[add] https://crrev.com/27a05b28ecc1e505a282463337a36d09011b947d/ui/file_manager/externs/background/progress_center.js
[rename] https://crrev.com/27a05b28ecc1e505a282463337a36d09011b947d/ui/file_manager/externs/background/volume_manager_factory.js
[modify] https://crrev.com/27a05b28ecc1e505a282463337a36d09011b947d/ui/file_manager/externs/compiled_resources2.gyp
[modify] https://crrev.com/27a05b28ecc1e505a282463337a36d09011b947d/ui/file_manager/file_manager/background/js/compiled_resources2.gyp
[modify] https://crrev.com/27a05b28ecc1e505a282463337a36d09011b947d/ui/file_manager/file_manager/background/js/drive_sync_handler.js
[modify] https://crrev.com/27a05b28ecc1e505a282463337a36d09011b947d/ui/file_manager/file_manager/background/js/media_import_handler.js
[modify] https://crrev.com/27a05b28ecc1e505a282463337a36d09011b947d/ui/file_manager/file_manager/background/js/media_scanner.js
[modify] https://crrev.com/27a05b28ecc1e505a282463337a36d09011b947d/ui/file_manager/file_manager/background/js/progress_center.js
[modify] https://crrev.com/27a05b28ecc1e505a282463337a36d09011b947d/ui/file_manager/file_manager/foreground/js/compiled_resources.gyp
[modify] https://crrev.com/27a05b28ecc1e505a282463337a36d09011b947d/ui/file_manager/file_manager/foreground/js/compiled_resources2.gyp
[modify] https://crrev.com/27a05b28ecc1e505a282463337a36d09011b947d/ui/file_manager/file_manager/foreground/js/file_manager.js
[modify] https://crrev.com/27a05b28ecc1e505a282463337a36d09011b947d/ui/file_manager/file_manager/foreground/js/ui/compiled_resources2.gyp
[modify] https://crrev.com/27a05b28ecc1e505a282463337a36d09011b947d/ui/file_manager/gallery/js/compiled_resources2.gyp

Project Member

Comment 55 by bugdroid1@chromium.org, May 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e7dea2c1da0cb2ec88b3f13a6891db1ee7f7e0a3

commit e7dea2c1da0cb2ec88b3f13a6891db1ee7f7e0a3
Author: oka <oka@chromium.org>
Date: Fri May 19 16:27:57 2017

Compile file_manager and eliminate gyp v1 from Files App!

TEST=run_compiler
BUG= 636289 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2890123003
Cr-Commit-Position: refs/heads/master@{#473210}

[modify] https://crrev.com/e7dea2c1da0cb2ec88b3f13a6891db1ee7f7e0a3/third_party/closure_compiler/compiled_resources.gyp
[modify] https://crrev.com/e7dea2c1da0cb2ec88b3f13a6891db1ee7f7e0a3/ui/file_manager/externs/background/compiled_resources2.gyp
[rename] https://crrev.com/e7dea2c1da0cb2ec88b3f13a6891db1ee7f7e0a3/ui/file_manager/externs/background/file_browser_background.js
[add] https://crrev.com/e7dea2c1da0cb2ec88b3f13a6891db1ee7f7e0a3/ui/file_manager/externs/background/file_browser_background_full.js
[add] https://crrev.com/e7dea2c1da0cb2ec88b3f13a6891db1ee7f7e0a3/ui/file_manager/externs/background/import_history.js
[add] https://crrev.com/e7dea2c1da0cb2ec88b3f13a6891db1ee7f7e0a3/ui/file_manager/externs/background/import_history_enum.js
[modify] https://crrev.com/e7dea2c1da0cb2ec88b3f13a6891db1ee7f7e0a3/ui/file_manager/externs/compiled_resources2.gyp
[modify] https://crrev.com/e7dea2c1da0cb2ec88b3f13a6891db1ee7f7e0a3/ui/file_manager/externs/gallery_foreground.js
[modify] https://crrev.com/e7dea2c1da0cb2ec88b3f13a6891db1ee7f7e0a3/ui/file_manager/file_manager/background/js/background.js
[modify] https://crrev.com/e7dea2c1da0cb2ec88b3f13a6891db1ee7f7e0a3/ui/file_manager/file_manager/background/js/compiled_resources2.gyp
[modify] https://crrev.com/e7dea2c1da0cb2ec88b3f13a6891db1ee7f7e0a3/ui/file_manager/file_manager/background/js/import_history.js
[modify] https://crrev.com/e7dea2c1da0cb2ec88b3f13a6891db1ee7f7e0a3/ui/file_manager/file_manager/background/js/import_history_unittest.js
[modify] https://crrev.com/e7dea2c1da0cb2ec88b3f13a6891db1ee7f7e0a3/ui/file_manager/file_manager/common/js/compiled_resources2.gyp
[delete] https://crrev.com/2e545f253b342d81a9c2c27a83a0d08a1a0ab3ed/ui/file_manager/file_manager/foreground/js/compiled_resources.gyp
[modify] https://crrev.com/e7dea2c1da0cb2ec88b3f13a6891db1ee7f7e0a3/ui/file_manager/file_manager/foreground/js/compiled_resources2.gyp
[modify] https://crrev.com/e7dea2c1da0cb2ec88b3f13a6891db1ee7f7e0a3/ui/file_manager/file_manager/foreground/js/file_manager.js
[modify] https://crrev.com/e7dea2c1da0cb2ec88b3f13a6891db1ee7f7e0a3/ui/file_manager/file_manager/foreground/js/ui/compiled_resources2.gyp

Comment 56 by dbeam@chromium.org, May 19 2017

Status: Fixed (was: Started)

Comment 57 by oka@chromium.org, May 21 2017

yay!

I filed a bug to compile all uncompiled Files app targets for completeness' sake.
 crbug.com/724894 
Project Member

Comment 58 by bugdroid1@chromium.org, Jun 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f31a9f767ad6e5a7be6ba96c920230f2e1e34864

commit f31a9f767ad6e5a7be6ba96c920230f2e1e34864
Author: Keigo Oka <oka@chromium.org>
Date: Wed Jun 07 11:07:57 2017

Remove compile_js.gypi, a remnant of gyp v1.

Bug:  636289 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: If30cacaf87076381a4e74002d9ac41021c4ce92f
Reviewed-on: https://chromium-review.googlesource.com/527017
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Keigo Oka <oka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#477611}
[delete] https://crrev.com/28050dfc93a9ff9de70fcfba4e49aefdfc08d5fc/ui/file_manager/compile_js.gypi

Labels: VerifyIn-61
Labels: code-change
Status: Verified (was: Fixed)

Sign in to add a comment