New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 636288 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Long OOO (go/where-is-mgiuca)
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Feature

Blocking:
issue 635805



Sign in to add a comment

Record stats on navigator.share

Project Member Reported by mgiuca@chromium.org, Aug 10 2016

Issue description

Add UMA:
- UseCounter for per-page API usage stats.
- Total share counter.
- Stats on user acceptance / cancellation.
 
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e419b525a443f33ccc8315783ca7806b2ba8e63a

commit e419b525a443f33ccc8315783ca7806b2ba8e63a
Author: mgiuca <mgiuca@chromium.org>
Date: Thu Sep 08 09:10:11 2016

Rework use counter for navigator.share to use [MeasureAs].

Use automatic functionality instead of manually calling
UseCounter::count.

BUG= 636288 

Review-Url: https://codereview.chromium.org/2250613002
Cr-Commit-Position: refs/heads/master@{#417228}

[modify] https://crrev.com/e419b525a443f33ccc8315783ca7806b2ba8e63a/third_party/WebKit/Source/modules/webshare/NavigatorShare.cpp
[modify] https://crrev.com/e419b525a443f33ccc8315783ca7806b2ba8e63a/third_party/WebKit/Source/modules/webshare/NavigatorShare.idl

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 8 2016

Labels: merge-merged-2854
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e419b525a443f33ccc8315783ca7806b2ba8e63a

commit e419b525a443f33ccc8315783ca7806b2ba8e63a
Author: mgiuca <mgiuca@chromium.org>
Date: Thu Sep 08 09:10:11 2016

Rework use counter for navigator.share to use [MeasureAs].

Use automatic functionality instead of manually calling
UseCounter::count.

BUG= 636288 

Review-Url: https://codereview.chromium.org/2250613002
Cr-Commit-Position: refs/heads/master@{#417228}

[modify] https://crrev.com/e419b525a443f33ccc8315783ca7806b2ba8e63a/third_party/WebKit/Source/modules/webshare/NavigatorShare.cpp
[modify] https://crrev.com/e419b525a443f33ccc8315783ca7806b2ba8e63a/third_party/WebKit/Source/modules/webshare/NavigatorShare.idl

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c39517b04b69a9eb356f913b6b5da3a98f328fcc

commit c39517b04b69a9eb356f913b6b5da3a98f328fcc
Author: mgiuca <mgiuca@chromium.org>
Date: Thu Sep 15 02:25:35 2016

Add detailed histograms for navigator.share.

WebShare.ApiCount is needed (in addition to the existing use counter) to
get the total number of calls to the API, not de-duplicated per page
view.

BUG= 636288 

Review-Url: https://codereview.chromium.org/2228403002
Cr-Commit-Position: refs/heads/master@{#418760}

[modify] https://crrev.com/c39517b04b69a9eb356f913b6b5da3a98f328fcc/chrome/android/java/src/org/chromium/chrome/browser/webshare/ShareServiceImpl.java
[modify] https://crrev.com/c39517b04b69a9eb356f913b6b5da3a98f328fcc/tools/metrics/histograms/histograms.xml

Comment 5 by mgiuca@chromium.org, Sep 15 2016

Status: Fixed (was: Started)

Sign in to add a comment