Regression: [MD Settings] Default focus issue is observed for paper drop down list.
Reported by
dchau...@etouch.net,
Aug 10 2016
|
||||||||
Issue descriptionChrome Version: 53.0.2785.57 (Official Build) eb80524ecf0d2051a03f126ee5e7193a44a02327-refs/branch-heads/2785@{#546} 32/64-bit. OS: Windows (7,8,8.1,10), Mac(10.10.5, 10.11.4), Linux (14.04 LTS). What steps will reproduce the problem? 1. Launch chrome, navigate to chrome://md-settings page and click on 'Advanced' button. 2. Go to 'Languages' section and click on 'Language' iron-icon to expand it. 3. Now, click to open paper drop down list of 'English(United States)' and observe. Default focus doesn't seen on first element (Move down) of paper drop-down list. By default focus should present on first element (Move down) of paper drop-down list. This is a regression issue, broken in M-53 series, below is bisect info. Good build: 53.0.2782.0 Bad build: 53.0.2783.0 Narrow bisect: https://chromium.googlesource.com/chromium/src/+log/6f6c6041185e4b3317c0bc09bc8bda2e0e3f9a9d..3ed22f74673ed1e178ca2bd2ed5d3f5921ef9cb8?pretty=fuller&n=100 Suspecting: r402464 Kindly review the attached screen-cast for reference.
,
Aug 10 2016
Repro steps (see screencast): 1) open any "dots" menu. 2) Hit the down-up arrow keys. The entire page starts to scroll. Did a bisect. Found https://chromium.googlesource.com/chromium/src/+log/52bd4f77244ea34e8bed6266bc19614f2265f448..d7ce54d935656d46f85fcfe201bf84239fa5ce50. The polymer roll at https://chromium.googlesource.com/chromium/src/+/50b83b9580aa7651c854ada2633036b8419b0870 might be the culprit.
,
Aug 15 2016
@dbeam -- what was the desired behavior for focus in dropdowns?
,
Aug 16 2016
,
Aug 16 2016
desired behavior is that up/down change the list item and don't scroll the page i think this is being fixed in Polymer
,
Aug 16 2016
For the Language section, I noticed each "dots" menu is a paper-icon-button with an iron-dropdown as siblings. I'd suggest to use paper-listbox or paper-menu as container of the selection elements (the <button class="dropdown-item">), since this element will handle the arrow keys and call preventDefault when the selection changes.
,
Sep 20 2016
Moe: any spare cycles to look into this? comment #6 from valdrin@ has concrete suggestions of how we might improve here.
,
Sep 20 2016
Sure thing. I should be able to free up some cycles later this week. will look into this.
,
Sep 23 2016
,
Sep 23 2016
dbeam@, since comment #6 the implementation of the three dot menu has changed to use cr-shared-menu. cr-shared-menu handles tabbing through focusable elements and supports focus wrapping which is different from paper-listbox or paper-menu with do the same with the up/down arrow keys. Is the latter the preferred behavior? As for the original bug this issue was opened for and what dpapad@ brought up in comment #2, both are fixed. (although the menu uses a fixed position and scrolling outside of it will cause it to stay in one spot while the page scrolls. But I think we're already aware of that)
,
Oct 13 2016
Focus issues will be addressed as part of https://bugs.chromium.org/p/chromium/issues/detail?id=639718. Assigning to myself.
,
Oct 21 2016
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by mahmadi@chromium.org
, Aug 10 2016Owner: dpa...@chromium.org