New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 636271 link

Starred by 4 users
Status: Fixed
Owner:
wangxianzhu@chromium.org
Closed: Apr 2017
Cc:
█ wkorman@chromium.org
vmp...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Layout Test fast/repaint/resize-iframe-text.html is flaky

Project Member Reported by foolip@chromium.org, Aug 10 2016 
The following layout test is flaky on Mac10.10

fast/repaint/resize-iframe-text.html

Probable cause:

When it fails, it looks like the resize hasn't finished. This isn't the same as the problems yesterday in  issue 635892 .

Could this indicate that the code really isn't working on Mac? Not sure, setting P2 as a compromise.

Comment 1 by foolip@chromium.org, Aug 10 2016 

Test added with  issue 633869 .
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/12ee9251fb9f0745f1273b228c10cdd3308b1a12

commit 12ee9251fb9f0745f1273b228c10cdd3308b1a12
Author: Philip Jägenstedt <foolip@chromium.org>
Date: Wed Aug 10 08:31:40 2016

Mark fast/repaint/resize-iframe-text.html as flaky on Mac10.10

BUG= 636271 , 633869 
TBR=wkorman@chromium.org,chrishtr@chromium.org

Review URL: https://codereview.chromium.org/2230153002 .

Cr-Commit-Position: refs/heads/master@{#411005}

[modify] https://crrev.com/12ee9251fb9f0745f1273b228c10cdd3308b1a12/third_party/WebKit/LayoutTests/TestExpectations
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76da73779963edf41bd7775000f4c04ce37f9f13

commit 76da73779963edf41bd7775000f4c04ce37f9f13
Author: Philip Jägenstedt <foolip@chromium.org>
Date: Wed Aug 10 08:42:00 2016

Fix crbug link for fast/repaint/resize-iframe-text.html flake

BUG= 636271 
TBR=wkorman@chromium.org

Review URL: https://codereview.chromium.org/2230843002 .

Cr-Commit-Position: refs/heads/master@{#411009}

[modify] https://crrev.com/76da73779963edf41bd7775000f4c04ce37f9f13/third_party/WebKit/LayoutTests/TestExpectations

Comment 4 by wkorman@chromium.org, Aug 10 2016 

Thanks for fielding and sorry for the issue with this test. It uses a legacy method for resizing, so it may just be flawed on Mac. I will follow up.

Comment 5 by trchen@chromium.org, Aug 12 2016

Cc: trchen@chromium.org
FYI I'm reverting a CL of mine that affected layout timing in a subtle way: https://codereview.chromium.org/2229303002/

It seems to turn Linux version of the test to flake or always fail. I'm not sure what is the right expectation here so marked it as flake for Linux too.

Comment 6 by wkorman@chromium.org, Aug 12 2016 

Thanks, I tried applying your revert patch and fast/repaint/resize-iframe-text.html still crashes on Mac. However possible your patch could explain some of the other flakes I am looking into in  http://crbug.com/637245 .
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a407f4a1da30918c38a9e54312b7d58338221ce9

commit a407f4a1da30918c38a9e54312b7d58338221ce9
Author: hiroshige <hiroshige@chromium.org>
Date: Mon Aug 15 08:04:14 2016

Mark fast/repaint/resize-iframe-text.html as flaky on all Mac

The test is failing on all Mac bots, not only on Mac10.10.

BUG= 636271 
TBR=wkorman@chromium.org

Review-Url: https://codereview.chromium.org/2248623002
Cr-Commit-Position: refs/heads/master@{#411946}

[modify] https://crrev.com/a407f4a1da30918c38a9e54312b7d58338221ce9/third_party/WebKit/LayoutTests/TestExpectations
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3bc6c4619f272fb08cb4ca1520b4f20bf2cd9ee8

commit 3bc6c4619f272fb08cb4ca1520b4f20bf2cd9ee8
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Fri Dec 02 22:14:43 2016

Manually rebaseline some paint/invalidation tests

For  bug 636271 , rebaseline the test to produce new format, but still
keep the failure line in case it's still flaky.

For  bug 658605 , NeedsRebaseline didn't work because of  bug 660580 .
Manually rebaseline it to ensure test coverage.

BUG= 636271 , 658605 

Review-Url: https://codereview.chromium.org/2543073004
Cr-Commit-Position: refs/heads/master@{#436047}

[modify] https://crrev.com/3bc6c4619f272fb08cb4ca1520b4f20bf2cd9ee8/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/3bc6c4619f272fb08cb4ca1520b4f20bf2cd9ee8/third_party/WebKit/LayoutTests/paint/invalidation/flexbox/scrollbars-changed-expected.txt
[modify] https://crrev.com/3bc6c4619f272fb08cb4ca1520b4f20bf2cd9ee8/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/multicol-repaint-expected.txt
[modify] https://crrev.com/3bc6c4619f272fb08cb4ca1520b4f20bf2cd9ee8/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/resize-iframe-text-expected.png
[modify] https://crrev.com/3bc6c4619f272fb08cb4ca1520b4f20bf2cd9ee8/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/resize-iframe-text-expected.txt
[delete] https://crrev.com/c0dc6f499d681885a9fd7bea1aac680e0b8ac716/third_party/WebKit/LayoutTests/platform/mac-mac10.10/paint/invalidation/resize-iframe-text-expected.png
[delete] https://crrev.com/c0dc6f499d681885a9fd7bea1aac680e0b8ac716/third_party/WebKit/LayoutTests/platform/mac-mac10.10/paint/invalidation/resize-iframe-text-expected.txt
[modify] https://crrev.com/3bc6c4619f272fb08cb4ca1520b4f20bf2cd9ee8/third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/resize-iframe-text-expected.png
[modify] https://crrev.com/3bc6c4619f272fb08cb4ca1520b4f20bf2cd9ee8/third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/resize-iframe-text-expected.txt
[modify] https://crrev.com/3bc6c4619f272fb08cb4ca1520b4f20bf2cd9ee8/third_party/WebKit/LayoutTests/platform/mac-retina/paint/invalidation/resize-iframe-text-expected.png
[modify] https://crrev.com/3bc6c4619f272fb08cb4ca1520b4f20bf2cd9ee8/third_party/WebKit/LayoutTests/platform/mac-retina/paint/invalidation/resize-iframe-text-expected.txt
[modify] https://crrev.com/3bc6c4619f272fb08cb4ca1520b4f20bf2cd9ee8/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/multicol-repaint-expected.txt
[modify] https://crrev.com/3bc6c4619f272fb08cb4ca1520b4f20bf2cd9ee8/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/resize-iframe-text-expected.png
[modify] https://crrev.com/3bc6c4619f272fb08cb4ca1520b4f20bf2cd9ee8/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/resize-iframe-text-expected.txt
[modify] https://crrev.com/3bc6c4619f272fb08cb4ca1520b4f20bf2cd9ee8/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/multicol-repaint-expected.txt
[modify] https://crrev.com/3bc6c4619f272fb08cb4ca1520b4f20bf2cd9ee8/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/resize-iframe-text-expected.png
[modify] https://crrev.com/3bc6c4619f272fb08cb4ca1520b4f20bf2cd9ee8/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/resize-iframe-text-expected.txt
Project Member

Comment 9 by bugdroid1@chromium.org, Dec 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/afb4c35bc27ef50fd833d6724b1ffbb5453f4d3e

commit afb4c35bc27ef50fd833d6724b1ffbb5453f4d3e
Author: yhirano <yhirano@chromium.org>
Date: Fri Dec 09 02:37:15 2016

Mark paint/invalidation/resize-iframe-text.html as failing on Mac

BUG= 636271 ,  672676 
NOTRY=true
TBR=asargent@chromium.org, grt@chromium.org, vasilii@chromium.org

Review-Url: https://codereview.chromium.org/2561283002
Cr-Commit-Position: refs/heads/master@{#437442}

[modify] https://crrev.com/afb4c35bc27ef50fd833d6724b1ffbb5453f4d3e/third_party/WebKit/LayoutTests/TestExpectations

Comment 10 by wangxianzhu@chromium.org, Jan 17 2017

Cc: meade@chromium.org ccameron@chromium.org pkalinnikov@chromium.org wangxianzhu@chromium.org
 Issue 681878  has been merged into this issue.
Project Member

Comment 11 by bugdroid1@chromium.org, Jan 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f33383d68895fb7d446216311026b6028fb8cd3e

commit f33383d68895fb7d446216311026b6028fb8cd3e
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Tue Jan 17 18:41:18 2017

Mark paint/invalidation/resize-iframe-text.html flaky on all mac

BUG= 636271 
NOTRY=true
TBR=wangxianzhu@chromium.org

Review-Url: https://codereview.chromium.org/2636003003
Cr-Commit-Position: refs/heads/master@{#444098}

[modify] https://crrev.com/f33383d68895fb7d446216311026b6028fb8cd3e/third_party/WebKit/LayoutTests/TestExpectations

Comment 12 by meade@chromium.org, Jan 17 2017 

 Issue 681838  has been merged into this issue.

Comment 13 by wangxianzhu@chromium.org, Jan 20 2017

Cc: wkorman@chromium.org
Owner: wangxianzhu@chromium.org
Just reproduced the failure on Linux (remote desktop in Chrome). It seems that window.resize() is restricted by the screen size, so sometimes we don't get the desired window size.

I also encountered this before for the paint/invalidation/window-resize-*.html tests, and fixed that by using smaller window sizes. Will try the same for this test.
Project Member

Comment 14 by bugdroid1@chromium.org, Jan 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b21dc4436ac177d6b61ceccce517efce44cc9919

commit b21dc4436ac177d6b61ceccce517efce44cc9919
Author: kjellander <kjellander@chromium.org>
Date: Thu Jan 26 13:15:32 2017

Update expectation for virtual/stable/paint/invalidation/resize-iframe-text.html

The test can also crash so update expectations for that.
Example: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29/builds/7091

BUG= 636271 
NOTRY=true
TBR=wangxianzhu@chromium.org

Review-Url: https://codereview.chromium.org/2654223003
Cr-Commit-Position: refs/heads/master@{#446312}

[modify] https://crrev.com/b21dc4436ac177d6b61ceccce517efce44cc9919/third_party/WebKit/LayoutTests/TestExpectations

Comment 15 by wangxianzhu@chromium.org, Jan 26 2017

Cc: -trchen@chromium.org -meade@chromium.org -ccameron@chromium.org -pkalinnikov@chromium.org -chrishtr@chromium.org -wkorman@chromium.org
Owner: wkorman@chromium.org
The #14 crash should be unrelated. It seems a occasional random issue that might happen in every layout test.

Tried to fix the flake by reducing the window size. However, I couldn't make the test fail with the original code change reverted.

Assigning back to wkorman@ to determine if we could modify the test to make it work and stable, or just remove the test.

Comment 16 by wangxianzhu@chromium.org, Mar 6 2017

Cc: -wangxianzhu@chromium.org wkorman@chromium.org
Owner: wangxianzhu@chromium.org
This test just became interesting after we landed https://codereview.chromium.org/2702883002/. I encountered crash when I added a visual rect update check in PaintInvalidator.cpp and I need to fix it in my CL.
Project Member

Comment 17 by bugdroid1@chromium.org, Mar 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c0032c9ca74bd03925a7367f4482e4ec6f06278

commit 2c0032c9ca74bd03925a7367f4482e4ec6f06278
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Tue Mar 07 22:48:10 2017

Add check for missing visual rect updates and fix failures

Check if visual rect will change when an object is walked during
PrePaintTreeWalk but the object is not marked for checking paint
invalidation.

Found and fixed several issues:
- when a frame is relocated,set the LayoutView mayNeedPaintInvalidation().
- For clip change detection, we should not reset
  ancestorTransformedOrRootPaintLayer on sub frames.
- For SPv2, computeLocationInBacking() should just return paintOffset
  because the "backing" is the enclosing transform node.
- When LayoutTable's visual rect changes, we should check for paint
  invalidation of all LayoutTableCols which use LayoutTable's
  localVisualRect() as theirs.
- Don't inflate for filter if the filter is on a composited layer.

Also fixed flakiness of paint/invalidation/resize-iframe-text.html
(which discovered the clip change detection issue).

BUG= 636271 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2733773004
Cr-Commit-Position: refs/heads/master@{#455266}

[modify] https://crrev.com/2c0032c9ca74bd03925a7367f4482e4ec6f06278/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[modify] https://crrev.com/2c0032c9ca74bd03925a7367f4482e4ec6f06278/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/2c0032c9ca74bd03925a7367f4482e4ec6f06278/third_party/WebKit/LayoutTests/paint/invalidation/filter-invalidation-with-composited-container-change-expected.txt
[modify] https://crrev.com/2c0032c9ca74bd03925a7367f4482e4ec6f06278/third_party/WebKit/LayoutTests/paint/invalidation/filter-repaint-accelerated-on-accelerated-filter-expected.txt
[modify] https://crrev.com/2c0032c9ca74bd03925a7367f4482e4ec6f06278/third_party/WebKit/LayoutTests/paint/invalidation/resize-iframe-text.html
[delete] https://crrev.com/7100c1b09f742260b741c1cd717b8f449e0f8eb2/third_party/WebKit/LayoutTests/paint/invalidation/resources/resize-iframe-text-src.html
[modify] https://crrev.com/2c0032c9ca74bd03925a7367f4482e4ec6f06278/third_party/WebKit/LayoutTests/paint/invalidation/svg/embedded-svg-size-changes-no-layout-triggers-expected.txt
[modify] https://crrev.com/2c0032c9ca74bd03925a7367f4482e4ec6f06278/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/resize-iframe-text-expected.png
[modify] https://crrev.com/2c0032c9ca74bd03925a7367f4482e4ec6f06278/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/resize-iframe-text-expected.txt
[modify] https://crrev.com/2c0032c9ca74bd03925a7367f4482e4ec6f06278/third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/invalidation/svg/embedded-svg-size-changes-no-layout-triggers-expected.txt
[modify] https://crrev.com/2c0032c9ca74bd03925a7367f4482e4ec6f06278/third_party/WebKit/Source/core/frame/FrameView.cpp
[modify] https://crrev.com/2c0032c9ca74bd03925a7367f4482e4ec6f06278/third_party/WebKit/Source/core/layout/LayoutBox.cpp
[modify] https://crrev.com/2c0032c9ca74bd03925a7367f4482e4ec6f06278/third_party/WebKit/Source/core/paint/PaintInvalidationTest.cpp
[modify] https://crrev.com/2c0032c9ca74bd03925a7367f4482e4ec6f06278/third_party/WebKit/Source/core/paint/PaintInvalidator.cpp
[modify] https://crrev.com/2c0032c9ca74bd03925a7367f4482e4ec6f06278/third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp
[modify] https://crrev.com/2c0032c9ca74bd03925a7367f4482e4ec6f06278/third_party/WebKit/Source/core/paint/TablePaintInvalidator.cpp
Project Member

Comment 18 by bugdroid1@chromium.org, Mar 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a2d9b79961a229fb72dc617928243eff22755c4

commit 7a2d9b79961a229fb72dc617928243eff22755c4
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Wed Mar 08 06:01:38 2017

Auto-rebaseline for r455266

Build: https://build.chromium.org/p/chromium.infra.cron/builders/rebaseline-o-matic/builds/625954

https://chromium.googlesource.com/chromium/src/+/2c0032c9ca74b

BUG= 636271 
TBR=wangxianzhu@chromium.org

Review-Url: https://codereview.chromium.org/2735233003 .
Cr-Commit-Position: refs/heads/master@{#455389}

[modify] https://crrev.com/7a2d9b79961a229fb72dc617928243eff22755c4/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/7a2d9b79961a229fb72dc617928243eff22755c4/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/resize-iframe-text-expected.png
[modify] https://crrev.com/7a2d9b79961a229fb72dc617928243eff22755c4/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/resize-iframe-text-expected.txt
[delete] https://crrev.com/3f2aebea4889eee1f1d960590605a4544da63f51/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/disable-spinvalidation/paint/invalidation/resize-iframe-text-expected.txt
[add] https://crrev.com/7a2d9b79961a229fb72dc617928243eff22755c4/third_party/WebKit/LayoutTests/platform/mac-mac10.11/paint/invalidation/resize-iframe-text-expected.png
[copy] https://crrev.com/7a2d9b79961a229fb72dc617928243eff22755c4/third_party/WebKit/LayoutTests/platform/mac-mac10.11/paint/invalidation/resize-iframe-text-expected.txt
[add] https://crrev.com/7a2d9b79961a229fb72dc617928243eff22755c4/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/disable-spinvalidation/paint/invalidation/resize-iframe-text-expected.png
[rename] https://crrev.com/7a2d9b79961a229fb72dc617928243eff22755c4/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/disable-spinvalidation/paint/invalidation/resize-iframe-text-expected.txt
[delete] https://crrev.com/3f2aebea4889eee1f1d960590605a4544da63f51/third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/resize-iframe-text-expected.png
[delete] https://crrev.com/3f2aebea4889eee1f1d960590605a4544da63f51/third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/resize-iframe-text-expected.txt
[modify] https://crrev.com/7a2d9b79961a229fb72dc617928243eff22755c4/third_party/WebKit/LayoutTests/platform/mac-retina/paint/invalidation/resize-iframe-text-expected.png
[modify] https://crrev.com/7a2d9b79961a229fb72dc617928243eff22755c4/third_party/WebKit/LayoutTests/platform/mac-retina/paint/invalidation/resize-iframe-text-expected.txt
[add] https://crrev.com/7a2d9b79961a229fb72dc617928243eff22755c4/third_party/WebKit/LayoutTests/platform/mac-retina/virtual/disable-spinvalidation/paint/invalidation/resize-iframe-text-expected.png
[copy] https://crrev.com/7a2d9b79961a229fb72dc617928243eff22755c4/third_party/WebKit/LayoutTests/platform/mac-retina/virtual/disable-spinvalidation/paint/invalidation/resize-iframe-text-expected.txt
[modify] https://crrev.com/7a2d9b79961a229fb72dc617928243eff22755c4/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/resize-iframe-text-expected.png
[modify] https://crrev.com/7a2d9b79961a229fb72dc617928243eff22755c4/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/resize-iframe-text-expected.txt
[add] https://crrev.com/7a2d9b79961a229fb72dc617928243eff22755c4/third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/invalidation/resize-iframe-text-expected.png
[modify] https://crrev.com/7a2d9b79961a229fb72dc617928243eff22755c4/third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/invalidation/resize-iframe-text-expected.txt

Comment 19 by wangxianzhu@chromium.org, Apr 21 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment