bluetooth: win: Implement BluetoothRemoteGattCharacteristicWin::SubscribeToNotifications
Reported by
tom...@opera.com,
Aug 10 2016
|
||||
Issue descriptionImplement BluetoothRemoteGattCharacteristicMac::SubscribeToNotifications and UnsubscribeFromNotifications. Also remove the override of StartNotifySession so that the platform-independent version is used. See BluetoothRemoteGattCharacteristicAndroid for an example of how this can be done.
,
Aug 23 2016
,
Aug 23 2016
,
Jun 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/36a75a16ff5c3fa254e3c672081a7978554f5ea8 commit 36a75a16ff5c3fa254e3c672081a7978554f5ea8 Author: Giovanni Ortuño Urquidi <ortuno@chromium.org> Date: Mon Jun 26 01:33:21 2017 bluetooth: Move Windows to use SubscribeToNotifications And UnsubscribeFromNotifications. These two methods are used by the cross platform code to ensure consistent behaviour across platforms. Removes a test that is no longer relevant. The test made sure that calling StartNotifySession right after an error could succeed, but in the cross platform implementation a StartNotifySesssion call right after an error also fails. The rest of the tests pass so there shouldn't be any other changes in behaviour. Bug: 636270 Change-Id: I3819464e0c556836ec9ba26f76f5595775c18b10 Reviewed-on: https://chromium-review.googlesource.com/544378 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by: Vincent Scheib <scheib@chromium.org> Cr-Commit-Position: refs/heads/master@{#482180} [modify] https://crrev.com/36a75a16ff5c3fa254e3c672081a7978554f5ea8/device/bluetooth/bluetooth_remote_gatt_characteristic.cc [modify] https://crrev.com/36a75a16ff5c3fa254e3c672081a7978554f5ea8/device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc [modify] https://crrev.com/36a75a16ff5c3fa254e3c672081a7978554f5ea8/device/bluetooth/bluetooth_remote_gatt_characteristic_win.cc [modify] https://crrev.com/36a75a16ff5c3fa254e3c672081a7978554f5ea8/device/bluetooth/bluetooth_remote_gatt_characteristic_win.h
,
Jun 26 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot |
||||
►
Sign in to add a comment |
||||
Comment 1 by scheib@chromium.org
, Aug 12 2016Components: IO>Bluetooth
Labels: -Type-Bug Type-Feature
Status: Available (was: Untriaged)
Summary: bluetooth: win: Implement BluetoothRemoteGattCharacteristicWin::SubscribeToNotifications (was: Implement BluetoothRemoteGattCharacteristicMac::SubscribeToNotifications for Windows)