New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 636244 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Weird Remove this Person button is seen in user manager window

Project Member Reported by sc00335...@techmahindra.com, Aug 10 2016

Issue description

Version: 54.0.2825.0 
OS: Ubuntu 14.04,windows

Pre-condition: Enable Material design user manager window from chrome://flags

What steps will reproduce the problem?
(1) Launch chrome >> Click on switch person >> Try removing user from 3 dot menu and observe for "Remove this person" button

Expected: "Remove this person" text should be seen on button.
Actual: Instead empty button is seen.

This is a regression issue broken in M54. Will provide bisect info soon.

 
Actual_user manager.png
121 KB View Download
Labels: OS-Mac
Status: Untriaged (was: Unconfirmed)
Able to reproduce the issue on Mac OS 10.11.6 using chrome latest Dev M54-54.0.2825.0. Observed "Remove this person" text is not seen on the button.
Labels: -Needs-Bisect hasbisect
Owner: dbeam@chromium.org
Status: Assigned (was: Untriaged)
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/b0bc5dc5abc8ac3ac07fad7ab1eb583701b92600..e17801826d60a49a50bd33aa26d377b05016f791

Suspecting https://codereview.chromium.org/2224303003 from changelog.

@dbeam: Please confirm the behaviour or help in re-assigning if it is not related to your change. 

Comment 3 by dbeam@chromium.org, Aug 10 2016

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4926894a3c485b7a839ae803a4269cfc4db3df80

commit 4926894a3c485b7a839ae803a4269cfc4db3df80
Author: dbeam <dbeam@chromium.org>
Date: Thu Aug 11 03:07:17 2016

MD User Manager: add back i18n processing in JS

There was a whole bunch more i18n-content inside of ui/login that is
used by the MD user manager (whoops!).

This is a partial revert of crrev.com/410750

R=tommycli@chromium.org
BUG= 636244 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2238633002
Cr-Commit-Position: refs/heads/master@{#411244}

[modify] https://crrev.com/4926894a3c485b7a839ae803a4269cfc4db3df80/chrome/browser/resources/md_user_manager/user_manager.html

Comment 5 by dbeam@chromium.org, Aug 11 2016

Cc: mahmadi@chromium.org
Status: Fixed (was: Started)
Labels: TE-Verified-54.0.2830.0 TE-Verified-M54
Tested the issue on Windows 7, Mac 10.11.6, Ubuntu 14.04 using 54.0.2830.0."Remove this person" text is seen on button.
Please find attached screencast.

Marking it as TE-Verified.
636244.mp4
1.2 MB View Download

Sign in to add a comment