New issue
Advanced search Search tips

Issue 636234 link

Starred by 2 users
Status: Fixed
Owner:
rbpotter@chromium.org
Closed: Aug 2016
Cc:
mac-bugs-priority@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

"PrintPreviewDialogControllerUnitTest.CloseDialogOnNavigation" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Aug 10 2016 
"PrintPreviewDialogControllerUnitTest.CloseDialogOnNavigation" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 7 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyRwsSBUZsYWtlIjxQcmludFByZXZpZXdEaWFsb2dDb250cm9sbGVyVW5pdFRlc3QuQ2xvc2VEaWFsb2dPbk5hdmlnYXRpb24M.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs

Comment 1 by foolip@chromium.org, Aug 10 2016

Components: UI>Settings UI>Browser>PrintPreview
Owner: rbpotter@chromium.org
Status: Assigned (was: Untriaged)
Test was recently added in https://codereview.chromium.org/2215063002

Will revert CL, rbpotter@ PTAL.

Comment 2 by foolip@chromium.org, Aug 10 2016 

The failures are all on mac_chromium_rel_ng and look like this:

PrintPreviewDialogControllerUnitTest.CloseDialogOnNavigation (run #1):
[ RUN      ] PrintPreviewDialogControllerUnitTest.CloseDialogOnNavigation
[41473:1287:0810/034931:18891494657941:ERROR:native_widget_mac.mm(285)] Not implemented reached in virtual void views::NativeWidgetMac::SetWindowIcons(const gfx::ImageSkia &, const gfx::ImageSkia &)
../../chrome/browser/printing/print_preview_dialog_controller_unittest.cc:240: Failure
Expected: (tiger_barb_preview_dialog) != (tiger_preview_dialog_2), actual: 0x7f9efc809a00 vs 0x7f9efc809a00
[  FAILED  ] PrintPreviewDialogControllerUnitTest.CloseDialogOnNavigation (89 ms)

PrintPreviewDialogControllerUnitTest.CloseDialogOnNavigation (run #2):
[ RUN      ] PrintPreviewDialogControllerUnitTest.CloseDialogOnNavigation
[41697:1287:0810/035000:18919967715522:ERROR:native_widget_mac.mm(285)] Not implemented reached in virtual void views::NativeWidgetMac::SetWindowIcons(const gfx::ImageSkia &, const gfx::ImageSkia &)
../../chrome/browser/printing/print_preview_dialog_controller_unittest.cc:240: Failure
Expected: (tiger_barb_preview_dialog) != (tiger_preview_dialog_2), actual: 0x7fd71689b000 vs 0x7fd71689b000
[  FAILED  ] PrintPreviewDialogControllerUnitTest.CloseDialogOnNavigation (172 ms)

PrintPreviewDialogControllerUnitTest.CloseDialogOnNavigation (run #3):
[ RUN      ] PrintPreviewDialogControllerUnitTest.CloseDialogOnNavigation
[41702:1287:0810/035001:18921300913815:ERROR:native_widget_mac.mm(285)] Not implemented reached in virtual void views::NativeWidgetMac::SetWindowIcons(const gfx::ImageSkia &, const gfx::ImageSkia &)
../../chrome/browser/printing/print_preview_dialog_controller_unittest.cc:227: Failure
Expected: (tiger_preview_dialog) != (tiger_barb_preview_dialog), actual: 0x7fdaa9809000 vs 0x7fdaa9809000
[  FAILED  ] PrintPreviewDialogControllerUnitTest.CloseDialogOnNavigation (178 ms)

PrintPreviewDialogControllerUnitTest.CloseDialogOnNavigation (run #4):
[ RUN      ] PrintPreviewDialogControllerUnitTest.CloseDialogOnNavigation
[41703:1287:0810/035002:18921739457242:ERROR:native_widget_mac.mm(285)] Not implemented reached in virtual void views::NativeWidgetMac::SetWindowIcons(const gfx::ImageSkia &, const gfx::ImageSkia &)
../../chrome/browser/printing/print_preview_dialog_controller_unittest.cc:227: Failure
Expected: (tiger_preview_dialog) != (tiger_barb_preview_dialog), actual: 0x7fedec003e00 vs 0x7fedec003e00
[  FAILED  ] PrintPreviewDialogControllerUnitTest.CloseDialogOnNavigation (146 ms)

Comment 3 by foolip@chromium.org, Aug 10 2016

Labels: -Sheriff-Chromium OS-Mac
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5290712a92d8c235d1d6e704fa5a34937a57e56a

commit 5290712a92d8c235d1d6e704fa5a34937a57e56a
Author: foolip <foolip@chromium.org>
Date: Wed Aug 10 13:12:19 2016

Revert of Fix Print Preview Alt + Left Arrow breakage (patchset #5 id:80001 of https://codereview.chromium.org/2215063002/ )

Reason for revert:
PrintPreviewDialogControllerUnitTest.CloseDialogOnNavigation is flaky on mac_chromium_rel_ng:

PrintPreviewDialogControllerUnitTest.CloseDialogOnNavigation (run #1):
[ RUN      ] PrintPreviewDialogControllerUnitTest.CloseDialogOnNavigation
[41473:1287:0810/034931:18891494657941:ERROR:native_widget_mac.mm(285)] Not implemented reached in virtual void views::NativeWidgetMac::SetWindowIcons(const gfx::ImageSkia &, const gfx::ImageSkia &)
../../chrome/browser/printing/print_preview_dialog_controller_unittest.cc:240: Failure
Expected: (tiger_barb_preview_dialog) != (tiger_preview_dialog_2), actual: 0x7f9efc809a00 vs 0x7f9efc809a00
[  FAILED  ] PrintPreviewDialogControllerUnitTest.CloseDialogOnNavigation (89 ms)

BUG= 636234 

Original issue's description:
> Fix Print Preview Alt + Left Arrow breakage
>
> Fixing print preview closing in g-mail bug caused ALT + left
> arrow to break for certain cases. Changed condition for not
> closing dialog to be more specific.
>
> BUG= 634237 
>
> Committed: https://crrev.com/d65b6608c1349ba70606565b2bed9ff8b016473a
> Cr-Commit-Position: refs/heads/master@{#410717}

TBR=thestig@chromium.org,rbpotter@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 634237 

Review-Url: https://codereview.chromium.org/2232853002
Cr-Commit-Position: refs/heads/master@{#411030}

[modify] https://crrev.com/5290712a92d8c235d1d6e704fa5a34937a57e56a/chrome/browser/printing/print_preview_dialog_controller.cc
[modify] https://crrev.com/5290712a92d8c235d1d6e704fa5a34937a57e56a/chrome/browser/printing/print_preview_dialog_controller_unittest.cc
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2224d2c0c1863c313fa3d4fb510091bc067c1d3e

commit 2224d2c0c1863c313fa3d4fb510091bc067c1d3e
Author: rbpotter <rbpotter@chromium.org>
Date: Wed Aug 17 23:54:00 2016

Fix Print Preview Alt + Left Arrow breakage

Fixing print preview closing in g-mail bug caused ALT + left
arrow to break for certain cases. Changed condition for not
closing dialog to be more specific.

BUG= 636234 ,  634237 

Committed: https://crrev.com/d65b6608c1349ba70606565b2bed9ff8b016473a
Review-Url: https://codereview.chromium.org/2215063002
Cr-Original-Commit-Position: refs/heads/master@{#410717}
Cr-Commit-Position: refs/heads/master@{#412697}

[modify] https://crrev.com/2224d2c0c1863c313fa3d4fb510091bc067c1d3e/chrome/browser/printing/print_preview_dialog_controller.cc
[modify] https://crrev.com/2224d2c0c1863c313fa3d4fb510091bc067c1d3e/chrome/browser/printing/print_preview_dialog_controller_unittest.cc

Comment 6 by rbpotter@chromium.org, Aug 19 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment