New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 636231 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 671375



Sign in to add a comment

icons are scaled and blurry

Project Member Reported by michae...@chromium.org, Aug 10 2016

Issue description

Most of our iron-icons are specified in 24x24px but displayed in Settings at 20x20px. Of course SVG scales, but when you only have 20 pixels this means things get blurry.

Most noticeable with the "domain" icon (office building/enterprise), but really an issue with anything that uses lines (e.g., half the icons in the nav menu).
 
Screenshot on a normal display, because the icons scale well anyway on scaled displays.

Unless we show these icons in Settings at 24px, there's not much we can do about this without making new icons.
settings-1x.png
53.6 KB View Download
Labels: Hotlist-MD-Settings-General
Owner: bettes@chromium.org
Status: Assigned (was: Untriaged)
Alan, can we either use 24x24px icons, or get 20x20px assets to use?

Comment 3 by bettes@chromium.org, Aug 24 2016

At this time, I don't want to consider using 24px icons. I agree some of the icons are more problematic than others. 

Are there any math tweaking we can do to the existing set to adjust for the smaller size? 

Comment 4 by dbeam@chromium.org, Aug 24 2016

Components: UI>Browser>History
also affecting history

Comment 5 by dbeam@chromium.org, Aug 24 2016

Cc: calamity@chromium.org tsergeant@chromium.org
@bettes, can you check with sgabriel on how he handled the changes when resizing MD CrOS system menu icons?
Blocking: 671375

Comment 8 by bettes@chromium.org, Jan 23 2017

Status: Started (was: Assigned)

Comment 9 by dbeam@chromium.org, Jan 30 2017

Owner: dschuyler@chromium.org
dschuyler@: let's try to lay this out in CSS in a non-blurry way and send 1x and 2x screenshots to bettes@

important icons: three bar "hamburger" in top left, basic section icons, maybe 18x18 policy powerplant?
Project Member

Comment 10 by bugdroid1@chromium.org, Feb 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58f2a93a65dd6334741efdc815a61c3586841de4

commit 58f2a93a65dd6334741efdc815a61c3586841de4
Author: dschuyler <dschuyler@chromium.org>
Date: Fri Feb 03 04:29:09 2017

[MD settings] sharpen menu and domain icons in 20px scale

This CL adds some adjustments make the three bar (hamburger) icon and
the domain (the controlledBy/business) icon look sharper.

BUG= 636231 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2672963002
Cr-Commit-Position: refs/heads/master@{#447933}

[modify] https://crrev.com/58f2a93a65dd6334741efdc815a61c3586841de4/ui/webui/resources/cr_elements/icons.html

awesome, that's way better!
I can't see what michael is referring to on Version 58.0.3001.0, but i've attached links for the menu and the policy indicator. They're re-drawn to fit the grid of a 20x20 so should technically be more precise. For the the section icons, leave as-is for now. 

Policy: 
There's already svgs checked in to the ChromeOS' system tray. Please re-use if possible. Here's the drive links for reference. ChromeOS is using resolution specific assets. If we can't do the same, just use the 1x for both resolutions

1x 
https://drive.google.com/open?id=0B6x6iYCtKinEdXdFT3VoMWg5eGc

2x
https://drive.google.com/open?id=0B6x6iYCtKinEc1p3T2dBdE11c0E

Menu: 
https://drive.google.com/a/google.com/file/d/0BxMIIGI80eU-NUxWalhnZGd2cmM/view?usp=sharing

you might want to try with --force-device-scale-factor=2 command line flag as well (and/or 1.5)
Project Member

Comment 14 by bugdroid1@chromium.org, Feb 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a816bf16dc21e89afc43222a23901fb2b1a32ae

commit 1a816bf16dc21e89afc43222a23901fb2b1a32ae
Author: dschuyler <dschuyler@chromium.org>
Date: Mon Feb 13 21:06:19 2017

[MD settings] change menu and domain icons

This CL changes the menu and domain icons to match the chromeos versions
of those icons. This CL also corrects a centering issue with the domain
icons.

BUG= 690318 ,  636231 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2682423002
Cr-Commit-Position: refs/heads/master@{#450085}

[modify] https://crrev.com/1a816bf16dc21e89afc43222a23901fb2b1a32ae/chrome/browser/resources/settings/about_page/about_page.js
[modify] https://crrev.com/1a816bf16dc21e89afc43222a23901fb2b1a32ae/chrome/browser/resources/settings/about_page/detailed_build_info.html
[modify] https://crrev.com/1a816bf16dc21e89afc43222a23901fb2b1a32ae/chrome/browser/resources/settings/internet_page/internet_detail_page.html
[modify] https://crrev.com/1a816bf16dc21e89afc43222a23901fb2b1a32ae/chrome/browser/resources/settings/internet_page/internet_page.html
[modify] https://crrev.com/1a816bf16dc21e89afc43222a23901fb2b1a32ae/chrome/browser/resources/settings/people_page/people_page.html
[modify] https://crrev.com/1a816bf16dc21e89afc43222a23901fb2b1a32ae/chrome/browser/resources/settings/privacy_page/privacy_page.html
[modify] https://crrev.com/1a816bf16dc21e89afc43222a23901fb2b1a32ae/chrome/browser/resources/settings/site_settings/site_list.js
[modify] https://crrev.com/1a816bf16dc21e89afc43222a23901fb2b1a32ae/chrome/test/data/webui/settings/about_page_tests.js
[modify] https://crrev.com/1a816bf16dc21e89afc43222a23901fb2b1a32ae/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.html
[modify] https://crrev.com/1a816bf16dc21e89afc43222a23901fb2b1a32ae/ui/webui/resources/cr_elements/icons.html
[modify] https://crrev.com/1a816bf16dc21e89afc43222a23901fb2b1a32ae/ui/webui/resources/cr_elements/policy/cr_policy_indicator_behavior.js
[modify] https://crrev.com/1a816bf16dc21e89afc43222a23901fb2b1a32ae/ui/webui/resources/cr_elements/policy/cr_policy_pref_indicator.html

Owner: bettes@chromium.org
Status: Assigned (was: Started)
Alan, this could be marked fixed if we are only focusing (there's a pun there) on the menu icon and the policy (aka domain) icon mentioned in comment #12. Please go ahead and mark this fixed; or direct me to more icons to replace (links like in comment #12 are ideal). Thanks!
Status: Fixed (was: Assigned)

Sign in to add a comment