New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 636230 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Scrollbar is seen missing in audits section on expanding recorded audit data

Project Member Reported by sc00335...@techmahindra.com, Aug 10 2016

Issue description

Version: 54.0.2825.0 dev
OS: Ubuntu 14.04,windows

What steps will reproduce the problem?
(1) Launch chrome >> Go to NTP >> Open devtools and go to Audits section >> Now click on Run and record audit present state
(2) Now expand and observe for scrollbar.

Expected: Scrollbar should be seen and should be able to scroll.
Actual: Instead scrollbar is seen missing in audits section.

This is a regression issue broken in M54. Will provide bisect info soon. 
 
Actual_scrollbar.png
264 KB View Download

Comment 1 by ajha@chromium.org, Aug 10 2016

Labels: OS-Mac
Status: Untriaged (was: Unconfirmed)
Reproducible on 54.0.2825.0 on Mac OS 10.11.5 as well.
Labels: -Needs-Bisect hasbisect
Owner: pfeldman@chromium.org
Status: Assigned (was: Untriaged)
Good Build:54.0.2821.0 dev 
Bad Build :54.0.2822.0 dev

CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/a4e73d2ea1b167d26c75e59e38625047b25d7eb3..c58d14b485ad001da13adaced10dcdfeb6983c7a

Suspecting https://codereview.chromium.org/2217783002 from changelog.

@pfeldman: Please confirm the issue.
Expected_audits scrollbar.png
257 KB View Download
Just to update the bug with latest behavior, Issue still able to repro on Windows-10 using chrome latest canary M54-54.0.2831.0.

pfeldman@ - Any update on this bug? Will you mind looking in to this issue, If it's not related to your change please feel free to reassign it to the concerned Dev person.

Thanks!
Cc: ranjitkan@chromium.org
@ pfeldman: Gentle ping, request you to please take a look into it. M54 is going to be branched soon and Issue is still observed on canary version 54.0.2835.0 on Windows 7, MAC 10.11.6.

Thanks.!

Comment 5 by ajha@chromium.org, Aug 25 2016

Cc: dgozman@chromium.org
Cc'ing dgozman@ as well for more inputs on this.

Comment 6 by ajha@chromium.org, Aug 30 2016

Could anyone please take a look at this issue and update accordingly.


Note: Issue is seen on the latest M-54(54.0.2840.6) as tested on Linux Ubuntu 14.04.

Comment 7 by ajha@chromium.org, Sep 12 2016

Issue is reproducible on the latest canary(55.0.2858.0) on Linux Ubuntu 14.04.


Friendly ping to get an update on this issue. 
M54 Stable release is scheduled for the first week of OCT, please have the fix baked/verified in canary and request a merge to M54 ASAP.

Comment 9 by ajha@chromium.org, Sep 20 2016

Ping for an update on this.

Comment 10 by ajha@chromium.org, Sep 26 2016

Cc: nyerramilli@chromium.org
 Issue 650142  has been merged into this issue.
Friendly ping, this a stable blocker for M54, please try to have a fix in by the first week of October so it can be fixed in time for the release.
Owner: l...@chromium.org

Comment 13 by l...@chromium.org, Sep 28 2016

Status: Started (was: Assigned)
CL in review: https://codereview.chromium.org/2378933002/

Comment 15 by l...@chromium.org, Sep 29 2016

Labels: Merge-Request-54

Comment 16 by l...@chromium.org, Sep 29 2016

Not yet verified on Canary since the patch landed after the last Canary build.  Will update when verified.
Thanks for the fix, we will test in today's canary and merge the Cl if all looks good.

Comment 18 by dimu@chromium.org, Sep 30 2016

Labels: -Merge-Request-54 Merge-Approved-54 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M54 (branch: 2840)
Project Member

Comment 19 by bugdroid1@chromium.org, Sep 30 2016

Labels: -merge-approved-54 merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f060510deb014e3ba6d3f1a54ccc2d0e75ff6acb

commit f060510deb014e3ba6d3f1a54ccc2d0e75ff6acb
Author: luoe <luoe@chromium.org>
Date: Fri Sep 30 19:12:09 2016

DevTools: fix scrolling in audits

BUG= 636230 
TBR=kozyatinskiy@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2378933002
Cr-Commit-Position: refs/heads/master@{#421848}
(cherry picked from commit 7dffb9dd412ed8fc5f7db26a432fdbaa7f8e1c28)

Review-Url: https://codereview.chromium.org/2383183002
Cr-Commit-Position: refs/branch-heads/2840@{#602}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/f060510deb014e3ba6d3f1a54ccc2d0e75ff6acb/third_party/WebKit/Source/devtools/front_end/audits/AuditsPanel.js
[modify] https://crrev.com/f060510deb014e3ba6d3f1a54ccc2d0e75ff6acb/third_party/WebKit/Source/devtools/front_end/audits/auditsPanel.css

Labels: TE-Verified-M55 TE-Verified-55.0.2879.0
Tested this issue on Windows-10, Mac OS 10.12 and Ubuntu 14.04 using chrome latest Dev M55-55.0.2879.0 by following steps mentioned in the original comment. Observed scroll bar under audit section and able to scroll the page with no issues. Hence adding TE-Verified label.



636230.mp4
1.7 MB View Download
luoe@,If there is no pending work, can we tag this as fixed.

Comment 22 by l...@chromium.org, Oct 3 2016

Status: Fixed (was: Started)
Yes we can, sorry for the delay.  Thank you verifiers for checking!
Labels: TE-Verified-54.0.2840.50 TE-Verified-M54
Tested the issue on windows 7, Linux Ubuntu 14.04 and Mac 10.11.6 using chrome version 54.0.2840.50.Able to scroll the audits section without any issues.Please find the attached screen shot for the same.

Adding TE-Verified labels.

Thanks,
636230.png
156 KB View Download
Status: Verified (was: Fixed)
Project Member

Comment 25 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f060510deb014e3ba6d3f1a54ccc2d0e75ff6acb

commit f060510deb014e3ba6d3f1a54ccc2d0e75ff6acb
Author: luoe <luoe@chromium.org>
Date: Fri Sep 30 19:12:09 2016

DevTools: fix scrolling in audits

BUG= 636230 
TBR=kozyatinskiy@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2378933002
Cr-Commit-Position: refs/heads/master@{#421848}
(cherry picked from commit 7dffb9dd412ed8fc5f7db26a432fdbaa7f8e1c28)

Review-Url: https://codereview.chromium.org/2383183002
Cr-Commit-Position: refs/branch-heads/2840@{#602}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/f060510deb014e3ba6d3f1a54ccc2d0e75ff6acb/third_party/WebKit/Source/devtools/front_end/audits/AuditsPanel.js
[modify] https://crrev.com/f060510deb014e3ba6d3f1a54ccc2d0e75ff6acb/third_party/WebKit/Source/devtools/front_end/audits/auditsPanel.css

Sign in to add a comment