Storage manager: Adjust the font size to be consistent with other overlays in Settings. |
|||||
Issue descriptionVersion: ToT OS: Chrome OS What steps will reproduce the problem? (1) Open storage manager from chrome://settings/storage (2) Observe the font size in the overlay. The font size looks too big compared to other Settings overlays. It needs to be adjusted to be consistent with others. The updated spec is https://drive.google.com/corp/drive/u/0/folders/0B_2Uyb2Rhx2OWkdMM2tJanUxdjg
,
Aug 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3f134220f879b3ec4a29d985ac94c10c7b82524c commit 3f134220f879b3ec4a29d985ac94c10c7b82524c Author: fukino <fukino@chromium.org> Date: Thu Aug 11 04:08:06 2016 Storage manager: Fix font size and adjust layout. In the previous layout spec, the font size looks too big compared to other parts in Settings. This CL adjust the font size and some layout. The spec is https://drive.google.com/corp/drive/u/0/folders/0B_2Uyb2Rhx2OWkdMM2tJanUxdjg BUG= 636224 TEST=confirmed manually on minnie. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2233693002 Cr-Commit-Position: refs/heads/master@{#411260} [modify] https://crrev.com/3f134220f879b3ec4a29d985ac94c10c7b82524c/chrome/browser/resources/options/chromeos/storage_manager.css [modify] https://crrev.com/3f134220f879b3ec4a29d985ac94c10c7b82524c/chrome/browser/resources/options/chromeos/storage_manager.html
,
Aug 11 2016
Re:#1 The change has landed on main branch. Once the change is approved for a merge, I'll merge it to M53.
,
Aug 15 2016
Approving merge to M53 cros.
,
Aug 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/741c3840967fa3a5d54d978fc3c0f8770d2212cc commit 741c3840967fa3a5d54d978fc3c0f8770d2212cc Author: Naoki Fukino <fukino@chromium.org> Date: Wed Aug 17 02:19:15 2016 Storage manager: Fix font size and adjust layout. In the previous layout spec, the font size looks too big compared to other parts in Settings. This CL adjust the font size and some layout. The spec is https://drive.google.com/corp/drive/u/0/folders/0B_2Uyb2Rhx2OWkdMM2tJanUxdjg BUG= 636224 TEST=confirmed manually on minnie. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation TBR=dbeam@chromium.org Review-Url: https://codereview.chromium.org/2233693002 Cr-Commit-Position: refs/heads/master@{#411260} (cherry picked from commit 3f134220f879b3ec4a29d985ac94c10c7b82524c) Review URL: https://codereview.chromium.org/2250903002 . Cr-Commit-Position: refs/branch-heads/2785@{#636} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/741c3840967fa3a5d54d978fc3c0f8770d2212cc/chrome/browser/resources/options/chromeos/storage_manager.css [modify] https://crrev.com/741c3840967fa3a5d54d978fc3c0f8770d2212cc/chrome/browser/resources/options/chromeos/storage_manager.html
,
Aug 17 2016
,
Oct 19 2016
Verified on Chrome OS 8530.96.0, 53.0.2785.154 stable |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by ketakid@google.com
, Aug 10 2016