New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 636216 link

Starred by 1 user
Status: Fixed
Owner:
█ dglazkov@chromium.org
OOO until NaN
Closed: Aug 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Use EphemeralRange in WebLocalFrameImpl

Project Member Reported by dglazkov@chromium.org, Aug 10 2016 
In most cases in WebLocalFrameImpl, we're just using a range to get text or similar things. Full-blown Range should not be needed there.

Audit and change all callsites that use Range to EphemeralRange, instead.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3d9b2366eedee516376706c9eb7cb1c54ffaa16

commit a3d9b2366eedee516376706c9eb7cb1c54ffaa16
Author: dglazkov <dglazkov@chromium.org>
Date: Sun Aug 21 01:42:50 2016

Adapt WebRange to only deal with EphemeralRanges.

Range instantiation is expensive, and is not necessary for all of the uses
of the WebRange. So let's use EphemeralRanges instead.

BUG= 636216 
R=esprehn

Review-Url: https://codereview.chromium.org/2260283002
Cr-Commit-Position: refs/heads/master@{#413360}

[modify] https://crrev.com/a3d9b2366eedee516376706c9eb7cb1c54ffaa16/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
[modify] https://crrev.com/a3d9b2366eedee516376706c9eb7cb1c54ffaa16/third_party/WebKit/Source/web/WebRange.cpp
[modify] https://crrev.com/a3d9b2366eedee516376706c9eb7cb1c54ffaa16/third_party/WebKit/public/web/WebRange.h

Comment 2 by dglazkov@chromium.org, Aug 21 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment