New issue
Advanced search Search tips

Issue 636205 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocked on:
issue 651666



Sign in to add a comment

animated WebP has a memory spike when catching up the animation

Project Member Reported by cblume@chromium.org, Aug 10 2016

Issue description

Animated GIFs had a problem recently which caused OOMs when catching up an animation --  crbug.com/619173 

After fixing this, it was pointed out that we should apply a similar fix for other animated formats such as WebP.


WebP as a format supports keyframes, which means less memory will be spent when catching up.
In addition, animated WebP is less common out in the wild.
As a result, this bug is a lower priority than the GIF bug.
 

Comment 1 by cblume@chromium.org, Sep 30 2016

Blockedon: 651666
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cfcf81cfe56e8e34b30222d25d0e9b5eaaaf4b45

commit cfcf81cfe56e8e34b30222d25d0e9b5eaaaf4b45
Author: cblume <cblume@chromium.org>
Date: Tue Oct 11 01:26:43 2016

Cap memory usage in webp catch up

Currently, the Blink decoders get purged between each call to decode.
However, when the decoder needs to catch up, the cached frames are not
purged. They accumulate until the catch up has completed, which causes a
memory spike.

This may not be as much of a problem for webp, which likely has a
shorter catch up distance than gif (since it is more likely to resume
from a near-by keyframe).

Nevertheless, the memory spike should be avoided.

BUG= 636205 

Review-Url: https://codereview.chromium.org/2365943005
Cr-Commit-Position: refs/heads/master@{#424331}

[modify] https://crrev.com/cfcf81cfe56e8e34b30222d25d0e9b5eaaaf4b45/third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.cpp

Comment 3 by cblume@chromium.org, Oct 11 2016

Status: Fixed (was: Assigned)

Sign in to add a comment