New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 636191 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 640685



Sign in to add a comment

Quick View: Add more metadata

Project Member Reported by oka@chromium.org, Aug 10 2016

Issue description

Blocking: 640685
Labels: M55

Comment 2 by oka@chromium.org, Nov 11 2016

Labels: -M55 M56

Comment 3 by oka@chromium.org, Nov 21 2016

Status: Started (was: Assigned)

Comment 5 by oka@chromium.org, Nov 25 2016

Labels: Merge-Request-56

Comment 6 by oka@chromium.org, Nov 25 2016

Labels: -Merge-Request-56
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2141260e404efb75c6b20fb4be3eb8d41d8e8813

commit 2141260e404efb75c6b20fb4be3eb8d41d8e8813
Author: oka <oka@chromium.org>
Date: Fri Nov 25 09:45:56 2016

Quick View: Added Genre, Track and Duration metadata.

BUG= 636191 
TEST=manually tested using Linux. Screenshot:
https://drive.google.com/a/google.com/file/d/0B7EYjkGAjRAhV0JDYTBnOXBiNE0/view?usp=sharing
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2527333002
Cr-Commit-Position: refs/heads/master@{#434469}

[modify] https://crrev.com/2141260e404efb75c6b20fb4be3eb8d41d8e8813/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/2141260e404efb75c6b20fb4be3eb8d41d8e8813/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
[modify] https://crrev.com/2141260e404efb75c6b20fb4be3eb8d41d8e8813/ui/file_manager/file_manager/foreground/elements/files_metadata_box.html
[modify] https://crrev.com/2141260e404efb75c6b20fb4be3eb8d41d8e8813/ui/file_manager/file_manager/foreground/elements/files_metadata_box.js
[modify] https://crrev.com/2141260e404efb75c6b20fb4be3eb8d41d8e8813/ui/file_manager/file_manager/foreground/js/metadata/content_metadata_provider.js
[modify] https://crrev.com/2141260e404efb75c6b20fb4be3eb8d41d8e8813/ui/file_manager/file_manager/foreground/js/metadata/metadata_item.js
[modify] https://crrev.com/2141260e404efb75c6b20fb4be3eb8d41d8e8813/ui/file_manager/file_manager/foreground/js/metadata_box_controller.js

Comment 8 by oka@chromium.org, Nov 25 2016

I added support for metadata gotton from chrome.mediaGalleries.
Remaining metadata should be obtained from file parser.
Nice... Screenshot looks good! :)

Comment 12 by oka@chromium.org, Dec 8 2016

Labels: -M56 M57

Comment 13 by oka@chromium.org, Dec 8 2016

I create CLs to add image's lens and resolution information.
https://drive.google.com/file/d/0B7EYjkGAjRAhSV9xdU5JU0pJWXM/view

Remainings are
- audio resolution
- audio year recorded
- video frame rate

I'm leaning not to implement pdf page count, because there is no existing parser for pdf.
Thanks Oka-san, this is awesome!! :)

On the PDF page count - Since the current webview preview provides the # of pages at the top, I don't think we need to implement on the side.

Comment 15 by oka@chromium.org, Dec 9 2016

The label "Lens" would not be appropriate since only F number is lens infomation and other stuff depends on how the picture was shot.
Satoru-san suggested "Shooting Info".

Comment 16 by oka@chromium.org, Dec 9 2016

Weifang, WDYT? Does it sound good to use "Shooting Info" for the string combining F number, exposure time, focal length and ISO spped?
Hmm... what do you think of "Capture Settings"? I think "Shooting" is a little camera specific, whereas "Capture" can be however the image is captured?
Maybe "Device Settings"? That's consistent with "Device Model".
That works! Let's go with "Device Settings". Thanks!!
Project Member

Comment 20 by bugdroid1@chromium.org, Dec 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33e0696659c759ed73c5567aa827835751d5ebd7

commit 33e0696659c759ed73c5567aa827835751d5ebd7
Author: oka <oka@chromium.org>
Date: Wed Dec 14 07:27:23 2016

Quick View: Add device setting metadata.

Added device setting metadata including F number, exposure time, focal length and ISO,
in the same form as the one in Google Photos.

BUG= 636191 
TEST=manually.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2564553002
Cr-Commit-Position: refs/heads/master@{#438453}

[modify] https://crrev.com/33e0696659c759ed73c5567aa827835751d5ebd7/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/33e0696659c759ed73c5567aa827835751d5ebd7/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
[modify] https://crrev.com/33e0696659c759ed73c5567aa827835751d5ebd7/ui/file_manager/file_manager/foreground/elements/files_metadata_box.html
[modify] https://crrev.com/33e0696659c759ed73c5567aa827835751d5ebd7/ui/file_manager/file_manager/foreground/elements/files_metadata_box.js

Comment 21 by oka@chromium.org, Dec 14 2016

Added "Device Settings"! Thanks.

Comment 22 by oka@chromium.org, Dec 16 2016

Created a CL to show Year Recorded and more precise Track information in mp3 files if any.
https://codereview.chromium.org/2581133002/

audio.png
314 KB View Download
Project Member

Comment 23 by bugdroid1@chromium.org, Dec 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b2efe31ead46b7e94407d8d4cb97b75f22d1d2ea

commit b2efe31ead46b7e94407d8d4cb97b75f22d1d2ea
Author: oka <oka@chromium.org>
Date: Mon Dec 19 09:12:59 2016

Quick View: Show year recorded metadata.

In metadata box of Quick View, we show year recorded metadata in mp3
files in any.
This CL also populates track metadata from the metadata in mp3 if any.
Screenshot: https://bugs.chromium.org/p/chromium/issues/detail?id=636191#c22

BUG= 636191 
TEST=
1. Download a mp3 file from Google Music.
2. Open the file on Quick View
3. Confirm year recorded metadata is shown.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2581133002
Cr-Commit-Position: refs/heads/master@{#439440}

[modify] https://crrev.com/b2efe31ead46b7e94407d8d4cb97b75f22d1d2ea/ui/file_manager/file_manager/foreground/elements/files_metadata_box.html
[modify] https://crrev.com/b2efe31ead46b7e94407d8d4cb97b75f22d1d2ea/ui/file_manager/file_manager/foreground/elements/files_metadata_box.js
[modify] https://crrev.com/b2efe31ead46b7e94407d8d4cb97b75f22d1d2ea/ui/file_manager/file_manager/foreground/js/metadata/content_metadata_provider.js
[modify] https://crrev.com/b2efe31ead46b7e94407d8d4cb97b75f22d1d2ea/ui/file_manager/file_manager/foreground/js/metadata/metadata_item.js
[modify] https://crrev.com/b2efe31ead46b7e94407d8d4cb97b75f22d1d2ea/ui/file_manager/file_manager/foreground/js/metadata_box_controller.js

Comment 24 by oka@chromium.org, Dec 19 2016

Status: Fixed (was: Started)

Comment 25 by oka@chromium.org, Dec 19 2016

Finished!
Awesome, thanks!
Labels: -M57 M-57
Awesome, thanks for all the hard work getting this closed out!
Status: Verified (was: Fixed)

Sign in to add a comment