New issue
Advanced search Search tips

Issue 636187 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

NQE: Remove EFFECTIVE_CONNECTION_TYPE_BROADBAND from the list of ECT enums

Project Member Reported by tbansal@chromium.org, Aug 10 2016

Issue description

Currently, there are no plans to report 
EFFECTIVE_CONNECTION_TYPE_BROADBAND as a possible
Effective Connection Type (ECT) from the
Network Quality Estimator's (NQE) APIs. It should therefore be removed
from the list of enums.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43b6c15a8f16bcbed01b3eb34bd9d656fde0c20b

commit 43b6c15a8f16bcbed01b3eb34bd9d656fde0c20b
Author: tbansal <tbansal@chromium.org>
Date: Mon Aug 15 18:35:25 2016

NQE: Remove Broadband from the list of ECT enums

Currently, there are no plans to report
EFFECTIVE_CONNECTION_TYPE_BROADBAND as a possible
Effective Connection Type (ECT) from the
Network Quality Estimator's (NQE) APIs.

This CL removes EFFECTIVE_CONNECTION_TYPE_BROADBAND
from the list of ECT enums.

BUG= 636187 
TBR=nasko@chromium.org, japhet@chromium.org

Review-Url: https://codereview.chromium.org/2228253002
Cr-Commit-Position: refs/heads/master@{#411996}

[modify] https://crrev.com/43b6c15a8f16bcbed01b3eb34bd9d656fde0c20b/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc
[modify] https://crrev.com/43b6c15a8f16bcbed01b3eb34bd9d656fde0c20b/content/renderer/effective_connection_type_helper.cc
[modify] https://crrev.com/43b6c15a8f16bcbed01b3eb34bd9d656fde0c20b/content/renderer/render_frame_impl_browsertest.cc
[modify] https://crrev.com/43b6c15a8f16bcbed01b3eb34bd9d656fde0c20b/net/nqe/effective_connection_type.cc
[modify] https://crrev.com/43b6c15a8f16bcbed01b3eb34bd9d656fde0c20b/net/nqe/effective_connection_type.h
[modify] https://crrev.com/43b6c15a8f16bcbed01b3eb34bd9d656fde0c20b/net/nqe/network_quality_estimator_unittest.cc
[modify] https://crrev.com/43b6c15a8f16bcbed01b3eb34bd9d656fde0c20b/third_party/WebKit/public/platform/WebEffectiveConnectionType.h

Status: Fixed (was: Started)
Components: Internals>Network>NetworkQuality
Labels: -nqe

Sign in to add a comment