New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 636178 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Aug 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

arc: opt in language is inconsistent

Project Member Reported by khmel@chromium.org, Aug 10 2016

Issue description

Inner bug: b/30434808
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b4cf059891075dc7f6e45bdc114118c1e5579f46

commit b4cf059891075dc7f6e45bdc114118c1e5579f46
Author: khmel <khmel@chromium.org>
Date: Wed Aug 10 17:47:34 2016

arc: Fix logic of selection terms version in OptIn.

We are not allowed to show ToS in different than Chrome UI language,
except the case when we are unable to determine right combination of
language and zone and show ToS in default English. This also provides
handling of navigator.language in 2 forwats, short and long which
can appear in terms.

BUG= 636178 
BUG=b/30434808
TEST=Manually on device, various combinations of time zone,
     UI languages and VPN.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2234573002
Cr-Commit-Position: refs/heads/master@{#411077}

[modify] https://crrev.com/b4cf059891075dc7f6e45bdc114118c1e5579f46/chrome/browser/resources/chromeos/arc_support/playstore.js

Comment 2 by khmel@chromium.org, Aug 10 2016

Labels: Merge-Request-53

Comment 3 by gov...@chromium.org, Aug 11 2016

This is specific to Chrome OS, right?

Comment 4 by khmel@chromium.org, Aug 11 2016

Yes, only for Chrome OS and only for Arc.

Comment 5 by gov...@chromium.org, Aug 11 2016

Cc: keta...@chromium.org
Labels: OS-Chrome
+ ketakid@ (Chrome OS TPM)

Comment 6 by dimu@chromium.org, Aug 11 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)

Comment 7 by khmel@chromium.org, Aug 11 2016

Labels: -Merge-Approved-53 Merge-Merged

Comment 8 by khmel@chromium.org, Aug 11 2016

Status: Fixed (was: Started)
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 11 2016

Labels: merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/708ed43a3dee6c4963c039e0f0bf1d8113306dd5

commit 708ed43a3dee6c4963c039e0f0bf1d8113306dd5
Author: khmel <khmel@chromium.org>
Date: Thu Aug 11 18:04:22 2016

arc: Fix logic of selection terms version in OptIn.

We are not allowed to show ToS in different than Chrome UI language,
except the case when we are unable to determine right combination of
language and zone and show ToS in default English. This also provides
handling of navigator.language in 2 forwats, short and long which
can appear in terms.

BUG= 636178 
BUG=b/30434808
TEST=Manually on device, various combinations of time zone,
     UI languages and VPN.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

NOTRY=true
NOPRESUBMIT=true
TBR=reviewer@chromium.org

Review-Url: https://codereview.chromium.org/2234573002
Cr-Commit-Position: refs/heads/master@{#411077}
(cherry picked from commit b4cf059891075dc7f6e45bdc114118c1e5579f46)

Review-Url: https://codereview.chromium.org/2243493003
Cr-Commit-Position: refs/branch-heads/2785@{#564}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/708ed43a3dee6c4963c039e0f0bf1d8113306dd5/chrome/browser/resources/chromeos/arc_support/playstore.js

Status: Verified (was: Fixed)
Chrome OS 53.0.2785.70/8530.62.0 beta cyan

Sign in to add a comment