New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 636176 link

Starred by 1 user
Status: Fixed
Owner:
█ jbau...@chromium.org
not on Chrome anymore
Closed: Aug 2016
Cc:
█ ananta@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Memory leak of IDirectManipulationViewport and IDirectManipulationPrimaryContent

Project Member Reported by jbau...@chromium.org, Aug 10 2016 
It looks like every time we destroy a DirectManipulationHelper we leak 4KB or so. For some reason the view_port_outer_ has 3 additional references on it (maybe some circular references?) that I don't know how to remove.

Comment 1 by jbau...@chromium.org, Aug 10 2016

Owner: jbau...@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d48b65a4b84e0ca652bf5ab39abaf0809ba4b6cd

commit d48b65a4b84e0ca652bf5ab39abaf0809ba4b6cd
Author: jbauman <jbauman@chromium.org>
Date: Wed Aug 10 03:07:17 2016

Call IDirectManipulationViewport::Abandon before releasing viewport.

Otherwise there's a reference cycle and about 4KB is leaked.

BUG= 636176 

Review-Url: https://codereview.chromium.org/2229233002
Cr-Commit-Position: refs/heads/master@{#410936}

[modify] https://crrev.com/d48b65a4b84e0ca652bf5ab39abaf0809ba4b6cd/ui/gfx/win/direct_manipulation.cc

Comment 3 by jbau...@chromium.org, Aug 12 2016

Labels: Merge-Request-53

Comment 4 by dimu@chromium.org, Aug 12 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 12 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef2d09549e46c740f6f678396ff892816e6a513c

commit ef2d09549e46c740f6f678396ff892816e6a513c
Author: John Bauman <jbauman@chromium.org>
Date: Fri Aug 12 23:24:52 2016

Call IDirectManipulationViewport::Abandon before releasing viewport.

Otherwise there's a reference cycle and about 4KB is leaked.

BUG= 636176 

Review-Url: https://codereview.chromium.org/2229233002
Cr-Commit-Position: refs/heads/master@{#410936}
(cherry picked from commit d48b65a4b84e0ca652bf5ab39abaf0809ba4b6cd)

Review URL: https://codereview.chromium.org/2243823003 .

Cr-Commit-Position: refs/branch-heads/2785@{#579}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/ef2d09549e46c740f6f678396ff892816e6a513c/ui/gfx/win/direct_manipulation.cc

Comment 6 by jbau...@chromium.org, Aug 12 2016

Status: Fixed (was: Started)
►

Sign in to add a comment