New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 636175 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Aug 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 585504



Sign in to add a comment

Remove "User instance wasn't found while setting child account flag." log spam at boot

Project Member Reported by derat@chromium.org, Aug 10 2016

Issue description

I see a warning like this when booting a ToT samus image:

[2133:2133:0809/143856:WARNING:child_account_service.cc(302)] User instance wasn't found while setting child account flag.

I'm not using supervised users.

Here's the code:

void ChildAccountService::PropagateChildStatusToUser(bool is_child) {
#if defined(OS_CHROMEOS)
  user_manager::User* user =
      chromeos::ProfileHelper::Get()->GetUserByProfile(profile_);
  if (user) {
    user_manager::UserManager::Get()->ChangeUserChildStatus(user, is_child);
  } else {
    LOG(WARNING) <<
        "User instance wasn't found while setting child account flag.";
  }
#endif
}

I think we should check that this isn't the signin profile before logging the warning.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41f175f8b846a87f277fbb891522ec86e24a12d5

commit 41f175f8b846a87f277fbb891522ec86e24a12d5
Author: derat <derat@chromium.org>
Date: Thu Aug 11 15:03:41 2016

chromeos: Avoid bogus child account warning at startup.

I'm seeing a "User instance wasn't found while setting child
account flag." warning at boot. Avoid logging anything if
the current profile is the signin profile.

BUG= 636175 

Review-Url: https://codereview.chromium.org/2232653002
Cr-Commit-Position: refs/heads/master@{#411330}

[modify] https://crrev.com/41f175f8b846a87f277fbb891522ec86e24a12d5/chrome/browser/supervised_user/child_accounts/child_account_service.cc

Comment 2 by derat@chromium.org, Aug 11 2016

Status: Fixed (was: Started)
Labels: VerifyIn-54

Comment 4 by dchan@chromium.org, Oct 7 2016

Labels: VerifyIn-55

Comment 5 by dchan@google.com, Nov 19 2016

Labels: VerifyIn-56

Comment 6 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 7 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 8 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 9 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 11 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment