New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 636167 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

Stop logging all sample frame bytes in the BattOr agent

Project Member Reported by charliea@chromium.org, Aug 10 2016

Issue description

We need this to figure out why the Mac BattOr agent is occasionally failing.

aschulman@, could you provide some details on what you'd like in this light mode?
 
Looking back in chat, it looks like Aaron would like for only the bytes of control messages to be logged.
Aaron and I discussed this more offline, and it seems like just disabling the logging of data frames in favor of just logging the number of bytes received in the data frames will also work. The reason for this is that, if we log all of the bytes received in the frame, then it takes long enough that it exacerbates the problem where we can't read bytes off the wire fast enough and thus drop bytes. 
Summary: Stop logging all sample frame bytes in the BattOr agent (was: Add a "light" serial logging mode to the BattOr agent)
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4a4dbdadd4632038295e2e5133b7f3a162c78f27

commit 4a4dbdadd4632038295e2e5133b7f3a162c78f27
Author: charliea <charliea@chromium.org>
Date: Wed Aug 10 15:50:10 2016

[battor agent] Don't log all bytes received when reading sample frames

This logging mode exacerbates problems on Mac wherein we drop sample
frames because the serial buffer overflows from not processing frames
fast enough.

TBR=aschulman@chromium.org
BUG= 636167 

Review-Url: https://codereview.chromium.org/2233893002
Cr-Commit-Position: refs/heads/master@{#411047}

[modify] https://crrev.com/4a4dbdadd4632038295e2e5133b7f3a162c78f27/tools/battor_agent/battor_connection_impl.cc

Status: Fixed (was: Assigned)

Sign in to add a comment