New issue
Advanced search Search tips

Issue 636166 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux , Chrome
Pri: 3
Type: Bug

Blocking:
issue 585504



Sign in to add a comment

Get rid of "Failed to authenticate /dev/dri/card0" log spam

Project Member Reported by derat@chromium.org, Aug 10 2016

Issue description

I see this at the top of Chrome's log after a ToT samus device boots:

[2133:2133:0809/143855:WARNING:drm_device_handle.cc(60)] Failed to authenticate /dev/dri/card0
[2133:2133:0809/143856:VERBOSE1:drm_device_handle.cc(66)] Succeeded authenticating /dev/dri/card0

Looking at the code, it seems like some failures are expected -- we retry indefinitely and log after the first failure.

If this is correct, we should wait longer before logging the error. I have a change that makes us only print the warning after the second and that makes the VLOG(1) a bit more informative:

[2160:2160:0809/175940:VERBOSE1:drm_device_handle.cc(83)] Succeeded authenticating /dev/dri/card0 in 500 ms with 6 attempt(s)

If we don't expect any failures, Daniel is now aware that we're seeing them. :-P
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e67c8c21f958d2679ada3449013f307debf1fe77

commit e67c8c21f958d2679ada3449013f307debf1fe77
Author: derat <derat@chromium.org>
Date: Wed Aug 10 13:24:57 2016

Suppress "Failed to authenticate /dev/dri/card0" log spam.

Don't log a "Failed to authenticate /dev/dri/card0" warning
until we've failed for a full second, and include more
information in the success message.

BUG= 636166 

Review-Url: https://codereview.chromium.org/2226163005
Cr-Commit-Position: refs/heads/master@{#411032}

[modify] https://crrev.com/e67c8c21f958d2679ada3449013f307debf1fe77/ui/ozone/platform/drm/host/drm_device_handle.cc

Comment 2 by derat@chromium.org, Aug 10 2016

Status: Fixed (was: Started)

Sign in to add a comment