New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 636153 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature

Blocked on:
issue 682819
issue 687261
issue 689788
issue 693296

Blocking:
issue 613044
issue 690011
issue 698902
issue 690085
issue 694359
issue 695334
issue 696656



Sign in to add a comment

Port telemetry's browser_test_runner to use typ

Project Member Reported by nedngu...@google.com, Aug 9 2016

Issue description

We need to port telemetry's browser_test_runner to use typ so it can run tests in multiprocesses. This is for utilizing the number of Android devices per host machine when we do Android testing.

The plan is to use python unittest's load_test() protocol:

webgl_conformance_integration_test.py

...

class WebGLConformanceIntegrationTest(gpu_integration_test.GpuIntegrationTest):
  ...


def load_tests(loader, standard_tests, pattern):
   return serially_executed_browser_test_runner.LoadTests(__file__, loader, standard_tests, pattern))  #the magic of generating test cases is moved from browser_test_runner to this helper.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Aug 10 2016

Labels: Hotlist-Google
Owner: nedngu...@google.com
Status: Started (was: Untriaged)
I may have some downtime to work on this this week.
Since we currently support shard tests by test time in browser_test_runner, we need typ to also support this before porting: https://github.com/dpranke/typ/issues/6 

Comment 4 by kbr@chromium.org, Aug 23 2016

Is it really necessary for typ to support that? If browser_test_runner has the opportunity to specify a subset of tests for typ to run, then it can contain this logic. I would rather this code remain in browser_test_runner than move the algorithm into typ.

I think it's a bit awkward to keep that code in browser_test_runner only because things like telemetry_perf_unittest also wants sharding and they currently do so by passing shard_index & total_shard to typ.

Since typ also control the test output format, I think it makes more sense for the logic of handling sharding based on timing to be done in typ.
Though you make a good point about adding sharding by time support in typ doesn't need to block this. I will go ahead with this bug & leave that effort separate as it's code health/refactoring type.

Comment 7 by kbr@chromium.org, Aug 23 2016

Thanks. I'm just nervous about having a deep dependency chain if the logic for sharding by test times needs to change in the future.

It's not clear to me that this logic should be in typ, either. It make sense if we can make it generic enough and enough people want to share it, but that hasn't been proven yet.

Otherwise, I don't want to add every switch we might ever want to typ just because we can. Even the aforementioned sharding flags are a little dubious to me.

And, I don't see why the test output format is related to a specific sharding feature, but maybe you're thinking it's because they use the same format, or something?
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c40df542b75cf54fcb0382ca34f6cf191e350f6e

commit c40df542b75cf54fcb0382ca34f6cf191e350f6e
Author: catapult-deps-roller <catapult-deps-roller@chromium.org>
Date: Wed Aug 24 21:55:39 2016

Roll src/third_party/catapult/ ae022b60c..5bcf2c70f (7 commits).

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/ae022b60c580..5bcf2c70f4dd

$ git log ae022b60c..5bcf2c70f --date=short --no-merges --format='%ad %ae %s'
2016-08-24 nednguyen Show trace's url in CSV output formater.
2016-08-24 oysteine Added a demo mapper for the trace processor
2016-08-24 rmcilroy [memory-metric] Extract v8:code_and_metadata from all memory dumps
2016-08-24 erikchen Add CPU metrics for Chrome on Mac.
2016-08-24 petrcermak [merge-traces] Support multiple sub-traces in a vulcanized HTML trace
2016-08-24 benjhayden Fix single-sample Histogram sample diagnostics
2016-08-24 nednguyen [Telemetry] Add browser_test_runnner.LoadAllTestsInModule method

BUG= 640054 , 636153 

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2277473005
Cr-Commit-Position: refs/heads/master@{#414161}

[modify] https://crrev.com/c40df542b75cf54fcb0382ca34f6cf191e350f6e/DEPS

Comment 10 by kbr@chromium.org, Dec 2 2016

Cc: nedngu...@google.com zmo@chromium.org kainino@chromium.org
Components: Internals>GPU>Testing
Labels: -Type-Bug -Pri-3 Pri-1 Type-Feature
Owner: ----
Status: Available (was: Started)
Our group strongly desires this feature in the near future for two reasons:

1) Getting tests running efficiently on Android
2) Producing full JSON results for the flakiness dashboard

I'm taking the liberty of upgrading this to a P1 feature request. Could we please discuss how it might be done in the next month or so? I would be happy to work on this but would need explicit guidance; I don't know the Python unittest harness well, or typ at all.

Moving back into the Available state so as to not explicitly put work on Ned's plate.

Owner: nedngu...@google.com
Status: Assigned (was: Available)
I have WIP patch for this, was procrastinating because I thought it would take a while to run gpu test on Android. I will push this further next week.
Project Member

Comment 12 by bugdroid1@chromium.org, Dec 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6140d6c6a50690dbc0c7d30e753104883a9873a0

commit 6140d6c6a50690dbc0c7d30e753104883a9873a0
Author: catapult-deps-roller <catapult-deps-roller@chromium.org>
Date: Tue Dec 13 03:16:34 2016

Roll src/third_party/catapult/ 19565fdb1..c69690acc (12 commits).

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/19565fdb148a..c69690acc34b

$ git log 19565fdb1..c69690acc --date=short --no-merges --format='%ad %ae %s'
2016-12-12 charliea Upload the serial log file when we fail to retrieve the BattOr git hash
2016-12-12 jessimb Fixed mapreduce.yaml to name: entity_kind
2016-12-12 dtu [firefighter] Replace builder name regexes with more fuzzy matching.
2016-12-12 jessimb A MapReduce job to add units into the anomaly entity.
2016-12-12 benjhayden Fix mismatched curly braces in sinebow_color_generator_test.
2016-12-12 eakuefner Revert of [Telemetry] Add temporary logging to desktop_browser_finder (patchset #1 id:1 of https://codereview.chromium.org/2567783002/ )
2016-12-12 eakuefner [Telemetry] Introduce LegacyHtmlOutputFormatter
2016-12-12 rnephew [BattOr] Detect malformed git hashes.
2016-12-12 eakuefner [Telemetry] Pass --disable-gpu in run_tests if starting Xvfb
2016-12-12 nednguyen Move browser_test_runner.LoadAllTestsInModule to serially_executed_browser_test_case
2016-12-12 nednguyen [Telemetry] Fix flaky browser test due to duplicated system stubbing
2016-12-12 benjhayden Make ChartJsonConverter support UMA Histograms and single-story results.

BUG= 673411 , 636153 

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2574623002
Cr-Commit-Position: refs/heads/master@{#438019}

[modify] https://crrev.com/6140d6c6a50690dbc0c7d30e753104883a9873a0/DEPS

Comment 13 by ajuma@chromium.org, Jan 21 2017

P1 bug ping, what are the next steps for this?
Blockedon: 682819
WIP CL that are already approved: https://codereview.chromium.org/2590623002/

This CL will be landed after  issue 682819  is fixed.

Comment 15 by kbr@chromium.org, Jan 24 2017

I resolved  Issue 682819  today. Feel free to move forward with the typ migration. Note that I'm OOO at a work conference this week so feel free to land trivial changes to the GPU tests TBR'd to me and PLEASE watch the tryservers and waterfall for signs of new flakiness after the switch. Thanks.

#15: I will wait for you to be back to land the real change. 
Project Member

Comment 17 by bugdroid1@chromium.org, Jan 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/44521e985457606bb56e05fbdd45e94bbe3e656f

commit 44521e985457606bb56e05fbdd45e94bbe3e656f
Author: nednguyen <nednguyen@google.com>
Date: Mon Jan 30 21:05:51 2017

Add typ boilerplate to Telemetry-based GPU tests.

The typ based browser_test_runner framework requires every browser test
module to explicitly declares test module generation in the
load_tests() method. This CL as those boiler plates code to prepare
for changing browser_test_runner to use typ as the runner.

This depends on https://codereview.chromium.org/2660913002 to avoid
gpu unittests from accidentally picking up those load_tests() method.

BUG= 636153 
TBR=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2662863002
Cr-Commit-Position: refs/heads/master@{#447059}

[modify] https://crrev.com/44521e985457606bb56e05fbdd45e94bbe3e656f/content/test/gpu/gpu_tests/context_lost_integration_test.py
[modify] https://crrev.com/44521e985457606bb56e05fbdd45e94bbe3e656f/content/test/gpu/gpu_tests/depth_capture_integration_test.py
[modify] https://crrev.com/44521e985457606bb56e05fbdd45e94bbe3e656f/content/test/gpu/gpu_tests/gpu_integration_test.py
[modify] https://crrev.com/44521e985457606bb56e05fbdd45e94bbe3e656f/content/test/gpu/gpu_tests/gpu_process_integration_test.py
[modify] https://crrev.com/44521e985457606bb56e05fbdd45e94bbe3e656f/content/test/gpu/gpu_tests/hardware_accelerated_feature_integration_test.py
[modify] https://crrev.com/44521e985457606bb56e05fbdd45e94bbe3e656f/content/test/gpu/gpu_tests/maps_integration_test.py
[modify] https://crrev.com/44521e985457606bb56e05fbdd45e94bbe3e656f/content/test/gpu/gpu_tests/path_util.py
[modify] https://crrev.com/44521e985457606bb56e05fbdd45e94bbe3e656f/content/test/gpu/gpu_tests/pixel_integration_test.py
[modify] https://crrev.com/44521e985457606bb56e05fbdd45e94bbe3e656f/content/test/gpu/gpu_tests/screenshot_sync_integration_test.py
[modify] https://crrev.com/44521e985457606bb56e05fbdd45e94bbe3e656f/content/test/gpu/gpu_tests/trace_integration_test.py
[modify] https://crrev.com/44521e985457606bb56e05fbdd45e94bbe3e656f/content/test/gpu/gpu_tests/webgl_conformance_integration_test.py

Project Member

Comment 18 by bugdroid1@chromium.org, Jan 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/42928bc5f4e7125608a86e33b046a1460d8e576d

commit 42928bc5f4e7125608a86e33b046a1460d8e576d
Author: catapult-deps-roller <catapult-deps-roller@chromium.org>
Date: Tue Jan 31 02:05:36 2017

Roll src/third_party/catapult/ c07366fe6..986b4e8b5 (7 commits).

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/c07366fe6a12..986b4e8b5880

$ git log c07366fe6..986b4e8b5 --date=short --no-merges --format='%ad %ae %s'
2017-01-30 rnephew Revert of [WPR] Implement platform dependent recordings for WPR archives. (patchset #17 id:360001 of https://codereview.chromium.org/2626373004/ )
2017-01-30 benjhayden Start the framework for merging diagnostics.
2017-01-30 benjhayden Translate RelatedHistogramBreakdown to python.
2017-01-30 nednguyen [Telemetry] Disable browser_test_runner_unittest.TestLoadAllTestModules.testLoadAllTestsInModule
2017-01-30 benjhayden Rename sourceValues to sourceHistograms.
2017-01-30 rnephew [WPR] Implement platform dependent recordings for WPR archives.
2017-01-30 lpy Update V8 runtime stats grouping.

BUG=618698, 636153 ,618698

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2661093002
Cr-Commit-Position: refs/heads/master@{#447161}

[modify] https://crrev.com/42928bc5f4e7125608a86e33b046a1460d8e576d/DEPS

Project Member

Comment 19 by bugdroid1@chromium.org, Jan 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f3b7942e1c524c13a1217d0e5723de692296f223

commit f3b7942e1c524c13a1217d0e5723de692296f223
Author: catapult-deps-roller <catapult-deps-roller@chromium.org>
Date: Tue Jan 31 18:22:15 2017

Roll src/third_party/catapult/ 6bc0354c3..2c3f1f3d6 (4 commits).

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/6bc0354c3540..2c3f1f3d69c0

$ git log 6bc0354c3..2c3f1f3d6 --date=short --no-merges --format='%ad %ae %s'
2017-01-31 nednguyen Revert of [Telemetry] Migrate browser_test_runner to use typ as the test runner (patchset #14 id:260001 of https://codereview.chromium.org/2590623002/ )
2017-01-31 simonhatch Dashboard - Move owner check before db reads.
2017-01-31 rnephew [BattOr] Add logging to debug why windows attached BattOrs are not flashing.
2017-01-31 nednguyen [Telemetry] Migrate browser_test_runner to use typ as the test runner

BUG= 636153 , 636153 

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2666763003
Cr-Commit-Position: refs/heads/master@{#447272}

[modify] https://crrev.com/f3b7942e1c524c13a1217d0e5723de692296f223/DEPS

https://codereview.chromium.org/2663813003/ was my attempt to roll out the change, but that makes webgl_conformance_tests timed out because typ always run the tearDownClass method after every test run, which makes the harness restarts the browsers hundreds times in the test & lead to timeout.

This issues is now blocked on  issue 687261 
Blockedon: 687261
After talking to Dirk, the agreed upon solution is to move the actual browser setup & teardown to the process setup & teardown instead of relying on unittest' setupClass & teardownClass. (so  issue 687261  is no longer relevant)

Luckily in this, it fits well to the browser_test_runner harness because it's designed to only run a single test class on every invocation. 
Though to make sure that the methods in setUpClass & tearDownClass be treated differently by browser_test_runner (which is moved to process setup & process teardown), I will need to rename those methods so that typ don't pick them up automatically.

Comment 24 by kbr@chromium.org, Feb 6 2017

Blocking: 613044
Project Member

Comment 25 by bugdroid1@chromium.org, Feb 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee2c2fb24cec1241e84612fa9e104c626e75f565

commit ee2c2fb24cec1241e84612fa9e104c626e75f565
Author: catapult-deps-roller <catapult-deps-roller@chromium.org>
Date: Mon Feb 06 21:10:08 2017

Roll src/third_party/catapult/ 7b509122f..4236e0b3f (3 commits).

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/7b509122f4da..4236e0b3f58c

$ git log 7b509122f..4236e0b3f --date=short --no-merges --format='%ad %ae %s'
2017-02-06 rnephew [WPR] Update unit tests to use the new archive_info2 data format.
2017-02-06 nednguyen Revert of [Telemetry] Migrate browser_test_runner to use typ as the test runner (patchset #3 id:60001 of https://codereview.chromium.org/2671483002/ )
2017-02-06 nednguyen [Telemetry] Migrate browser_test_runner to use typ as the test runner

BUG=618698, 636153 , 636153 

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2680573002
Cr-Commit-Position: refs/heads/master@{#448387}

[modify] https://crrev.com/ee2c2fb24cec1241e84612fa9e104c626e75f565/DEPS

Project Member

Comment 26 by bugdroid1@chromium.org, Feb 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a2d8f5fb7bcb0be7557e9e8b5ff66c627ccb19f3

commit a2d8f5fb7bcb0be7557e9e8b5ff66c627ccb19f3
Author: catapult-deps-roller <catapult-deps-roller@chromium.org>
Date: Tue Feb 07 03:58:12 2017

Roll src/third_party/catapult/ a448b4b83..df67b4791 (4 commits).

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/a448b4b8357a..df67b4791114

$ git log a448b4b83..df67b4791 --date=short --no-merges --format='%ad %ae %s'
2017-02-06 nednguyen Revert of [Telemetry] Migrate browser_test_runner to use typ as the test runner (patchset #2 id:20001 of https://codereview.chromium.org/2671383003/ )
2017-02-06 nednguyen [Telemetry] Migrate browser_test_runner to use typ as the test runner
2017-02-06 dtu [pinpoint] Move taskqueue logic into the Job class.
2017-02-06 dtu Add google-endpoints to third_party/.

BUG= 636153 , 636153 

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2678013004
Cr-Commit-Position: refs/heads/master@{#448538}

[modify] https://crrev.com/a2d8f5fb7bcb0be7557e9e8b5ff66c627ccb19f3/DEPS

Comment 27 by kbr@chromium.org, Feb 8 2017

Blockedon: 689788
Blockedon: 690011
Labels: Build-Tools-TYP

Comment 30 by kbr@chromium.org, Feb 16 2017

Cc: oetu...@nvidia.com
Status: Started (was: Assigned)

Comment 31 by kbr@chromium.org, Feb 17 2017

Blockedon: 693296
Project Member

Comment 32 by bugdroid1@chromium.org, Feb 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e86fbe70bbe580990957eca6a00531bd421358c9

commit e86fbe70bbe580990957eca6a00531bd421358c9
Author: catapult-deps-roller <catapult-deps-roller@chromium.org>
Date: Sun Feb 19 03:45:52 2017

Roll src/third_party/catapult/ 36a508280..84a7af661 (27 commits).

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/36a50828018d..84a7af661032

$ git log 36a508280..84a7af661 --date=short --no-merges --format='%ad %ae %s'
2017-02-17 dtu Use third-party libraries in Catapult instead of the App Engine SDK.
2017-02-17 jessimb Adjusting css to make group by counter work for 3 numbers.
2017-02-17 jessimb Allow a user to enter a milestone param to view the table.
2017-02-17 jessimb Added new index for Anomaly.
2017-02-17 nednguyen Revert of [Telemetry] Migrate browser_test_runner to use typ as the test runner (patchset #1 id:1 of https://codereview.chromium.org/2700563004/ )
2017-02-17 sullivan First version of benchmark health report.
2017-02-17 benjhayden Remove storyRepeatCounter.
2017-02-17 benjhayden Merge RelatedHistogram diagnostics.
2017-02-17 mikecase Fix for improper call to ps on Android versions greater than N.
2017-02-17 ulan Make estimatedInputLatency metric more friendly for traces without TTI.
2017-02-17 erikchen Use absolute pcs and load locations to symbolize on macOS.
2017-02-17 erikchen Fix a bug introduced in a refactor to the ELFSymbolizer.
2017-02-17 nednguyen [Telemetry] Remove --page-repeat flag
2017-02-17 hjd [dashboard] Avoid double XHR in /report
2017-02-16 dtu [pinpoint] Add Job.job_id property.
2017-02-16 nednguyen Roll typ v0.9.5 -> v0.9.11 (a277897604718c..f6afa2bbd1765b21e8)
2017-02-16 eakuefner [Dashboard] Only validate row_id for first row in add_point
2017-02-16 eakuefner [Dashboard] Use list_tests.GetTestsForTestPathDict in /graph_json
2017-02-16 eakuefner [Dashboard] Add test for listing tests with empty selection in test_path_dict
2017-02-16 benjhayden Fix merging Diagnostics.
2017-02-16 benjhayden Add CollectedRelatedEventSet diagnostic.
2017-02-16 eakuefner [Dashboard] Add capability for querying unselected tests by test_path_dict
2017-02-16 nednguyen [Telemetry] Migrate browser_test_runner to use typ as the test runner
2017-02-16 eakuefner [Dashboard] Add 'test_path_dict' request type to /list_tests
2017-02-16 benjhayden Replace values with histograms in metric_map_function.
2017-02-16 rnephew [WPR] Add log message when downloading archives.
2017-02-16 alexandermont Separate "time interval" from "metric collection" logic in power_metrics.html.

Created with:
  roll-dep src/third_party/catapult
BUG= 636153 ,625701, 677302 , 677302 , 689788 , 636153 

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2705883002
Cr-Commit-Position: refs/heads/master@{#451509}

[modify] https://crrev.com/e86fbe70bbe580990957eca6a00531bd421358c9/DEPS

Comment 33 by kbr@chromium.org, Feb 21 2017

Blockedon: 694359
Project Member

Comment 34 by bugdroid1@chromium.org, Feb 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c96661cd7d066e3f4d6fe8b9760661ff76ea005

commit 3c96661cd7d066e3f4d6fe8b9760661ff76ea005
Author: catapult-deps-roller <catapult-deps-roller@chromium.org>
Date: Wed Feb 22 09:17:23 2017

Roll src/third_party/catapult/ d9036c9b7..e56eec861 (13 commits).

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/d9036c9b7e3d..e56eec86141a

$ git log d9036c9b7..e56eec861 --date=short --no-merges --format='%ad %ae %s'
2017-02-21 nednguyen Revert of [Telemetry] Migrate browser_test_runner to use typ as the test runner (patchset #1 id:1 of https://codereview.chromium.org/2701253008/ )
2017-02-21 jbudorick [devil] Add an iteration timeout option to cmd_helper.IterCmdStdoutLines.
2017-02-21 benjhayden Update style in value/ui/.
2017-02-21 benjhayden Dedent CSS in histogram_set_view.
2017-02-21 benjhayden Fix merged relationships in histogram-set-table.
2017-02-21 benjhayden Merge sample diagnostics.
2017-02-21 nednguyen Reland of [Telemetry] Migrate browser_test_runner to use typ as the test runner (patchset #1 id:1 of https://codereview.chromium.org/2700263002/ )
2017-02-21 benjhayden Update style in tab_view.html.
2017-02-21 benjhayden Allow toggling merged-telemetry-info-span.
2017-02-21 benjhayden Document createScalarSpan.
2017-02-21 charliea Update the update_v8 script and roll d8 on Windows to stable
2017-02-21 perezju [Devil] Improve error message for pull failure
2017-02-21 sebmarchand Use pgosweep.exe from the build directory if it's available

Created with:
  roll-dep src/third_party/catapult
BUG= 636153 , 693203 , 636153 , 693714 

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2710903002
Cr-Commit-Position: refs/heads/master@{#451952}

[modify] https://crrev.com/3c96661cd7d066e3f4d6fe8b9760661ff76ea005/DEPS

Project Member

Comment 35 by bugdroid1@chromium.org, Feb 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ecdf404b0186581b08828eb1db2caa3b88b336f9

commit ecdf404b0186581b08828eb1db2caa3b88b336f9
Author: nednguyen <nednguyen@google.com>
Date: Wed Feb 22 23:28:50 2017

Roll out framework change & update gpu tests to conform to the API changes

The changes include in this roll:
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/2242f1ab32bac4e1884b..42d9cffaa797712c58d7b5fb

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

BUG= 636153 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2663813003
Cr-Commit-Position: refs/heads/master@{#452269}

[modify] https://crrev.com/ecdf404b0186581b08828eb1db2caa3b88b336f9/DEPS
[modify] https://crrev.com/ecdf404b0186581b08828eb1db2caa3b88b336f9/content/test/gpu/gpu_tests/context_lost_integration_test.py
[modify] https://crrev.com/ecdf404b0186581b08828eb1db2caa3b88b336f9/content/test/gpu/gpu_tests/depth_capture_integration_test.py
[modify] https://crrev.com/ecdf404b0186581b08828eb1db2caa3b88b336f9/content/test/gpu/gpu_tests/gpu_integration_test_unittest.py
[modify] https://crrev.com/ecdf404b0186581b08828eb1db2caa3b88b336f9/content/test/gpu/gpu_tests/gpu_process_integration_test.py
[modify] https://crrev.com/ecdf404b0186581b08828eb1db2caa3b88b336f9/content/test/gpu/gpu_tests/hardware_accelerated_feature_integration_test.py
[modify] https://crrev.com/ecdf404b0186581b08828eb1db2caa3b88b336f9/content/test/gpu/gpu_tests/maps_integration_test.py
[modify] https://crrev.com/ecdf404b0186581b08828eb1db2caa3b88b336f9/content/test/gpu/gpu_tests/pixel_integration_test.py
[modify] https://crrev.com/ecdf404b0186581b08828eb1db2caa3b88b336f9/content/test/gpu/gpu_tests/screenshot_sync_integration_test.py
[modify] https://crrev.com/ecdf404b0186581b08828eb1db2caa3b88b336f9/content/test/gpu/gpu_tests/trace_integration_test.py
[modify] https://crrev.com/ecdf404b0186581b08828eb1db2caa3b88b336f9/content/test/gpu/gpu_tests/webgl_conformance_integration_test.py
[modify] https://crrev.com/ecdf404b0186581b08828eb1db2caa3b88b336f9/content/test/gpu/run_gpu_integration_test.py
[add] https://crrev.com/ecdf404b0186581b08828eb1db2caa3b88b336f9/content/test/gpu/unittest_data/__init__.py
[add] https://crrev.com/ecdf404b0186581b08828eb1db2caa3b88b336f9/content/test/gpu/unittest_data/integration_tests.py
[modify] https://crrev.com/ecdf404b0186581b08828eb1db2caa3b88b336f9/testing/scripts/run_gpu_integration_test_as_googletest.py

Status: Fixed (was: Started)

Comment 37 by kbr@chromium.org, Feb 23 2017

Thank you Ned and Dirk for making this tremendous switchover!!!

Project Member

Comment 38 by bugdroid1@chromium.org, Feb 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/85a8ce8dd67e4ed84fa7846b3f47f2b8b45b906e

commit 85a8ce8dd67e4ed84fa7846b3f47f2b8b45b906e
Author: kbr <kbr@chromium.org>
Date: Thu Feb 23 02:59:22 2017

Update script which gathers test run times for typ switchover.

The script was correctly merging the tries, but needed to specifically
extract the per-test run times.

BUG= 636153 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2708803002
Cr-Commit-Position: refs/heads/master@{#452362}

[modify] https://crrev.com/85a8ce8dd67e4ed84fa7846b3f47f2b8b45b906e/content/test/gpu/gather_swarming_json_results.py

Comment 39 by kbr@chromium.org, Feb 23 2017

Blocking: 695334

Comment 40 by kbr@chromium.org, Feb 27 2017

Blocking: 690085
Blocking: 696656

Comment 42 by kbr@chromium.org, Feb 28 2017

Blockedon: -690011 -694359
Blocking: 690011 694359
Blocking: 698902

Comment 44 by kbr@chromium.org, May 7 2017

 Issue 406623  has been merged into this issue.

Sign in to add a comment