New issue
Advanced search Search tips

Issue 636139 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature



Sign in to add a comment

Merge chromium and blink geometry classes

Project Member Reported by loyso@chromium.org, Aug 9 2016

Issue description

We need to merge the geometry classes (ui/gfx/geometry/) with the same in base/. 

Related animation-specific work:  http://crbug.com/577016  (the part for gfx::CubicBezier unification)

This is a tracking bug.
 
> with the same in base/. 

That should say "in blink", for future curious readers.

Comment 2 by loyso@google.com, Aug 9 2016

Probably related:

Previously, the idea was to add WebFoo to gfx::Foo conversion operators for the case like this:
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/platform/animation/CompositorScrollOffsetAnimationCurve.cpp?type=cs&q=CompositorScrollOffsetAnimationCurve.cpp&sq=package:chromium&l=76

Anyway, we need to unify platform/geometry/FloatPoint.h and WebPoint and gfx::Point/gfx::ScrollOffset.
Please make sure the same things are inline, extra copies aren't introduced, we keep the inline assembly versions, etc. :)
Project Member

Comment 4 by sheriffbot@chromium.org, Aug 10 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by e...@chromium.org, Aug 10 2017

Cc: -esprehn@chromium.org jsc...@chromium.org
Status: Available (was: Untriaged)
I am interested to work on this.
Can someone guide me?
Thanks
Have you read the blink-dev thread on using gfx types in blink? I think that laid out thoughts on how to move forward.
Project Member

Comment 8 by sheriffbot@chromium.org, Nov 5

Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Available (was: Untriaged)

Sign in to add a comment