Issue metadata
Sign in to add a comment
|
libFuzzer builds falling on Mac |
||||||||||||||||||||||
Issue descriptionI believe this is related to the clang roll on Sunday but I'm not sure. Regardless, every build since then has failed. https://build.chromium.org/p/chromium.fyi/builders/Libfuzzer%20Upload%20Mac%20ASan?numbuilds=200 The last build that was displayed was on Aug 8th (the day of the clang roll), I couldn't tell if builds before that were also broken.
,
Aug 9 2016
,
Aug 9 2016
Actually the most recent error looks more like an rtti thing in icu...jshin touched that recently. I'd be surprised if this is due to the roll. But yeah, I'm out until the 21. Ccing a few folks.
,
Aug 10 2016
,
Aug 10 2016
,
Aug 10 2016
I may suggest to revert jshin@'s roll of ICU (https://codereview.chromium.org/2229733004), but I don't see anything in those 3 CLs (https://chromium.googlesource.com/chromium/deps/icu.git/+log/ef5c7353..53ce6316) which could affect this. I'm looking more into this.
,
Aug 10 2016
Ah, yes, it happened exactly after clang roll and earlier than ICU roll.
,
Aug 10 2016
Not sure if it's worth for me to try to fix it, or jshin@ can fix it faster? Anyway, I'm checking out the repo on my macbook air in the background.
,
Aug 10 2016
The linking issue happens due to usage of typeid operator. Do we use an out-of-date version of libc++ for Mac OS X?
,
Aug 10 2016
Adding of "//buildtools/third_party/libc++abi" to deps of component("icuuc") resolved problem for me.
,
Aug 10 2016
Sadly, src/third_party/icu/BUILD.gn file is stored in icu.git repo, so I probably cannot simply add that dependency from chromium repo. jshin@, what would be the best solution here?
,
Aug 11 2016
Jshin@, can you please fix as per c#10, c#11. This is causing compile failures on mac libfuzzer.
,
Aug 11 2016
,
Aug 16 2016
> src/third_party/icu/BUILD.gn file is stored in icu.git repo, so I probably cannot > simply add that dependency from chromium repo. jshin@, what would be the best > solution here? Am I right that eventually something should be done on the clang side? I have little idea what ICU can do about it other than what you tried? BTW, I can't send a tryjob to a failing builder. (a speculative CL is at https://codereview.chromium.org/2247953005 - based on your comment 10 + my guess). $ git cl try -b 'Libfuzzer Upload Mac ASan' ERROR: Access denied: User user:jshin@chromium.org cannot add builds to bucket master.chromium.fyi
,
Aug 17 2016
+1, I believe that something on the clang side should be done. I wonder, if anybody else has the same issue after the roll.
,
Aug 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/deps/icu.git/+/2341038bf72869a5683a893a2b319a48ffec7f62 commit 2341038bf72869a5683a893a2b319a48ffec7f62 Author: Jungshik Shin <jshin@chromium.org> Date: Wed Aug 17 16:34:56 2016 Fix fuzzer build on Mac for ICU Make icu depend on //buildtools/third_party/libc++abi on mac for sanitizer builds. BUG= 636127 TEST=Libfuzzer Upload Mac ASan builds R=mmoroz@chromium.org Review URL: https://codereview.chromium.org/2247953005 . [modify] https://crrev.com/2341038bf72869a5683a893a2b319a48ffec7f62/BUILD.gn
,
Aug 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/95efca8c457bdf81e36229fe252edef2b26daf52 commit 95efca8c457bdf81e36229fe252edef2b26daf52 Author: jshin <jshin@chromium.org> Date: Wed Aug 17 18:47:27 2016 Roll ICU to 2341038b Fix libfuzz builds on Mac. There's only one change in this roll. https://chromium.googlesource.com/chromium/deps/icu/+/2341038b BUG= 636127 TEST=Libfuzzer Upload Mac ASan builds TBR=mmoroz@chromium.org Review-Url: https://codereview.chromium.org/2254543005 Cr-Commit-Position: refs/heads/master@{#412598} [modify] https://crrev.com/95efca8c457bdf81e36229fe252edef2b26daf52/DEPS
,
Aug 17 2016
The build is green (https://build.chromium.org/p/chromium.fyi/builders/Libfuzzer%20Upload%20Mac%20ASan?numbuilds=200), thanks! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by rsesek@chromium.org
, Aug 9 2016Owner: thakis@chromium.org
Status: Assigned (was: Untriaged)