New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 636127 link

Starred by 1 user

Issue metadata

Status: Fixed
Merged: issue 635952
Owner:
Closed: Aug 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 0
Type: Bug

Blocking:
issue 539572



Sign in to add a comment

libFuzzer builds falling on Mac

Project Member Reported by metzman@google.com, Aug 9 2016

Issue description

I believe this is related to the clang roll on Sunday but I'm not sure.
Regardless, every build since then has failed. 

https://build.chromium.org/p/chromium.fyi/builders/Libfuzzer%20Upload%20Mac%20ASan?numbuilds=200

The last build that was displayed was on Aug 8th (the day of the clang roll), I couldn't tell if builds before that were also broken.
 
Cc: rsesek@chromium.org
Owner: thakis@chromium.org
Status: Assigned (was: Untriaged)
Confirmed that it happened in this build: https://build.chromium.org/p/chromium.fyi/builders/Libfuzzer%20Upload%20Mac%20ASan/builds/5496

I'm not the right person to own this, though. But thakis@ just went on vacation for two weeks...
Mergedinto: 635952
Status: Duplicate (was: Assigned)
Cc: h...@chromium.org kcc@chromium.org js...@chromium.org
Status: Untriaged (was: Duplicate)
Actually the most recent error looks more like an rtti thing in icu...jshin touched that recently. I'd be surprised if this is due to the roll.

But yeah, I'm out until the 21. Ccing a few folks.

Comment 4 by aarya@google.com, Aug 10 2016

Owner: mmoroz@chromium.org
Project Member

Comment 5 by sheriffbot@chromium.org, Aug 10 2016

Labels: Hotlist-Google

Comment 6 by mmoroz@google.com, Aug 10 2016

I may suggest to revert jshin@'s roll of ICU (https://codereview.chromium.org/2229733004), but I don't see anything in those 3 CLs (https://chromium.googlesource.com/chromium/deps/icu.git/+log/ef5c7353..53ce6316) which could affect this.

I'm looking more into this.

Comment 7 by mmoroz@google.com, Aug 10 2016

Ah, yes, it happened exactly after clang roll and earlier than ICU roll.

Comment 8 by mmoroz@google.com, Aug 10 2016

Cc: -js...@chromium.org mmoroz@chromium.org
Labels: OS-Mac
Owner: js...@chromium.org
Not sure if it's worth for me to try to fix it, or jshin@ can fix it faster?

Anyway, I'm checking out the repo on my macbook air in the background.

Comment 9 by mmoroz@chromium.org, Aug 10 2016

The linking issue happens due to usage of typeid operator. Do we use an out-of-date version of libc++ for Mac OS X?
Adding of "//buildtools/third_party/libc++abi" to deps of component("icuuc") resolved problem for me.
Status: Assigned (was: Untriaged)
Sadly, src/third_party/icu/BUILD.gn file is stored in icu.git repo, so I probably cannot simply add that dependency from chromium repo. jshin@, what would be the best solution here?
Labels: -Pri-3 Pri-0
Jshin@, can you please fix as per c#10, c#11. This is causing compile failures on mac libfuzzer.
Cc: infe...@chromium.org

Comment 14 by js...@chromium.org, Aug 16 2016


> src/third_party/icu/BUILD.gn file is stored in icu.git repo, so I probably cannot 
> simply add that dependency from chromium repo. jshin@, what would be the best
> solution here?

Am I right that eventually something should be done on the clang side? I have little idea what ICU can do about it other than what you tried? 

BTW, I can't send a tryjob to a failing builder. (a speculative CL is at https://codereview.chromium.org/2247953005  - based on your comment 10 + my guess). 

$ git cl try -b 'Libfuzzer Upload Mac ASan' 
ERROR: Access denied: User user:jshin@chromium.org cannot add builds to bucket master.chromium.fyi

+1, I believe that something on the clang side should be done. I wonder, if anybody else has the same issue after the roll.
Project Member

Comment 16 by bugdroid1@chromium.org, Aug 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/deps/icu.git/+/2341038bf72869a5683a893a2b319a48ffec7f62

commit 2341038bf72869a5683a893a2b319a48ffec7f62
Author: Jungshik Shin <jshin@chromium.org>
Date: Wed Aug 17 16:34:56 2016

Fix fuzzer build on Mac for ICU

Make icu depend on //buildtools/third_party/libc++abi
on mac for sanitizer builds.

BUG= 636127 
TEST=Libfuzzer Upload Mac ASan builds
R=mmoroz@chromium.org

Review URL: https://codereview.chromium.org/2247953005 .

[modify] https://crrev.com/2341038bf72869a5683a893a2b319a48ffec7f62/BUILD.gn

Project Member

Comment 17 by bugdroid1@chromium.org, Aug 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95efca8c457bdf81e36229fe252edef2b26daf52

commit 95efca8c457bdf81e36229fe252edef2b26daf52
Author: jshin <jshin@chromium.org>
Date: Wed Aug 17 18:47:27 2016

Roll ICU to  2341038b

Fix libfuzz builds on Mac.

There's only one change in this roll.
https://chromium.googlesource.com/chromium/deps/icu/+/2341038b

BUG= 636127 
TEST=Libfuzzer Upload Mac ASan builds
TBR=mmoroz@chromium.org

Review-Url: https://codereview.chromium.org/2254543005
Cr-Commit-Position: refs/heads/master@{#412598}

[modify] https://crrev.com/95efca8c457bdf81e36229fe252edef2b26daf52/DEPS

Status: Fixed (was: Assigned)
The build is green (https://build.chromium.org/p/chromium.fyi/builders/Libfuzzer%20Upload%20Mac%20ASan?numbuilds=200), thanks!

Sign in to add a comment