New issue
Advanced search Search tips

Issue 636124 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

WebInputEventConversionTest.PlatformGestureEventBuilder flaky fails with weburl_loader_mock_factory_impl.cc(48)] Check failed: url_to_reponse_info_.find(url) == url_to_reponse_info_.end()

Project Member Reported by esprehn@chromium.org, Aug 9 2016

Issue description

[ RUN      ] WebInputEventConversionTest.PlatformGestureEventBuilder
[17699:1287:0809/144439:2462381266420:FATAL:weburl_loader_mock_factory_impl.cc(48)] Check failed: url_to_reponse_info_.find(url) == url_to_reponse_info_.end(). 
0   webkit_unit_tests                   0x0000000110a270d3 _ZN4base5debug10StackTraceC1Ev + 19
1   webkit_unit_tests                   0x0000000110a479c7 _ZN7logging10LogMessageD2Ev + 71
2   webkit_unit_tests                   0x000000011110ba04 _ZN5blink27WebURLLoaderMockFactoryImpl11registerURLERKNS_6WebURLERKNS_14WebURLResponseERKNS_9WebStringE + 436
3   webkit_unit_tests                   0x0000000111108daf _ZN5blink14URLTestHelpers39registerMockedURLLoadWithCustomResponseERKNS_6WebURLERKNS_9WebStringES6_NS_14WebURLResponseE + 287
4   webkit_unit_tests                   0x0000000111108b7b _ZN5blink14URLTestHelpers21registerMockedURLLoadERKNS_6WebURLERKNS_9WebStringES6_S6_ + 139
5   webkit_unit_tests                   0x0000000111108a0a _ZN5blink14URLTestHelpers28registerMockedURLFromBaseURLERKNS_9WebStringES3_S3_ + 506
6   webkit_unit_tests                   0x000000010e92a42c _ZN5blink60WebInputEventConversionTest_PlatformGestureEventBuilder_Test8TestBodyEv + 204
7   webkit_unit_tests                   0x0000000110b70a6a _ZN7testing4Test3RunEv + 474
8   webkit_unit_tests                   0x0000000110b71654 _ZN7testing8TestInfo3RunEv + 404
9   webkit_unit_tests                   0x0000000110b71cd3 _ZN7testing8TestCase3RunEv + 451
10  webkit_unit_tests                   0x0000000110b78f39 _ZN7testing8internal12UnitTestImpl11RunAllTestsEv + 825
11  webkit_unit_tests                   0x0000000110b78bcd _ZN7testing8UnitTest3RunEv + 269
12  webkit_unit_tests                   0x0000000110aff24f _ZN4base9TestSuite3RunEv + 127
13  webkit_unit_tests                   0x000000010e6c2c44 _ZN12_GLOBAL__N_19runHelperEPN4base9TestSuiteE + 36
14  webkit_unit_tests                   0x0000000110b0b989 _ZN4base15LaunchUnitTestsEiPPcRKNS_8CallbackIFivELNS_8internal8CopyModeE1EEE + 137
15  webkit_unit_tests                   0x000000010e6c2bfb main + 123
16  webkit_unit_tests                   0x000000010e6c2b74 start + 52

 
Owner: dtapu...@chromium.org
Over to dtapuska@ (input-dev co-lead) for triage.
Labels: Hotlist-Input-Dev
Status: Started (was: Untriaged)
I noticed this the other day while testing my CL for phase on wheel events.

I observed that if I ran *all* the WebInputEventConversionTest suit together (on my Mac) that it *always* failed for me. However, running the test by itself always passed. So perhaps it's some state that gets carried over from previous tests? If the order in which the tests get run changes, that might explain why it shows up as flaky also.
The URI changes between each test. The gesture test uses a URI with another test and that causes a crash.
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2724e8b0d322f96ac95bc02d31fcc7594699bb56

commit 2724e8b0d322f96ac95bc02d31fcc7594699bb56
Author: dtapuska <dtapuska@chromium.org>
Date: Wed Aug 10 18:40:25 2016

Fix flaky PlatformGestureEventBuilder test

Ensure that the test uses a different URI so it doesn't conflict with
other tests. Fix copied from (https://codereview.chromium.org/1302313008)

BUG= 636124 

Review-Url: https://codereview.chromium.org/2229243004
Cr-Commit-Position: refs/heads/master@{#411098}

[modify] https://crrev.com/2724e8b0d322f96ac95bc02d31fcc7594699bb56/third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp

Status: Fixed (was: Started)
Flakiness dashboard is now showing it isn't flaky. Marking as fixed.

Sign in to add a comment