toolbar bottom stroke is 2px at 1.5 dsf with detached bookmark bar |
||||
Issue descriptionOS: Windows 10 but probably other versions too At 1.5 dsf the toolbar bottom stroke is 2px on the new tab page because of the detached bookmark bar. It looks really odd because it's supposed to be a hairline. I suspect it's because BookmarkBarView is laying things out in DIPs and then its position is rounding up, but then I would expect it to be incorrect at 2x dsf, but it looks fine there.
,
Aug 11 2016
,
Aug 19 2016
I accidentally figured out how to fix this so I may as well finished the job.
,
Aug 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/af9ecebdf6e165d4e0742c14bd16ec380124bb91 commit af9ecebdf6e165d4e0742c14bd16ec380124bb91 Author: bsep <bsep@chromium.org> Date: Fri Aug 19 19:36:30 2016 Fix the toolbar bottom border being 2 pixels w/ a detached bookmark bar. The toolbar draws a 1 pixel line as its bottom border. The detached bookmark bar also draws a 1 pixel line as its top border. At 1x and 2x those lines always overlap. But the bookmark bar top stroke was not laid out properly so at fractional dsfs it would be pushed down 1 pixel and cause the border to look like it was 2 pixels. I removed the bookmark bar top stroke since it was redundant anyway. R=pkasting BUG= 636120 Review-Url: https://codereview.chromium.org/2255313004 Cr-Commit-Position: refs/heads/master@{#413211} [modify] https://crrev.com/af9ecebdf6e165d4e0742c14bd16ec380124bb91/chrome/browser/ui/views/frame/browser_view.cc
,
Aug 19 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by bsep@chromium.org
, Aug 9 201610.6 KB
10.6 KB View Download