New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 636119 link

Starred by 2 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

PlzNavigate: don't cancel the request when the speculative RFH's process dies before commit.

Project Member Reported by alex...@chromium.org, Aug 9 2016

Issue description

I'm filing this as a follow-up issue to https://codereview.chromium.org/2226023003/.  In that CL, I'm changing both pending and speculative RFHs to be reset if their process dies before commit.  However, in the PlzNavigate case, I also had to clear the current navigation request [1], due to hitting the following DCHECK in NavigationRequest::OnStartChecksComplete in my new tests:

  RenderFrameHostImpl* navigating_frame_host =
      associated_site_instance_type_ == AssociatedSiteInstanceType::SPECULATIVE
          ? frame_tree_node_->render_manager()->speculative_frame_host()
          : frame_tree_node_->current_frame_host();
  DCHECK(navigating_frame_host);

Canceling the request shouldn't really be necessary.  Instead, we can probably check whether the speculative/current RFH died during the request and recreate the RFH accordingly.

[1] https://codereview.chromium.org/2226023003/diff/20001/content/browser/frame_host/render_frame_host_manager.cc#newcode1037
 

Comment 1 by nasko@chromium.org, May 18 2017

Labels: Proj-PlzNavigate
Project Member

Comment 2 by sheriffbot@chromium.org, May 18 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment