class string of PaymentRequest.prototype expected "[object PaymentRequestPrototype]" but got "[object PaymentRequest]" etc
Reported by
sideshowbarker@gmail.com,
Aug 9 2016
|
||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2825.0 Safari/537.36 Steps to reproduce the problem: 1. Run the https://w3c-test.org/submissions/3439/payment-request/interfaces.https.html test file What is the expected behavior? Expected behavior is that Blink should conform the WebIDL requirements and pass the tests What went wrong? Observed behavior: Three failures all of the same form: * assert_equals: class string of PaymentRequest.prototype expected "[object PaymentRequestPrototype]" but got "[object PaymentRequest]" * assert_equals: class string of PaymentResponse.prototype expected "[object PaymentResponsePrototype]" but got "[object PaymentResponse]" * assert_equals: class string of PaymentAddress.prototype expected "[object PaymentAddressPrototype]" but got "[object PaymentAddress]" Did this work before? N/A Chrome version: 54.0.2825.0 Channel: canary OS Version: OS X 10.11.6 Flash Version: This seems to be a general issue in Blink’s WebIDL conformance; see https://bugs.chromium.org/p/chromium/issues/detail?id=635694
,
Aug 9 2016
,
Aug 11 2016
,
Aug 11 2016
I can't access https://w3c-test.org/submissions/3439/payment-request/interfaces.https.html . Wrong url?
,
Aug 11 2016
This is intentional behavior; the tests are wrong here. We still need to fix the Web IDL spec in this regard; the bug for that is https://www.w3.org/Bugs/Public/show_bug.cgi?id=28244. Firefox is also aligning with us/the future spec in this regard: https://groups.google.com/forum/#!searchin/mozilla.dev.platform/toStringTag%7Csort:relevance/mozilla.dev.platform/IZNh8QAXkFA/me59gpo5PgAJ As such, going to mark WontFix. I hope someone can file a bug on the upstream tests.
,
Aug 11 2016
> Firefox is also aligning with us/the future spec in this regard: https://groups.google.com/forum/#!searchin/mozilla.dev.platform/toStringTag%7Csort:relevance/mozilla.dev.platform/IZNh8QAXkFA/me59gpo5PgAJ Actually I see that bz just now posted there this follow-up comment: > It's not clear what Firefox will be doing here, if anything. There was pushback to the intent to ship on general grounds of web developer confusion and there are unclear issues around compat. I personally have put the whole thing on indefinite hold for the moment and have no plans to pick it up. > I hope someone can file a bug on the upstream tests. I have no plans to change the tests unless it is clear that they don’t conform to the requirements in the WebIDL spec. But as far as I can tell at this point, they do conform to the WebIDL spec. So it seems that want needs to be done here is to actually get the WebIDL spec changed. But in the mean time, Blink is a non-conforming and it is not clear that Firefox will be changing to match the Blink behavior any time soon.
,
Aug 11 2016
To be clear, the link I meant to cite for that comment from bz is https://www.w3.org/Bugs/Public/show_bug.cgi?id=28244#c8
,
Aug 11 2016
> I can't access https://w3c-test.org/submissions/3439/payment-request/interfaces.https.html . Wrong url? Oofs—The tests have been merged to master, so they can now be run from here: https://w3c-test.org/payment-request/interfaces.https.html And the test source is here: https://github.com/w3c/web-platform-tests/blob/master/payment-request/interfaces.https.html
,
Aug 11 2016
For the record here, to get the test results for this changed, there’s nothing possible to change in the individual tests themselves; instead the change would need to be made in the sources of the common testing infrastructure they use for WebIDL testing, which is: https://github.com/w3c/testharness.js/blob/master/idlharness.js https://github.com/w3c/webidl2.js |
||||
►
Sign in to add a comment |
||||
Comment 1 by ligim...@chromium.org
, Aug 9 2016