SVG elements are missing .dataset property
Reported by
cvreb...@gmail.com,
Aug 9 2016
|
||||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2743.116 Safari/537.36 Steps to reproduce the problem: 1. Open http://jsbin.com/butikiromu/edit?html,js,console in Chrome. 2. Observe the output in the Console pane. What is the expected behavior? Expected Output: #div's dataset = [object DOMStringMap] #cirque's dataset = [object DOMStringMap] What went wrong? Actual Output: #div's dataset = [object DOMStringMap] #cirque's dataset = undefined (Which indicates that the SVG <circle> element lacks a .dataset DOM property.) Did this work before? Yes Chrome<=44 Chrome version: 52.0.2743.116 Channel: stable OS Version: N/A Flash Version: Shockwave Flash 22.0 r0 The SVGElement.dataset property and data-* attribute support were added to the current SVG2 spec draft circa January: * https://github.com/w3c/svgwg/commit/1cb4ee9e165b3d777d33828da8fa757e67d019ff * https://svgwg.org/svg2-draft/types.html#__svg__SVGElement__dataset * http://stackoverflow.com/a/30519648 Does this work in other browsers? (See Note #1 on http://caniuse.com/#feat=dataset ) Safari/WebKit: Yes Chrome<=44: Yes Chrome>=45: No Firefox: No, https://bugzil.la/921834 MS Edge: No
,
Aug 10 2016
Able to reproduce this on the latest canary(54.0.2825.0) and the latest stable(52.0.2743.116) on Windows-7, Mac OS 10.11.5 and Linux Ubuntu 14.04. This is a regression issue broken in M-45 Last good build: 45.0.2434.0 First bad build: 45.0.2435.0 Changelog: https://chromium.googlesource.com/chromium/src/+log/5c20728c7e8a7692877c01190ed624b94b8e2527..6314a888bf702522b34f7d89aa59b55ce97a31c2 Blink changelog: https://chromium.googlesource.com/chromium/blink/+log/40bf78a..bd501f2 Suspected change: https://codereview.chromium.org/1189663004 ramya.v@: Could you please take a look at this. Thank you!
,
Aug 10 2016
@Philip From the bug its reported that dataset is added back to svg2 spec (which is in draft stage) and current chrome is behaving similar to firefox and IE. Is it the right time to revert back https://codereview.chromium.org/1189663004 ?
,
Aug 10 2016
In Gecko, I plan to put this on HTMLElement and SVGElement but NOT Element.
,
Aug 10 2016
HTMLElement+SVGElement sounds right per the specs: https://svgwg.org/svg2-draft/types.html#InterfaceSVGElement https://html.spec.whatwg.org/multipage/dom.html#htmlelement So reverting https://codereview.chromium.org/1189663004 wouldn't be right, rather it's adding dataset to SVGElement.idl.
,
Aug 12 2016
Added a patch at https://codereview.chromium.org/2231053003/ and Intent to Implement link: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/zXlpFPXhyvE
,
Aug 22 2016
,
Aug 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/25105789b773639799f91afaff54dec8f63b023c commit 25105789b773639799f91afaff54dec8f63b023c Author: ramya.v <ramya.v@samsung.com> Date: Fri Aug 26 05:26:02 2016 Add dataset property to SVGElement interface. Spec: https://svgwg.org/svg2-draft/types.html#InterfaceSVGElement BUG= 636108 Review-Url: https://codereview.chromium.org/2231053003 Cr-Commit-Position: refs/heads/master@{#414654} [delete] https://crrev.com/bf4a3293e2eefe2e47539b7b81f288b50dfeb05f/third_party/WebKit/LayoutTests/fast/dom/dataset-expected.txt [modify] https://crrev.com/25105789b773639799f91afaff54dec8f63b023c/third_party/WebKit/LayoutTests/fast/dom/dataset.html [delete] https://crrev.com/bf4a3293e2eefe2e47539b7b81f288b50dfeb05f/third_party/WebKit/LayoutTests/fast/dom/script-tests/dataset.js [modify] https://crrev.com/25105789b773639799f91afaff54dec8f63b023c/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/25105789b773639799f91afaff54dec8f63b023c/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/25105789b773639799f91afaff54dec8f63b023c/third_party/WebKit/Source/core/svg/SVGElement.idl
,
Aug 26 2016
,
Oct 25 2016
ChromeStatus indicates that this shipped in Chrome 54, but that doesn’t seem to be the case. Ramya, could you please confirm this and, if needed, update https://www.chromestatus.com/feature/5727911176830976?
,
Nov 19 2016
The feature is not in Chrome 54, but in Chrome 55 (beta)
,
Nov 19 2016
ChromeStatus updated, thanks.
,
Mar 2 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by ligim...@chromium.org
, Aug 9 2016