New issue
Advanced search Search tips

Issue 636107 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocked on:
issue 635373

Blocking:
issue 609258



Sign in to add a comment

Make installing a WebAPK add a homescreen icon

Project Member Reported by pkotw...@chromium.org, Aug 9 2016

Issue description

Make installing a WebAPK add a homescreen icon
 
Owner: yfried...@chromium.org
Status: Assigned (was: Untriaged)
Yaron, can you take this on?
Blockedon: 635373
sure! i think that rather than listening to package manager we can use startActivityForResult and get an intent after packageinstaller completes. This is blocked on  issue 635373 . Let me know if you want me to pick that up
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/723c87a310a6ed30e88292f046b2c19a1d33660f

commit 723c87a310a6ed30e88292f046b2c19a1d33660f
Author: hanxi <hanxi@chromium.org>
Date: Mon Aug 22 21:12:46 2016

[WebApk] Installation adds a homescreen shortcut.

Since installation is going through package installer directly and not
play, a shortcut isn't created. Add logic to listen for package
installation and manually create a shortcut (there is no callback/event
that can be listened to). Note if chrome is evicted, a shortcut won't be
created. As this is a temporary solution, it should be fine for now.
BUG= 636107 

Review-Url: https://codereview.chromium.org/2261343002
Cr-Commit-Position: refs/heads/master@{#413534}

[modify] https://crrev.com/723c87a310a6ed30e88292f046b2c19a1d33660f/chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java
[modify] https://crrev.com/723c87a310a6ed30e88292f046b2c19a1d33660f/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstaller.java

Comment 4 by hanxi@chromium.org, Sep 1 2016

Status: Fixed (was: Assigned)

Sign in to add a comment