New issue
Advanced search Search tips

Issue 636101 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: ----



Sign in to add a comment

Temporary files are permanently left on sdcard when download fails

Project Member Reported by qin...@chromium.org, Aug 9 2016

Issue description

Can repro this on trump with system DownloadManager disabled
Steps to reproduce:
(1) Download a file, when download starts, immediately kill Chrome
(2) Check the .crdownload file under /sdcard/Download
(3) Click cancel or resume button, download will fail, but the temporary .crdownlaod will linger forever on the sdcard

Expected result:
we should remove the .crdownload file if the download fails







 
Status: Assigned (was: Unconfirmed)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e8b7133f781db0fe40ba704b9655d16ba3c2be7e

commit e8b7133f781db0fe40ba704b9655d16ba3c2be7e
Author: qinmin <qinmin@chromium.org>
Date: Tue Aug 30 17:18:54 2016

Commit a new download to history db immediately on Android

If browser is killed when a download is just created, the
download is forever lost.
User can no longer resume the download.
And a temporary file is left forever on the disk.
On desktop platforms, this may not be a big issue as users
can easily go to the download dir to delete that file.
However, it is not very straight forward to access the file maanger.
This change commits the CreateDownload() to history db immediately on Android,
rather than waiting for the scheduled time interval.
This will greatly reduce the chance of the above problem, though
very unlikely possible.

BUG= 636101 

Review-Url: https://codereview.chromium.org/2292733002
Cr-Commit-Position: refs/heads/master@{#415334}

[modify] https://crrev.com/e8b7133f781db0fe40ba704b9655d16ba3c2be7e/components/history/core/browser/history_backend.cc

Comment 3 by qin...@chromium.org, Sep 13 2016

Status: Fixed (was: Assigned)

Sign in to add a comment