New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 636093 link

Starred by 1 user
Status: Fixed
Owner:
sdy@chromium.org
Closed: Aug 2016
Cc:
█ shrike@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Rename IsOSSierra(), etc. functions to include release numbers

Project Member Reported by shrike@chromium.org, Aug 9 2016 
It's increasingly difficult to remember the order of macOS releases by name, so these IsOSSierra()-style functions should be changed to add a version number or remove the release name completely (although it's probably worth keeping the name). Maybe replace OS with macOS.

First step is creating a small doc where we can discuss and converge on a naming scheme.

E.g. isMacOS12Sierra, ismacOS12.

Comment 1 by shrike@chromium.org, Aug 29 2016

Labels: -M-54 M-55
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07171a4c0cda43aa639f8b1b6ec28b46754e8ea5

commit 07171a4c0cda43aa639f8b1b6ec28b46754e8ea5
Author: sdy <sdy@chromium.org>
Date: Tue Aug 30 18:22:04 2016

base::mac::IsOSSierra() -> base::mac::IsOS10_12(), etc.

BUG= 636093 
TBR=jam@chromium.org

Review-Url: https://codereview.chromium.org/2271653006
Cr-Commit-Position: refs/heads/master@{#415359}

[modify] https://crrev.com/07171a4c0cda43aa639f8b1b6ec28b46754e8ea5/base/mac/mac_util.h
[modify] https://crrev.com/07171a4c0cda43aa639f8b1b6ec28b46754e8ea5/base/mac/mac_util.mm
[modify] https://crrev.com/07171a4c0cda43aa639f8b1b6ec28b46754e8ea5/base/mac/mac_util_unittest.mm
[modify] https://crrev.com/07171a4c0cda43aa639f8b1b6ec28b46754e8ea5/base/process/memory_mac.mm
[modify] https://crrev.com/07171a4c0cda43aa639f8b1b6ec28b46754e8ea5/base/sys_info_mac.mm
[modify] https://crrev.com/07171a4c0cda43aa639f8b1b6ec28b46754e8ea5/chrome/browser/app_controller_mac.mm
[modify] https://crrev.com/07171a4c0cda43aa639f8b1b6ec28b46754e8ea5/chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm
[modify] https://crrev.com/07171a4c0cda43aa639f8b1b6ec28b46754e8ea5/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm
[modify] https://crrev.com/07171a4c0cda43aa639f8b1b6ec28b46754e8ea5/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm
[modify] https://crrev.com/07171a4c0cda43aa639f8b1b6ec28b46754e8ea5/chrome/browser/ui/cocoa/browser_window_controller.mm
[modify] https://crrev.com/07171a4c0cda43aa639f8b1b6ec28b46754e8ea5/chrome/browser/ui/cocoa/browser_window_controller_private.mm
[modify] https://crrev.com/07171a4c0cda43aa639f8b1b6ec28b46754e8ea5/chrome/browser/ui/cocoa/browser_window_fullscreen_transition.mm
[modify] https://crrev.com/07171a4c0cda43aa639f8b1b6ec28b46754e8ea5/chrome/browser/ui/cocoa/browser_window_layout.mm
[modify] https://crrev.com/07171a4c0cda43aa639f8b1b6ec28b46754e8ea5/chrome/browser/ui/cocoa/custom_frame_view.mm
[modify] https://crrev.com/07171a4c0cda43aa639f8b1b6ec28b46754e8ea5/chrome/browser/ui/cocoa/custom_frame_view_unittest.mm
[modify] https://crrev.com/07171a4c0cda43aa639f8b1b6ec28b46754e8ea5/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.mm
[modify] https://crrev.com/07171a4c0cda43aa639f8b1b6ec28b46754e8ea5/chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm
[modify] https://crrev.com/07171a4c0cda43aa639f8b1b6ec28b46754e8ea5/chrome/browser/ui/cocoa/renderer_context_menu/render_view_context_menu_mac_browsertest.mm
[modify] https://crrev.com/07171a4c0cda43aa639f8b1b6ec28b46754e8ea5/chrome/browser/ui/cocoa/tabs/tab_strip_view.mm
[modify] https://crrev.com/07171a4c0cda43aa639f8b1b6ec28b46754e8ea5/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm
[modify] https://crrev.com/07171a4c0cda43aa639f8b1b6ec28b46754e8ea5/components/crash/content/app/breakpad_mac.mm
[modify] https://crrev.com/07171a4c0cda43aa639f8b1b6ec28b46754e8ea5/components/handoff/handoff_manager.mm
[modify] https://crrev.com/07171a4c0cda43aa639f8b1b6ec28b46754e8ea5/content/browser/accessibility/browser_accessibility_manager_mac.mm
[modify] https://crrev.com/07171a4c0cda43aa639f8b1b6ec28b46754e8ea5/content/browser/bootstrap_sandbox_manager_mac.cc
[modify] https://crrev.com/07171a4c0cda43aa639f8b1b6ec28b46754e8ea5/content/common/sandbox_mac.mm
[modify] https://crrev.com/07171a4c0cda43aa639f8b1b6ec28b46754e8ea5/content/renderer/renderer_main_platform_delegate_mac.mm
[modify] https://crrev.com/07171a4c0cda43aa639f8b1b6ec28b46754e8ea5/device/bluetooth/bluetooth_adapter_mac.mm
[modify] https://crrev.com/07171a4c0cda43aa639f8b1b6ec28b46754e8ea5/sandbox/mac/bootstrap_sandbox_unittest.mm
[modify] https://crrev.com/07171a4c0cda43aa639f8b1b6ec28b46754e8ea5/sandbox/mac/launchd_interception_server.cc
[modify] https://crrev.com/07171a4c0cda43aa639f8b1b6ec28b46754e8ea5/sandbox/mac/os_compatibility.cc
[modify] https://crrev.com/07171a4c0cda43aa639f8b1b6ec28b46754e8ea5/sandbox/mac/pre_exec_delegate.cc
[modify] https://crrev.com/07171a4c0cda43aa639f8b1b6ec28b46754e8ea5/third_party/WebKit/Source/core/layout/LayoutThemeMac.mm
[modify] https://crrev.com/07171a4c0cda43aa639f8b1b6ec28b46754e8ea5/third_party/WebKit/Source/platform/fonts/mac/FontFamilyMatcherMac.mm
[modify] https://crrev.com/07171a4c0cda43aa639f8b1b6ec28b46754e8ea5/third_party/WebKit/Source/platform/fonts/mac/FontFamilyMatcherMacTest.mm
[modify] https://crrev.com/07171a4c0cda43aa639f8b1b6ec28b46754e8ea5/third_party/WebKit/Source/platform/mac/VersionUtilMac.h
[modify] https://crrev.com/07171a4c0cda43aa639f8b1b6ec28b46754e8ea5/third_party/WebKit/Source/platform/mac/VersionUtilMac.mm
[modify] https://crrev.com/07171a4c0cda43aa639f8b1b6ec28b46754e8ea5/third_party/WebKit/Source/platform/mac/VersionUtilMacTest.mm
[modify] https://crrev.com/07171a4c0cda43aa639f8b1b6ec28b46754e8ea5/ui/base/cocoa/appkit_utils.mm
[modify] https://crrev.com/07171a4c0cda43aa639f8b1b6ec28b46754e8ea5/ui/base/cocoa/base_view.mm
[modify] https://crrev.com/07171a4c0cda43aa639f8b1b6ec28b46754e8ea5/ui/gfx/mac/io_surface.cc
[modify] https://crrev.com/07171a4c0cda43aa639f8b1b6ec28b46754e8ea5/ui/gfx/mac/scoped_cocoa_disable_screen_updates.h
[modify] https://crrev.com/07171a4c0cda43aa639f8b1b6ec28b46754e8ea5/ui/gfx/render_text_mac.mm
[modify] https://crrev.com/07171a4c0cda43aa639f8b1b6ec28b46754e8ea5/ui/gl/test/gl_image_test_template.h
[modify] https://crrev.com/07171a4c0cda43aa639f8b1b6ec28b46754e8ea5/ui/native_theme/native_theme_mac.mm
[modify] https://crrev.com/07171a4c0cda43aa639f8b1b6ec28b46754e8ea5/ui/native_theme/native_theme_mac_unittest.cc
[modify] https://crrev.com/07171a4c0cda43aa639f8b1b6ec28b46754e8ea5/ui/views/cocoa/bridged_content_view.mm
[modify] https://crrev.com/07171a4c0cda43aa639f8b1b6ec28b46754e8ea5/ui/views/cocoa/bridged_native_widget.mm
[modify] https://crrev.com/07171a4c0cda43aa639f8b1b6ec28b46754e8ea5/ui/views/controls/menu/menu_config_mac.mm

Comment 3 by sdy@chromium.org, Aug 30 2016

Status: Fixed (was: Assigned)
I have a couple of extra CLs out related to this bug, but the important bit is done.
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9745ad33c757b587eade6247bff56379576c6fa7

commit 9745ad33c757b587eade6247bff56379576c6fa7
Author: sdy <sdy@chromium.org>
Date: Tue Aug 30 19:24:49 2016

Just skip deployment target checks for OS versions newer than our SDK

Instead of guessing what *would* have been the OS X version constant for
a version our SDK doesn't even support and then asserting when we're
wrong, just skip the check when it doesn't matter.

BUG= 636093 

Review-Url: https://codereview.chromium.org/2289173002
Cr-Commit-Position: refs/heads/master@{#415391}

[modify] https://crrev.com/9745ad33c757b587eade6247bff56379576c6fa7/base/mac/mac_util.h
►

Sign in to add a comment